Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28280

Wrong Job Group is shown in the selector

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I found a bug in the jobGroupName-select tag. It added the selected attribute on each option that was not selected, instead of the one that should have been selected.

      Hence we ended up with this HTML-ouput.

      <tr nameref="rowSetStart44">
          <td class="setting-leftspace">&nbsp;</td>
          <td class="setting-name">Job Group</td>
          <td class="setting-main">
              <select name="jobGroupName">
                  <option value="Top Priority">Top Priority</option>
                  <option selected="true" value="Features">Features</option>
                  <option selected="true" value="Slow and steady">Slow and steady</option>
              </select>
          </td>
          <td class="setting-no-help"></td>
      </tr>
      

      In my case, the option Top Priority should have been choosen, instead Slow and steady was shown. When I looked at my current saved configuration for this specific job, I saw that Top Priority was saved, so it works correctly, it just shows the wrong jobGroupName.

        Attachments

          Activity

          Hide
          kyrremann Kyrre Havik Eriksen added a comment -
          Show
          kyrremann Kyrre Havik Eriksen added a comment - Pull request can be found here: https://github.com/jenkinsci/priority-sorter-plugin/pull/24
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: emsa23
          Path:
          src/main/resources/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionCloudbeesFolderProperty/config.jelly
          http://jenkins-ci.org/commit/priority-sorter-plugin/cc14f2ee194bd75d4fb6c48055fc9cb322421280
          Log:
          Merge pull request #24 from Kyrremann/master

          JENKINS-28280 The selected-attribut was inverted

          Compare: https://github.com/jenkinsci/priority-sorter-plugin/compare/766301d4ca00...cc14f2ee194b

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: emsa23 Path: src/main/resources/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionCloudbeesFolderProperty/config.jelly http://jenkins-ci.org/commit/priority-sorter-plugin/cc14f2ee194bd75d4fb6c48055fc9cb322421280 Log: Merge pull request #24 from Kyrremann/master JENKINS-28280 The selected-attribut was inverted Compare: https://github.com/jenkinsci/priority-sorter-plugin/compare/766301d4ca00...cc14f2ee194b
          Hide
          emsa23 Magnus Sandberg added a comment -

          Fixed in 3.1

          Show
          emsa23 Magnus Sandberg added a comment - Fixed in 3.1
          Hide
          kyrremann Kyrre Havik Eriksen added a comment -

          I found out that I was missing one config.jelly when I did this last time.
          See https://github.com/jenkinsci/priority-sorter-plugin/pull/28

          Show
          kyrremann Kyrre Havik Eriksen added a comment - I found out that I was missing one config.jelly when I did this last time. See https://github.com/jenkinsci/priority-sorter-plugin/pull/28
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: emsa23
          Path:
          src/main/resources/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionJobProperty/config.jelly
          http://jenkins-ci.org/commit/priority-sorter-plugin/a1e32f94d2b82384ad076a1de6dbf050b62f1b1b
          Log:
          Merge pull request #28 from Kyrremann/JENKINS-28280_The_selected-attribut_was_inverted

          JENKINS-28280 The selected value was inverted

          Compare: https://github.com/jenkinsci/priority-sorter-plugin/compare/5d7cc0e68b96...a1e32f94d2b8

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: emsa23 Path: src/main/resources/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionJobProperty/config.jelly http://jenkins-ci.org/commit/priority-sorter-plugin/a1e32f94d2b82384ad076a1de6dbf050b62f1b1b Log: Merge pull request #28 from Kyrremann/ JENKINS-28280 _The_selected-attribut_was_inverted JENKINS-28280 The selected value was inverted Compare: https://github.com/jenkinsci/priority-sorter-plugin/compare/5d7cc0e68b96...a1e32f94d2b8

            People

            • Assignee:
              kyrremann Kyrre Havik Eriksen
              Reporter:
              kyrremann Kyrre Havik Eriksen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: