Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28419

NPE may happen if somebody tries to drop the e-mail JenkinsLocationConfiguration:setAdminAddress()

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Bug or enhancement...

      The behavior is not documented, but Jenkins URL can be dropped from the class. Null is being checked in getter methods, so it is no particular reason to prohibit the case.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/test/java/jenkins/model/JenkinsLocationConfigurationTest.java
          http://jenkins-ci.org/commit/jenkins/dab392f80f68d222272846927dc7345f80887f63
          Log:
          JENKINS-28419 - Direct unit tests for JenkinsLocationConfiguration::adminAddress setter and getter

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/test/java/jenkins/model/JenkinsLocationConfigurationTest.java http://jenkins-ci.org/commit/jenkins/dab392f80f68d222272846927dc7345f80887f63 Log: JENKINS-28419 - Direct unit tests for JenkinsLocationConfiguration::adminAddress setter and getter
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java
          http://jenkins-ci.org/commit/jenkins/17116a2129b808d64d76b5dcba9d3037003aed30
          Log:
          [FIXED JENKINS-28419] - Support the reset of JenkinsLocationConfiguration::adminAddress

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java http://jenkins-ci.org/commit/jenkins/17116a2129b808d64d76b5dcba9d3037003aed30 Log: [FIXED JENKINS-28419] - Support the reset of JenkinsLocationConfiguration::adminAddress
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/ExtensionList.java
          core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java
          core/src/test/java/jenkins/model/JenkinsLocationConfigurationTest.java
          http://jenkins-ci.org/commit/jenkins/7e4171ca5bb338aa8aba99d22c77991e20c76115
          Log:
          Merge pull request #1707 from oleg-nenashev/jenkins_local_config

          [FIXED JENKINS-28419] - JenkinsLocationConfiguration::adminAddress can be reset

          Compare: https://github.com/jenkinsci/jenkins/compare/17f5227b1af6...7e4171ca5bb3

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/ExtensionList.java core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java core/src/test/java/jenkins/model/JenkinsLocationConfigurationTest.java http://jenkins-ci.org/commit/jenkins/7e4171ca5bb338aa8aba99d22c77991e20c76115 Log: Merge pull request #1707 from oleg-nenashev/jenkins_local_config [FIXED JENKINS-28419] - JenkinsLocationConfiguration::adminAddress can be reset Compare: https://github.com/jenkinsci/jenkins/compare/17f5227b1af6...7e4171ca5bb3
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #4155

          Result = UNSTABLE

          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4155 Result = UNSTABLE
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/test/java/jenkins/model/JenkinsLocationConfigurationTest.java
          http://jenkins-ci.org/commit/jenkins/4c11691a8f020a31194366b24ffc05de40049884
          Log:
          JENKINS-28419 - Direct unit tests for JenkinsLocationConfiguration::adminAddress setter and getter

          (cherry picked from commit dab392f80f68d222272846927dc7345f80887f63)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/test/java/jenkins/model/JenkinsLocationConfigurationTest.java http://jenkins-ci.org/commit/jenkins/4c11691a8f020a31194366b24ffc05de40049884 Log: JENKINS-28419 - Direct unit tests for JenkinsLocationConfiguration::adminAddress setter and getter (cherry picked from commit dab392f80f68d222272846927dc7345f80887f63)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java
          http://jenkins-ci.org/commit/jenkins/b8ce8da7888453ff32190de3c3f2467897864334
          Log:
          [FIXED JENKINS-28419] - Support the reset of JenkinsLocationConfiguration::adminAddress

          (cherry picked from commit 17116a2129b808d64d76b5dcba9d3037003aed30)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java http://jenkins-ci.org/commit/jenkins/b8ce8da7888453ff32190de3c3f2467897864334 Log: [FIXED JENKINS-28419] - Support the reset of JenkinsLocationConfiguration::adminAddress (cherry picked from commit 17116a2129b808d64d76b5dcba9d3037003aed30)
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #4292
          JENKINS-28419 - Direct unit tests for JenkinsLocationConfiguration::adminAddress setter and getter (Revision 4c11691a8f020a31194366b24ffc05de40049884)
          [FIXED JENKINS-28419] - Support the reset of JenkinsLocationConfiguration::adminAddress (Revision b8ce8da7888453ff32190de3c3f2467897864334)

          Result = UNSTABLE
          ogondza : 4c11691a8f020a31194366b24ffc05de40049884
          Files :

          • core/src/test/java/jenkins/model/JenkinsLocationConfigurationTest.java

          ogondza : b8ce8da7888453ff32190de3c3f2467897864334
          Files :

          • core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4292 JENKINS-28419 - Direct unit tests for JenkinsLocationConfiguration::adminAddress setter and getter (Revision 4c11691a8f020a31194366b24ffc05de40049884) [FIXED JENKINS-28419] - Support the reset of JenkinsLocationConfiguration::adminAddress (Revision b8ce8da7888453ff32190de3c3f2467897864334) Result = UNSTABLE ogondza : 4c11691a8f020a31194366b24ffc05de40049884 Files : core/src/test/java/jenkins/model/JenkinsLocationConfigurationTest.java ogondza : b8ce8da7888453ff32190de3c3f2467897864334 Files : core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java

            People

            • Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: