Details

    • Similar Issues:

      Description

      In [1] the plugin switched from org.apache.tools.zip/java.util.zip to de.schlichtherle.truezip. While this is certainly necessary for extraction, perhaps it is possible to keep using apache-via-FilePath for compression avoiding a lot of ping-ponging over network.

      [1] https://github.com/jenkinsci/compress-artifacts-plugin/commit/e4cf3284f14c919fb6bd95bfb147180569500623

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/main/java/org/jenkinsci/plugins/compress_artifacts/ZipStorage.java
          http://jenkins-ci.org/commit/compress-artifacts-plugin/8650e1d6ae90cade6920d2447688c5935a4f457f
          Log:
          [FIXED JENKINS-28862] Optimize artifact archiving

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/org/jenkinsci/plugins/compress_artifacts/ZipStorage.java http://jenkins-ci.org/commit/compress-artifacts-plugin/8650e1d6ae90cade6920d2447688c5935a4f457f Log: [FIXED JENKINS-28862] Optimize artifact archiving
          Hide
          olivergondza Oliver Gondža added a comment - - edited

          mcrooney, I am releasing 1.6 with this fix. It should be significantly faster. I was able to compress whole Jenkins repo in 3.5s while it took 7s before the fix. I expect the difference will be more dramatic using slaves with non-zero latencies.

          Show
          olivergondza Oliver Gondža added a comment - - edited mcrooney , I am releasing 1.6 with this fix. It should be significantly faster. I was able to compress whole Jenkins repo in 3.5s while it took 7s before the fix. I expect the difference will be more dramatic using slaves with non-zero latencies.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/main/java/org/jenkinsci/plugins/compress_artifacts/ZipStorage.java
          http://jenkins-ci.org/commit/compress-artifacts-plugin/59bf4a86f2df08222555d457e6f383d40a73142a
          Log:
          Revert "[FIXED JENKINS-28862] Optimize artifact archiving"

          This reverts commit 8650e1d6ae90cade6920d2447688c5935a4f457f.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/org/jenkinsci/plugins/compress_artifacts/ZipStorage.java http://jenkins-ci.org/commit/compress-artifacts-plugin/59bf4a86f2df08222555d457e6f383d40a73142a Log: Revert " [FIXED JENKINS-28862] Optimize artifact archiving" This reverts commit 8650e1d6ae90cade6920d2447688c5935a4f457f.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/main/java/org/jenkinsci/plugins/compress_artifacts/TrueZipArchiver.java
          src/main/java/org/jenkinsci/plugins/compress_artifacts/ZipStorage.java
          http://jenkins-ci.org/commit/compress-artifacts-plugin/6f6932c8712602c9760d8a7e7eb26a06c676a8df
          Log:
          JENKINS-28862JENKINS-27042 Perform archiving using truezip via one remoting roundtrip.

          JENKINS-28862 was resolved so it introduced a regression for JENKINS-27042
          in 1.6. Now both should be resolved implementing hudson.util.io.Archiver,
          based on truezip.

          Compare: https://github.com/jenkinsci/compress-artifacts-plugin/compare/af852f71458e...6f6932c87126

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/org/jenkinsci/plugins/compress_artifacts/TrueZipArchiver.java src/main/java/org/jenkinsci/plugins/compress_artifacts/ZipStorage.java http://jenkins-ci.org/commit/compress-artifacts-plugin/6f6932c8712602c9760d8a7e7eb26a06c676a8df Log: JENKINS-28862 JENKINS-27042 Perform archiving using truezip via one remoting roundtrip. JENKINS-28862 was resolved so it introduced a regression for JENKINS-27042 in 1.6. Now both should be resolved implementing hudson.util.io.Archiver, based on truezip. Compare: https://github.com/jenkinsci/compress-artifacts-plugin/compare/af852f71458e...6f6932c87126
          Hide
          mcrooney mcrooney added a comment - - edited

          Thanks so much Oliver, this is fantastic! I tested the latest commit and it is indeed much faster, and loading job/build pages that archive large artifacts also seem much faster, if that's possible Just needs a release and Wiki update!

          Show
          mcrooney mcrooney added a comment - - edited Thanks so much Oliver, this is fantastic! I tested the latest commit and it is indeed much faster, and loading job/build pages that archive large artifacts also seem much faster, if that's possible Just needs a release and Wiki update!

            People

            • Assignee:
              olivergondza Oliver Gondža
              Reporter:
              olivergondza Oliver Gondža
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: