Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29093

POM location is deleted when changing Maven top-level target

    Details

    • Similar Issues:

      Description

      I noticed that setting the Maven top-level target for a job deletes the job's POM location setting.

      I can reproduce this as follows:

      1. There's a freestyle project with a Maven Build step. The Goals are "clean verify", the POM location is "myproject-parent/pom.xml".
      2. Change the Maven goal with the Configuration Slicing Plugin to "clean package"

      Result:
      The POM location is empty.

        Attachments

          Activity

          Hide
          alskor Alex Java added a comment -

          I think all data corruption bugs should have "critical" priority. it's one thing when data is not updated / ignored, but it's much worse when plugin can erase/damage existing data.

          Show
          alskor Alex Java added a comment - I think all data corruption bugs should have "critical" priority. it's one thing when data is not updated / ignored, but it's much worse when plugin can erase/damage existing data.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michael Donohue
          Path:
          .project
          pom.xml
          src/main/java/configurationslicing/executeshell/MavenTargetsSlicer.java
          http://jenkins-ci.org/commit/configurationslicing-plugin/120e5ee47bfdb1551755fbcd831a979159cc9071
          Log:
          Copy all existing maven config values to newly created builder

          JENKINS-29093 The Maven top-level target slicer was trying to be
          careful about the maven installation version used, but this ends up
          breaking other maven settings when the default maven installation is used.

          The fix is to copy the config values if we have an old maven builder,
          regardless of whether it has a maven installation version set.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michael Donohue Path: .project pom.xml src/main/java/configurationslicing/executeshell/MavenTargetsSlicer.java http://jenkins-ci.org/commit/configurationslicing-plugin/120e5ee47bfdb1551755fbcd831a979159cc9071 Log: Copy all existing maven config values to newly created builder JENKINS-29093 The Maven top-level target slicer was trying to be careful about the maven installation version used, but this ends up breaking other maven settings when the default maven installation is used. The fix is to copy the config values if we have an old maven builder, regardless of whether it has a maven installation version set.
          Hide
          mdonohue mdonohue added a comment -

          Released in the 1.44 version of configurationslicing

          Show
          mdonohue mdonohue added a comment - Released in the 1.44 version of configurationslicing
          Hide
          arend_von_reinersdorff Arend v. Reinersdorff added a comment -

          POM location is no longer deleted with version 1.44. Thanks a lot

          Show
          arend_von_reinersdorff Arend v. Reinersdorff added a comment - POM location is no longer deleted with version 1.44. Thanks a lot

            People

            • Assignee:
              mdonohue mdonohue
              Reporter:
              arend_von_reinersdorff Arend v. Reinersdorff
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: