Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29218

Ability to use environment variables in unity adresses

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      It would make it really neat if it was possible tp use environment variables in unity paths, since everzthing in jenkins is controlled by them.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jerome Lacoste
          Path:
          src/main/java/org/jenkinsci/plugins/unity3d/Unity3dInstallation.java
          http://jenkins-ci.org/commit/unity3d-plugin/70c73f22d32ec3e629b953632029bae605816689
          Log:
          JENKINS-29218 remove unecessary boxing of exception message

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jerome Lacoste Path: src/main/java/org/jenkinsci/plugins/unity3d/Unity3dInstallation.java http://jenkins-ci.org/commit/unity3d-plugin/70c73f22d32ec3e629b953632029bae605816689 Log: JENKINS-29218 remove unecessary boxing of exception message
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jerome Lacoste
          Path:
          src/main/java/org/jenkinsci/plugins/unity3d/Unity3dInstallation.java
          src/main/resources/org/jenkinsci/plugins/unity3d/Messages.properties
          src/main/resources/org/jenkinsci/plugins/unity3d/Unity3dInstallation/help-home.html
          http://jenkins-ci.org/commit/unity3d-plugin/bd249a4e7466c2a89ae030b224bd5a73b5e94b7c
          Log:
          [FIXED JENKINS-29218] improve documentation and feedback when using parametrized path for jenkins installation homes. Note that: we do not re-expand from master env vars twice anymore, we use the path and not the absolute path (that could break things if people used relative paths for Unity3d installs, but it makes the message about unresolved path accurate

          Compare: https://github.com/jenkinsci/unity3d-plugin/compare/ca2063104459...bd249a4e7466

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jerome Lacoste Path: src/main/java/org/jenkinsci/plugins/unity3d/Unity3dInstallation.java src/main/resources/org/jenkinsci/plugins/unity3d/Messages.properties src/main/resources/org/jenkinsci/plugins/unity3d/Unity3dInstallation/help-home.html http://jenkins-ci.org/commit/unity3d-plugin/bd249a4e7466c2a89ae030b224bd5a73b5e94b7c Log: [FIXED JENKINS-29218] improve documentation and feedback when using parametrized path for jenkins installation homes. Note that: we do not re-expand from master env vars twice anymore, we use the path and not the absolute path (that could break things if people used relative paths for Unity3d installs, but it makes the message about unresolved path accurate Compare: https://github.com/jenkinsci/unity3d-plugin/compare/ca2063104459...bd249a4e7466
          Hide
          lacostej lacostej added a comment -

          I made a commit to improve documentation and detection of configuration that contain variables. Feel free to try the latest build. It's not yet released as 1.1 but would appreciate the feedback before I release it.

          Show
          lacostej lacostej added a comment - I made a commit to improve documentation and detection of configuration that contain variables. Feel free to try the latest build. It's not yet released as 1.1 but would appreciate the feedback before I release it.
          Hide
          lacostej lacostej added a comment - - edited

          Note that I've changed the way envVars were used.

          I tested it by creating unity installs like this one:

          Unity Variable
          /Applications/Unity${UNITY_VERSION}/Unity.app
          
          Unity Variable Full
          ${UNITY_HOME}
          

          and created UNITY_HOME and UNITY_VERSION under the master env vars or the job (using EnvIject).

          Show
          lacostej lacostej added a comment - - edited Note that I've changed the way envVars were used. I tested it by creating unity installs like this one: Unity Variable /Applications/Unity${UNITY_VERSION}/Unity.app Unity Variable Full ${UNITY_HOME} and created UNITY_HOME and UNITY_VERSION under the master env vars or the job (using EnvIject).
          Hide
          perun Petr Vejchoda added a comment -

          Ok, works well for me.

          Show
          perun Petr Vejchoda added a comment - Ok, works well for me.

            People

            • Assignee:
              lacostej lacostej
              Reporter:
              perun Petr Vejchoda
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: