Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29899

change cookie path from / to rootURL

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I use jenkins http://example.com/jenkins.
      A cookie path of timestamper-plugin is /.
      So the cookie is send to http://example.com/foo.

        Attachments

          Issue Links

            Activity

            Hide
            stevengbrown Steven G Brown added a comment -

            Thanks! Your patch will be included in the next release, 1.7.2.

            Show
            stevengbrown Steven G Brown added a comment - Thanks! Your patch will be included in the next release, 1.7.2.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Steven Brown
            Path:
            src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory/script.js
            http://jenkins-ci.org/commit/timestamper-plugin/d64fd051781675b94c8b55705f0ae99757231eb2
            Log:
            [FIXED JENKINS-29899] Change cookie path from '/' to the root URL of Jenkins

            Patch contributed by Kiyoshi Ohgishi.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Steven Brown Path: src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory/script.js http://jenkins-ci.org/commit/timestamper-plugin/d64fd051781675b94c8b55705f0ae99757231eb2 Log: [FIXED JENKINS-29899] Change cookie path from '/' to the root URL of Jenkins Patch contributed by Kiyoshi Ohgishi.
            Hide
            kiyoshi Kiyoshi Ohgishi added a comment -

            Thanks!

            Show
            kiyoshi Kiyoshi Ohgishi added a comment - Thanks!
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Steven Brown
            Path:
            src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory/script.js
            http://jenkins-ci.org/commit/timestamper-plugin/26f6fdb2d47f88e1fe8afd454407fc5283eaeb6b
            Log:
            [FIXED JENKINS-32074] When rootURL is empty, store cookies at '/'

            When Jenkins is running from the top-level URL, the rootURL variable is an empty
            string. In this case, store the cookies at '/' instead of rootURL.

            Prior to this change, the cookies were created with an empty path, and the
            browser defaults to storing them at the build URL. These cookies will now be
            deleted because they would override the cookies stored at the Jenkins URL.

            Bug introduced by JENKINS-29899.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Steven Brown Path: src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory/script.js http://jenkins-ci.org/commit/timestamper-plugin/26f6fdb2d47f88e1fe8afd454407fc5283eaeb6b Log: [FIXED JENKINS-32074] When rootURL is empty, store cookies at '/' When Jenkins is running from the top-level URL, the rootURL variable is an empty string. In this case, store the cookies at '/' instead of rootURL. Prior to this change, the cookies were created with an empty path, and the browser defaults to storing them at the build URL. These cookies will now be deleted because they would override the cookies stored at the Jenkins URL. Bug introduced by JENKINS-29899 .

              People

              • Assignee:
                stevengbrown Steven G Brown
                Reporter:
                kiyoshi Kiyoshi Ohgishi
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: