Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29941

Using Configuration Slicer unsets the "Ignore post-commit hooks" checkbox for polled builds

    Details

    • Similar Issues:

      Description

      I have a suite of 40 test jobs.
      These are all set up to poll my Github (Enterprise) repository every 5 minutes.
      I recently went in and did a mass edit of my jobs using Configuration Slicer.
      Before using Configuration Slicer, my jobs all had the "Ignore post-commit hooks" checkbox checked.
      I saved my changes, and then rebooted Jenkins, and noticed all of my polled builds ran. This should not have happened.
      I went into my projects and found that the checkbox had become unchecked.

        Attachments

          Activity

          Hide
          mdonohue mdonohue added a comment -

          Yes, SCMTrigger now has two constructors. Configuration slicing uses the older one, which defaults the "Ignore post-comits hooks" value to 'false'.

          To fix this, we will need to include the post-commit hooks option in the configuration slice spec. I played around with some ideas here last night, but didn't get something that worked well. The current design doesn't handle this well, so I think the slicing logic will need more parameterization to make this work.

          Show
          mdonohue mdonohue added a comment - Yes, SCMTrigger now has two constructors. Configuration slicing uses the older one, which defaults the "Ignore post-comits hooks" value to 'false'. To fix this, we will need to include the post-commit hooks option in the configuration slice spec. I played around with some ideas here last night, but didn't get something that worked well. The current design doesn't handle this well, so I think the slicing logic will need more parameterization to make this work.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michael Donohue
          Path:
          src/main/java/configurationslicing/timer/AbstractTimerSliceSpec.java
          src/main/java/configurationslicing/timer/SCMTimerSliceStringSlicer.java
          src/main/java/configurationslicing/timer/TimerSliceStringSlicer.java
          http://jenkins-ci.org/commit/configurationslicing-plugin/7474a28792b19149354799e5a38652fef9eb8b8a
          Log:
          Provide the old trigger object when configuring a new timer trigger

          This allows the slice implementor to copy any values that are not
          of interest to the given slice. This was motivated by the bug
          JENKINS-29941, and this commit includes a fix for that bug.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michael Donohue Path: src/main/java/configurationslicing/timer/AbstractTimerSliceSpec.java src/main/java/configurationslicing/timer/SCMTimerSliceStringSlicer.java src/main/java/configurationslicing/timer/TimerSliceStringSlicer.java http://jenkins-ci.org/commit/configurationslicing-plugin/7474a28792b19149354799e5a38652fef9eb8b8a Log: Provide the old trigger object when configuring a new timer trigger This allows the slice implementor to copy any values that are not of interest to the given slice. This was motivated by the bug JENKINS-29941 , and this commit includes a fix for that bug.
          Hide
          mdonohue mdonohue added a comment -

          Released in the 1.44 version of configurationslicing

          Show
          mdonohue mdonohue added a comment - Released in the 1.44 version of configurationslicing

            People

            • Assignee:
              mdonohue mdonohue
              Reporter:
              mcsf M Chon
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: