Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29943

Pin to Label populate option doesn't support empty parameter values

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      If the pin to label field is set to a macro referencing a build parameter ( e.g. ${SOMEVAR} ), then syncing fails when that parameter value is left empty.

      The expected behavior is that the workspace will be synced to head as if the pin to label field was left empty.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: stuartrowe
          Path:
          src/main/java/org/jenkinsci/plugins/p4/tasks/CheckoutTask.java
          http://jenkins-ci.org/commit/p4-plugin/9dba27bcfa43f95879c33bf175f725c5e2881188
          Log:
          JENKINS-29943: Check for empty param values

          Adding an isEmpty() check after expanding the value of the
          populateLabel, since a parameter value may be empty.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: stuartrowe Path: src/main/java/org/jenkinsci/plugins/p4/tasks/CheckoutTask.java http://jenkins-ci.org/commit/p4-plugin/9dba27bcfa43f95879c33bf175f725c5e2881188 Log: JENKINS-29943 : Check for empty param values Adding an isEmpty() check after expanding the value of the populateLabel, since a parameter value may be empty.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Paul Allen
          Path:
          src/main/java/org/jenkinsci/plugins/p4/tasks/CheckoutTask.java
          http://jenkins-ci.org/commit/p4-plugin/796ace09849f3074b5c5963a1db3fad5809a801d
          Log:
          Merge pull request #17 from stuartrowe/master

          JENKINS-29943: Check for empty param values

          Compare: https://github.com/jenkinsci/p4-plugin/compare/2ad1c6a6c9af...796ace09849f

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/tasks/CheckoutTask.java http://jenkins-ci.org/commit/p4-plugin/796ace09849f3074b5c5963a1db3fad5809a801d Log: Merge pull request #17 from stuartrowe/master JENKINS-29943 : Check for empty param values Compare: https://github.com/jenkinsci/p4-plugin/compare/2ad1c6a6c9af...796ace09849f
          Hide
          p4paul Paul Allen added a comment -

          Released

          Show
          p4paul Paul Allen added a comment - Released

            People

            • Assignee:
              p4paul Paul Allen
              Reporter:
              stuartrowe Stuart Rowe
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: