Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30092

node that is marked temporarily offline is lost across restart

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • core
    • CentOS 7.1.1503 (64-bit)
      java 1.8.0 openjdk
      jenkins 1.625 installed from rpm
      running jenkins natively
      latest firefox browser from distro

      After marking a node temporarily offline then restarting, offline status is lost, nodes are reconnected.

      JENKINS-8196 implies nodes should remain marked offline across restarts.

      Node Availability is "keep on-line as much as possible".

      What is the meaning of "mark temporarily", what is the expected behaviour across reboots given the potential conflict of interest with Availability?

          [JENKINS-30092] node that is marked temporarily offline is lost across restart

          I've just upgraded from 1.565.3 to 1.690.3 and just seen this regression.

          With 1.565.3 configuration of all slaves were in global /var/lib/jenkins/config.xml,

          Now every node has its own config file in /var/lib/jenkins/nodes/<node_name>/config.xml. ( which is great)
          With older Jenkins as soon as the node was set offline, the /var/lib/jenkins/config.xml was updated.

          It is not the case any more, putting a slave offline & online will not modify the <node_name>/config.xml file.
          A flush to disk is missing in the code when changing the node state.

          When shutting down jenkins, the node config files are still not updated.

          A workaround is to edit configuration of any slave, and just press save. This will update configuration off all slaves on disk.

          Bertrand Latinville added a comment - I've just upgraded from 1.565.3 to 1.690.3 and just seen this regression. With 1.565.3 configuration of all slaves were in global /var/lib/jenkins/config.xml, Now every node has its own config file in /var/lib/jenkins/nodes/<node_name>/config.xml. ( which is great) With older Jenkins as soon as the node was set offline, the /var/lib/jenkins/config.xml was updated. It is not the case any more, putting a slave offline & online will not modify the <node_name>/config.xml file. A flush to disk is missing in the code when changing the node state. When shutting down jenkins, the node config files are still not updated. A workaround is to edit configuration of any slave, and just press save. This will update configuration off all slaves on disk.

          I am also seeing this, offline status does not persist across reboots on Jenkins (tried 1.625.2, 1.631). This is a noticeable inconvenience when trying to do maintenance that involves making nodes offline.

          The workaround posted by blatinville appears to help (thanks!) but it would be a lot nicer if this "just worked".

          Tomasz Śniatowski added a comment - I am also seeing this, offline status does not persist across reboots on Jenkins (tried 1.625.2, 1.631). This is a noticeable inconvenience when trying to do maintenance that involves making nodes offline. The workaround posted by blatinville appears to help (thanks!) but it would be a lot nicer if this "just worked".

          Kieron Davies added a comment -

          Can confirm bug still exists in Version 2.11 - Would like to see an update on this.

          Kieron Davies added a comment - Can confirm bug still exists in Version 2.11 - Would like to see an update on this.

          Oleg Nenashev added a comment -

          Likely it is a valid defect.

          Oleg Nenashev added a comment - Likely it is a valid defect.

            Unassigned Unassigned
            hesh Chris Steinbroner
            Votes:
            7 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated: