Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30167

Improve current behavior of description concatenation

    Details

    • Similar Issues:

      Description

      This effort is follow-up of JENKINS-26671 and can solve JENKINS-28006 at least partially.

      Current behavior is a new description is always concatenated with the previous one. In addition, description from build phase(s) is mixed with the post-build description as well.

      I'm going to change that behavior and leave the user to decide when description should be added like a concatenation (current state) and when the description should rewrite it.

        Attachments

          Issue Links

            Activity

            Hide
            pajasoft Pavel Janoušek added a comment -

            PR sent.

            Show
            pajasoft Pavel Janoušek added a comment - PR sent.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ing. Pavel Janousek
            Path:
            .gitignore
            pom.xml
            src/main/java/hudson/plugins/descriptionsetter/DescriptionSetterBuilder.java
            src/main/java/hudson/plugins/descriptionsetter/DescriptionSetterHelper.java
            src/main/java/hudson/plugins/descriptionsetter/DescriptionSetterPublisher.java
            src/main/resources/hudson/plugins/descriptionsetter/DescriptionSetterBuilder/config.jelly
            src/main/resources/hudson/plugins/descriptionsetter/DescriptionSetterPublisher/config.jelly
            src/test/java/hudson/plugins/descriptionsetter/DescriptionSetterBuilderTest.java
            src/test/java/hudson/plugins/descriptionsetter/DescriptionSetterPublisherTest.java
            http://jenkins-ci.org/commit/description-setter-plugin/1910cb65da8583561cf209c96155c18dbc0eace7
            Log:
            JENKINS-30167 Added an option for driving a concatenation mode

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ing. Pavel Janousek Path: .gitignore pom.xml src/main/java/hudson/plugins/descriptionsetter/DescriptionSetterBuilder.java src/main/java/hudson/plugins/descriptionsetter/DescriptionSetterHelper.java src/main/java/hudson/plugins/descriptionsetter/DescriptionSetterPublisher.java src/main/resources/hudson/plugins/descriptionsetter/DescriptionSetterBuilder/config.jelly src/main/resources/hudson/plugins/descriptionsetter/DescriptionSetterPublisher/config.jelly src/test/java/hudson/plugins/descriptionsetter/DescriptionSetterBuilderTest.java src/test/java/hudson/plugins/descriptionsetter/DescriptionSetterPublisherTest.java http://jenkins-ci.org/commit/description-setter-plugin/1910cb65da8583561cf209c96155c18dbc0eace7 Log: JENKINS-30167 Added an option for driving a concatenation mode
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Pavel Janousek
            Path:
            .gitignore
            pom.xml
            src/main/java/hudson/plugins/descriptionsetter/DescriptionSetterBuilder.java
            src/main/java/hudson/plugins/descriptionsetter/DescriptionSetterHelper.java
            src/main/java/hudson/plugins/descriptionsetter/DescriptionSetterPublisher.java
            src/main/resources/hudson/plugins/descriptionsetter/DescriptionSetterBuilder/config.jelly
            src/main/resources/hudson/plugins/descriptionsetter/DescriptionSetterPublisher/config.jelly
            src/test/java/hudson/plugins/descriptionsetter/DescriptionSetterBuilderTest.java
            src/test/java/hudson/plugins/descriptionsetter/DescriptionSetterPublisherTest.java
            http://jenkins-ci.org/commit/description-setter-plugin/da0d0e96ef7a26e0685a9a31f688b718ba50a2b2
            Log:
            Merge pull request #9 from pjanouse/JENKINS-30167

            JENKINS-30167 Added an option for driving a concatenation mode

            Compare: https://github.com/jenkinsci/description-setter-plugin/compare/2efd75864daa...da0d0e96ef7a

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Pavel Janousek Path: .gitignore pom.xml src/main/java/hudson/plugins/descriptionsetter/DescriptionSetterBuilder.java src/main/java/hudson/plugins/descriptionsetter/DescriptionSetterHelper.java src/main/java/hudson/plugins/descriptionsetter/DescriptionSetterPublisher.java src/main/resources/hudson/plugins/descriptionsetter/DescriptionSetterBuilder/config.jelly src/main/resources/hudson/plugins/descriptionsetter/DescriptionSetterPublisher/config.jelly src/test/java/hudson/plugins/descriptionsetter/DescriptionSetterBuilderTest.java src/test/java/hudson/plugins/descriptionsetter/DescriptionSetterPublisherTest.java http://jenkins-ci.org/commit/description-setter-plugin/da0d0e96ef7a26e0685a9a31f688b718ba50a2b2 Log: Merge pull request #9 from pjanouse/ JENKINS-30167 JENKINS-30167 Added an option for driving a concatenation mode Compare: https://github.com/jenkinsci/description-setter-plugin/compare/2efd75864daa...da0d0e96ef7a
            Hide
            pajasoft Pavel Janoušek added a comment -

            Merged...

            Show
            pajasoft Pavel Janoušek added a comment - Merged...
            Hide
            fsilva Filipe Silva added a comment -

            Please release this. I really need it urgently!

            Show
            fsilva Filipe Silva added a comment - Please release this. I really need it urgently!
            Hide
            pajasoft Pavel Janoušek added a comment -

            Filipe Silva I'm not a maintainer of this plug-in you should ask the owner.

            Show
            pajasoft Pavel Janoušek added a comment - Filipe Silva I'm not a maintainer of this plug-in you should ask the owner.
            Hide
            bonaducci Maciej Załucki added a comment -

            As plugin is still not released (2 years since last release), I'll share already built snapshot including this fix. I also needed this functionality.
            description-setter-plugin-1.11-SNAPSHOT.tar.gz
            description-setter-plugin-1.11-SNAPSHOT.zip

            Show
            bonaducci Maciej Załucki added a comment - As plugin is still not released (2 years since last release), I'll share already built snapshot including this fix. I also needed this functionality. description-setter-plugin-1.11-SNAPSHOT.tar.gz description-setter-plugin-1.11-SNAPSHOT.zip
            Hide
            bonaducci Maciej Załucki added a comment -

            I found out that this improvement was not applied to matrix build description. The best idea would be adding second checkbox if we want to concatenate it fox matrix build or not. Anyways, I've done small fix so current setting is also applied to matrix build description.
            Code changes
            description-setter-plugin-1.11.2-SNAPSHOT.zip
            description-setter-plugin-1.11.2-SNAPSHOT.tar.gz

            Show
            bonaducci Maciej Załucki added a comment - I found out that this improvement was not applied to matrix build description. The best idea would be adding second checkbox if we want to concatenate it fox matrix build or not. Anyways, I've done small fix so current setting is also applied to matrix build description. Code changes description-setter-plugin-1.11.2-SNAPSHOT.zip description-setter-plugin-1.11.2-SNAPSHOT.tar.gz

              People

              • Assignee:
                pajasoft Pavel Janoušek
                Reporter:
                pajasoft Pavel Janoušek
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: