Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30475

bad design for Polling vs Checkout algorithms

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Blocker Blocker
    • git-plugin
    • None
    • 2.4.0/1.18.0
      1.609.3

      After long time of debugging i found that current polling algorithm works in the next way:

      Polling:

      1. Get from remote repo branchnames + sha1
      2. compare with existed BuilData from latest build (ONE logic)
      3. If sha1/branch not found -> trigger build (NO RPA attached)

      Checkout:

      1. Build is running and it calls checkout() step in GITScm
      2. checkout() calls getBuildRevision that calls DefaultBuildChooser that calls getAdvancedCandidateRevisions() that calls revs = GitUtils.filterTipBranches(revs); (SECOND logic)
      3. filter tips removes all intermediate branches and they never appears in BuildData

      That ends in situations that Polling needs branches, but checkout didn't build them.
      I fixed this issue by commenting tips filtering https://github.com/KostyaSha/git-plugin/commit/8336202ee5ec8d5a12caa875aeba27b89ac3af58 this allowed build all branches and Polling now satisfied.

      Suggestion:

      1. Put RPA for triggered build as polling result -> allows ensure that BuildData will get what polling wants
      2. Use the same logic for checkout and polling -> more or less allows hope that checkout will pick what polling mean

            Unassigned Unassigned
            integer Kanstantsin Shautsou
            Votes:
            2 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated: