Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30868

Changes List in Project and Job is Displaying Last Change

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • p4-plugin
    • None
    • Jenkins 1.6.32
      P4Plugin 1.3.2
      Java 1.8.0_45-b15

      I have some builds that are not being triggered by polling. They are being triggered by upstream jobs, but they still need to sync some files to do their thing.

      The builds are displaying the last change that was made in the workspace even though the change was previously synced and built in a much earlier build. The effect is that other builds are still occurring, and no changes have occurred, but the last change is being reported each and every build.

      Rather than showing the last change from a previous build, something like "No Changes" should be displayed for each build when there are no changes to report. Hopefully the screenshots explain the issue better than I do. Screenshot 2 shows build 27 was launched on Oct 9, but it reported a change that was made on May 6 - which would be fine if there had been no previous builds, but previous builds already sync'ed and reported that change (as shown in screenshot 1).

      I'm only calling this a major, because this very much throws off team leads, etc. that are tracking changes in builds. They wonder why old changes are still being reported in their builds, or why their build has changes they didn't want, or why the infrastructure is broken.

        1. screenshot-1.png
          screenshot-1.png
          167 kB
        2. screenshot-2.png
          screenshot-2.png
          71 kB
        3. screenshot-3.png
          screenshot-3.png
          891 kB

          [JENKINS-30868] Changes List in Project and Job is Displaying Last Change

          Jason Davis added a comment -

          Just found a new wrinkle - I had a build post all the changes since the beginning of the workspace in addition to stating the build included changes from the previous build when there were no changes in between builds (screenshot 3). I have no explanation why the second to last build did this, there have been no configuration changes other than updating to the latest build of the P4 plugin and jenkins before that build. The latest build is still showing the last change from the previous build.

          Jason Davis added a comment - Just found a new wrinkle - I had a build post all the changes since the beginning of the workspace in addition to stating the build included changes from the previous build when there were no changes in between builds (screenshot 3). I have no explanation why the second to last build did this, there have been no configuration changes other than updating to the latest build of the P4 plugin and jenkins before that build. The latest build is still showing the last change from the previous build.

          Have added a fix and tested the changes. The fix is included in the pull request https://github.com/jenkinsci/p4-plugin/pull/22

          Prathap Subramanian added a comment - Have added a fix and tested the changes. The fix is included in the pull request https://github.com/jenkinsci/p4-plugin/pull/22

          Code changed in jenkins
          User: psubrama
          Path:
          src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java
          http://jenkins-ci.org/commit/p4-plugin/50d9b6b790ec7f032f1c65a419bd92e5965988a8
          Log:
          Fix ChangesList in Project and Job Displaying Last Change (JENKINS-30868)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: psubrama Path: src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java http://jenkins-ci.org/commit/p4-plugin/50d9b6b790ec7f032f1c65a419bd92e5965988a8 Log: Fix ChangesList in Project and Job Displaying Last Change ( JENKINS-30868 )

          This issue is fixed and merged into the master as part of the pull request.

          Prathap Subramanian added a comment - This issue is fixed and merged into the master as part of the pull request.

          Paul Allen added a comment -

          Resolved to Closed

          Paul Allen added a comment - Resolved to Closed

            jedavis Jason Davis
            jedavis Jason Davis
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: