Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31219

A CloudProvisioningListener can prevent provisioning of all clouds instead of just the targeted cloud

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      This is a regression introduced in 92a113c152fcd2cb3adc21b1d8b38aa522b802b4

      The CloudProvisioningListener.canProvision(Cloud,Label,int) method is supposed to

      Allow extensions to prevent a cloud from provisioning.

      However the current implementation will prevent all subsequent clouds from provisioning also as the break CLOUD; should actually have been continue CLOUD;

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/hudson/slaves/NodeProvisioner.java
          http://jenkins-ci.org/commit/jenkins/cc932c49afa8c2946a32555285e1aa52dc724ddf
          Log:
          [FIXED JENKINS-31219] A CloudProvisioningListener can prevent provisioning of all clouds instead of just the targeted cloud

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/slaves/NodeProvisioner.java http://jenkins-ci.org/commit/jenkins/cc932c49afa8c2946a32555285e1aa52dc724ddf Log: [FIXED JENKINS-31219] A CloudProvisioningListener can prevent provisioning of all clouds instead of just the targeted cloud
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/hudson/slaves/NodeProvisioner.java
          http://jenkins-ci.org/commit/jenkins/9339a34967dd095ba6fbaba40b41e33835fde866
          Log:
          Merge pull request #1891 from stephenc/jenkins-31219

          [FIXED JENKINS-31219] A CloudProvisioningListener can prevent provisiā€¦

          Compare: https://github.com/jenkinsci/jenkins/compare/8c8bbbbbad0c...9339a34967dd

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/slaves/NodeProvisioner.java http://jenkins-ci.org/commit/jenkins/9339a34967dd095ba6fbaba40b41e33835fde866 Log: Merge pull request #1891 from stephenc/jenkins-31219 [FIXED JENKINS-31219] A CloudProvisioningListener can prevent provisiā€¦ Compare: https://github.com/jenkinsci/jenkins/compare/8c8bbbbbad0c...9339a34967dd
          Hide
          danielbeck Daniel Beck added a comment -

          Stephen Connolly Should this be an lts-candidate?

          Show
          danielbeck Daniel Beck added a comment - Stephen Connolly Should this be an lts-candidate ?
          Hide
          stephenconnolly Stephen Connolly added a comment -

          Daniel Beck yep, added the label

          Show
          stephenconnolly Stephen Connolly added a comment - Daniel Beck yep, added the label
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_2.0 #5
          [FIXED JENKINS-31219] A CloudProvisioningListener can prevent (Revision cc932c49afa8c2946a32555285e1aa52dc724ddf)

          Result = SUCCESS
          stephen connolly : cc932c49afa8c2946a32555285e1aa52dc724ddf
          Files :

          • core/src/main/java/hudson/slaves/NodeProvisioner.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_2.0 #5 [FIXED JENKINS-31219] A CloudProvisioningListener can prevent (Revision cc932c49afa8c2946a32555285e1aa52dc724ddf) Result = SUCCESS stephen connolly : cc932c49afa8c2946a32555285e1aa52dc724ddf Files : core/src/main/java/hudson/slaves/NodeProvisioner.java
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/hudson/slaves/NodeProvisioner.java
          http://jenkins-ci.org/commit/jenkins/de9835a6797bc7afef9b1605fa21ae0dcf3c6d37
          Log:
          [FIXED JENKINS-31219] A CloudProvisioningListener can prevent provisioning of all clouds instead of just the targeted cloud

          (cherry picked from commit cc932c49afa8c2946a32555285e1aa52dc724ddf)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/slaves/NodeProvisioner.java http://jenkins-ci.org/commit/jenkins/de9835a6797bc7afef9b1605fa21ae0dcf3c6d37 Log: [FIXED JENKINS-31219] A CloudProvisioningListener can prevent provisioning of all clouds instead of just the targeted cloud (cherry picked from commit cc932c49afa8c2946a32555285e1aa52dc724ddf)
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #4450
          [FIXED JENKINS-31219] A CloudProvisioningListener can prevent (Revision de9835a6797bc7afef9b1605fa21ae0dcf3c6d37)

          Result = SUCCESS
          ogondza : de9835a6797bc7afef9b1605fa21ae0dcf3c6d37
          Files :

          • core/src/main/java/hudson/slaves/NodeProvisioner.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4450 [FIXED JENKINS-31219] A CloudProvisioningListener can prevent (Revision de9835a6797bc7afef9b1605fa21ae0dcf3c6d37) Result = SUCCESS ogondza : de9835a6797bc7afef9b1605fa21ae0dcf3c6d37 Files : core/src/main/java/hudson/slaves/NodeProvisioner.java

            People

            • Assignee:
              stephenconnolly Stephen Connolly
              Reporter:
              stephenconnolly Stephen Connolly
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: