Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31661

Jenkins.rootUrl too often unset or incorrect

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Jenkins URL field is showing a value even not being set (it is actually unset in config.xml). This behaviour is confusing for users (it seems to be set, but it's not).

      One things to improve it:

      1. Don't set the value in the field, but suggest it (form validation)
      2. Add an administrative monitor pointing to it

        Attachments

          Issue Links

            Activity

            Hide
            wfollonier Wadeck Follonier added a comment -

            Omar Kohl you're totally right, it was not the expected behavior concerning the TLD, I explicitely added the "_" case for internal hostname but not thought about the custom TLDs.

            Show
            wfollonier Wadeck Follonier added a comment - Omar Kohl you're totally right, it was not the expected behavior concerning the TLD, I explicitely added the "_" case for internal hostname but not thought about the custom TLDs.
            Hide
            wfollonier Wadeck Follonier added a comment - - edited

            Paul Milliken Omar Kohl FYI I created a PR#3415 to address your concern. Feel free to test / review it.

            Also filed a separate issue : JENKINS-51064

            And a PR#3416 for adding the direct "Dismiss" button in this monitor message.

            Show
            wfollonier Wadeck Follonier added a comment - - edited Paul Milliken Omar Kohl FYI I created a PR#3415 to address your concern. Feel free to test / review it. Also filed a separate issue : JENKINS-51064 And a PR#3416 for adding the direct "Dismiss" button in this monitor message.
            Hide
            danielbeck Daniel Beck added a comment -

            Wadeck Follonier I wonder whether you could just consider rootUrlFromRequest for the admin monitor – if that's the same as is configured, it can't be too wrong. WDYT?

            Show
            danielbeck Daniel Beck added a comment - Wadeck Follonier I wonder whether you could just consider rootUrlFromRequest for the admin monitor – if that's the same as is configured, it can't be too wrong. WDYT?
            Hide
            pmilliken Paul Milliken added a comment - - edited

            Wadeck Follonier That sounds promising. I'm not set up to be able to test it readily at the moment unfortunately. My Jenkins URL is http://jenkins.XXXX.private/ - hopefully the relaxation of the TLD validation will permit that (from a quick read of the code, I think it will). For the time being, I've disabled the admin monitor on my installation.

            Thanks for the quick response.

            Show
            pmilliken Paul Milliken added a comment - - edited Wadeck Follonier That sounds promising. I'm not set up to be able to test it readily at the moment unfortunately. My Jenkins URL is http://jenkins.XXXX.private/  - hopefully the relaxation of the TLD validation will permit that (from a quick read of the code, I think it will). For the time being, I've disabled the admin monitor on my installation. Thanks for the quick response.
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Hit it on my instance as well. Will link the ticket to JENKINS-51064 properly

            Show
            oleg_nenashev Oleg Nenashev added a comment - Hit it on my instance as well. Will link the ticket to JENKINS-51064 properly

              People

              • Assignee:
                wfollonier Wadeck Follonier
                Reporter:
                amuniz Antonio Muñiz
              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: