Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32273

Refactor and unify issue handling in CLI commands

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: cli, core
    • Labels:
      None
    • Similar Issues:

      Description

      TL;DR;
      The aim of this JIRA is to start unification of an issue handling in CLI commands.

      Details:
      Currently there is a discrepancy between returned error codes if an issue occurred during execution. It depends on the fact whether the CLI command is implemented as @CLIMethod or extending hudson.cli.CLICommand class.

      @CLIMethod usually returns 1 in the case an issue occurred, similar situation in hudson.cli.CLICommand returns -1 to the shell.

      There is an ongoing effort to extract all CLI commands from the Core to CLI (see JENKINS-22969), so the discrepancy should be removed shortly and consistent error code definition should be set-up on one place only - in hudson.cli.CLICommand.

      Currently we should use this semantic in CLI:

      • 0 means All right
      • -1 means An error occurred

      Technically anything else than zero means an issue occurred. Later we can use more precisely defined error codes for the different issues if useful.

      Update 07-Jan-2016 (WIP):

      TODO

      • Refactor core commands to use correct exception classes
      • Update javadoc for CLICommand#run
      • Unify the handling in CLIRegisterer

      Proposed a new unified scheme of exception raising, handling, reporting and error code returning:
      Update 12-Feb-2016: - Exception -> Throwable

      Exception name Meaning Correct usage Incorrect usage Processing Return code
      CmdLineException Wrong parameter,
      input value can't be decoded etc.
      CommandDuringBuild.java
      • catch in CLICommand
      • print "\nERROR: " + cause message to stderr
      • print usage help
      2
      IllegalStateException Can't continue due to an incorrect
      state of Jenkins instance, job, build etc.
      CommandDuringBuild.java
      comes from Jenkins.getActiveInstance()
      none
      • catch in CLICommand
      • print "\nERROR: " + cause message to stderr
      4
      IllegalArgumentException Can't continue due to
      wrong input parameter (job doesn't exist etc.)
      CopyJobCommand.java
      • catch in CLICommand
      • print "\nERROR: " + cause message to stderr
      3
      AbortException Can't continue due to an other (rare) issue
      Note: Current usage of this exception is wrong,
      usually there should be IllegalState or CmdLine exception
      raised instead of this
      none
      • catch in CLICommand
      • print "\nERROR: " + cause message to stderr
      5
      AccessDeniedException Not sufficent rights for requested action comes from checkPermission() none
      • catch in CLICommand
      • print "\nERROR: " + cause message to stderr
      6
      BadCredentialsException Bad credentials provided via the CLI N/A N/A
      • catch in CLICommand
      • print "\nERROR: " + cause message to stderr with HASH
      • log a cause (HASH included) with INFO level
      7
      Exception
      Throwable
      Any unknown issue occurred, just to report it for the record N/A N/A
      • catch in CLICommand
      • print "\nERROR: " + general message to stderr
      • log general message + exception with WARNING level
      • print stacktrace to stderr for further investigation
      1

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ing. Pavel Janousek
            Path:
            core/src/main/java/hudson/cli/CLICommand.java
            http://jenkins-ci.org/commit/jenkins/49d9f0e1b5872b7eea4d22c8b5edd634cc28e9f6
            Log:
            JENKINS-32273 Refactored return error codes and messages

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ing. Pavel Janousek Path: core/src/main/java/hudson/cli/CLICommand.java http://jenkins-ci.org/commit/jenkins/49d9f0e1b5872b7eea4d22c8b5edd634cc28e9f6 Log: JENKINS-32273 Refactored return error codes and messages
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ing. Pavel Janousek
            Path:
            core/src/main/java/hudson/cli/AddJobToViewCommand.java
            core/src/main/java/hudson/cli/BuildCommand.java
            core/src/main/java/hudson/cli/CLIAction.java
            core/src/main/java/hudson/cli/CLICommand.java
            core/src/main/java/hudson/cli/CliProtocol.java
            core/src/main/java/hudson/cli/CliProtocol2.java
            core/src/main/java/hudson/cli/ClientAuthenticationCache.java
            core/src/main/java/hudson/cli/CommandDuringBuild.java
            core/src/main/java/hudson/cli/ConsoleCommand.java
            core/src/main/java/hudson/cli/CopyJobCommand.java
            core/src/main/java/hudson/cli/CreateJobCommand.java
            core/src/main/java/hudson/cli/CreateNodeCommand.java
            core/src/main/java/hudson/cli/CreateViewCommand.java
            core/src/main/java/hudson/cli/DeleteJobCommand.java
            core/src/main/java/hudson/cli/DeleteNodeCommand.java
            core/src/main/java/hudson/cli/DeleteViewCommand.java
            core/src/main/java/hudson/cli/GroovyCommand.java
            core/src/main/java/hudson/cli/GroovyshCommand.java
            core/src/main/java/hudson/cli/HelpCommand.java
            core/src/main/java/hudson/cli/InstallPluginCommand.java
            core/src/main/java/hudson/cli/InstallToolCommand.java
            core/src/main/java/hudson/cli/ListJobsCommand.java
            core/src/main/java/hudson/cli/ListPluginsCommand.java
            core/src/main/java/hudson/cli/OnlineNodeCommand.java
            core/src/main/java/hudson/cli/ReloadJobCommand.java
            core/src/main/java/hudson/cli/RemoveJobFromViewCommand.java
            core/src/main/java/hudson/cli/SetBuildDisplayNameCommand.java
            core/src/main/java/hudson/cli/declarative/CLIRegisterer.java
            core/src/main/java/hudson/cli/handlers/GenericItemOptionHandler.java
            core/src/main/java/hudson/cli/handlers/NodeOptionHandler.java
            core/src/main/java/hudson/cli/handlers/ViewOptionHandler.java
            core/src/test/java/hudson/cli/ListJobsCommandTest.java
            core/src/test/java/hudson/cli/handlers/ViewOptionHandlerTest.java
            test/src/test/groovy/hudson/cli/BuildCommandTest.groovy
            test/src/test/java/hudson/cli/CLIRegistererTest.java
            test/src/test/java/hudson/cli/CopyJobCommandTest.java
            test/src/test/java/hudson/cli/CreateJobCommandTest.java
            test/src/test/java/hudson/cli/CreateNodeCommandTest.java
            test/src/test/java/hudson/cli/CreateViewCommandTest.java
            test/src/test/java/hudson/cli/DeleteJobCommandTest.java
            test/src/test/java/hudson/cli/DeleteNodeCommandTest.java
            test/src/test/java/hudson/cli/DeleteViewCommandTest.java
            test/src/test/java/hudson/cli/GetNodeCommandTest.java
            test/src/test/java/hudson/cli/GetViewCommandTest.java
            test/src/test/java/hudson/cli/OnlineNodeCommandTest.java
            test/src/test/java/hudson/cli/ReloadJobCommandTest.java
            test/src/test/java/hudson/cli/SetBuildDisplayNameCommandTest.java
            test/src/test/java/hudson/cli/UpdateNodeCommandTest.java
            test/src/test/java/hudson/cli/UpdateViewCommandTest.java
            test/src/test/java/hudson/cli/ViewManipulationTest.java
            test/src/test/java/jenkins/security/Security218CliTest.java
            http://jenkins-ci.org/commit/jenkins/d5725e6d18c0bcd4a2640943eaea059f137786bc
            Log:
            JENKINS-32273 Unified an issue handling in CLI

            Re-factored all existed CLI code to follow the new proposed scheme for
            raising an exception if issue occurs, handling and reporting it.
            Unified CLIRegisterer as well.
            Fixed unit tests to follow the new scheme.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ing. Pavel Janousek Path: core/src/main/java/hudson/cli/AddJobToViewCommand.java core/src/main/java/hudson/cli/BuildCommand.java core/src/main/java/hudson/cli/CLIAction.java core/src/main/java/hudson/cli/CLICommand.java core/src/main/java/hudson/cli/CliProtocol.java core/src/main/java/hudson/cli/CliProtocol2.java core/src/main/java/hudson/cli/ClientAuthenticationCache.java core/src/main/java/hudson/cli/CommandDuringBuild.java core/src/main/java/hudson/cli/ConsoleCommand.java core/src/main/java/hudson/cli/CopyJobCommand.java core/src/main/java/hudson/cli/CreateJobCommand.java core/src/main/java/hudson/cli/CreateNodeCommand.java core/src/main/java/hudson/cli/CreateViewCommand.java core/src/main/java/hudson/cli/DeleteJobCommand.java core/src/main/java/hudson/cli/DeleteNodeCommand.java core/src/main/java/hudson/cli/DeleteViewCommand.java core/src/main/java/hudson/cli/GroovyCommand.java core/src/main/java/hudson/cli/GroovyshCommand.java core/src/main/java/hudson/cli/HelpCommand.java core/src/main/java/hudson/cli/InstallPluginCommand.java core/src/main/java/hudson/cli/InstallToolCommand.java core/src/main/java/hudson/cli/ListJobsCommand.java core/src/main/java/hudson/cli/ListPluginsCommand.java core/src/main/java/hudson/cli/OnlineNodeCommand.java core/src/main/java/hudson/cli/ReloadJobCommand.java core/src/main/java/hudson/cli/RemoveJobFromViewCommand.java core/src/main/java/hudson/cli/SetBuildDisplayNameCommand.java core/src/main/java/hudson/cli/declarative/CLIRegisterer.java core/src/main/java/hudson/cli/handlers/GenericItemOptionHandler.java core/src/main/java/hudson/cli/handlers/NodeOptionHandler.java core/src/main/java/hudson/cli/handlers/ViewOptionHandler.java core/src/test/java/hudson/cli/ListJobsCommandTest.java core/src/test/java/hudson/cli/handlers/ViewOptionHandlerTest.java test/src/test/groovy/hudson/cli/BuildCommandTest.groovy test/src/test/java/hudson/cli/CLIRegistererTest.java test/src/test/java/hudson/cli/CopyJobCommandTest.java test/src/test/java/hudson/cli/CreateJobCommandTest.java test/src/test/java/hudson/cli/CreateNodeCommandTest.java test/src/test/java/hudson/cli/CreateViewCommandTest.java test/src/test/java/hudson/cli/DeleteJobCommandTest.java test/src/test/java/hudson/cli/DeleteNodeCommandTest.java test/src/test/java/hudson/cli/DeleteViewCommandTest.java test/src/test/java/hudson/cli/GetNodeCommandTest.java test/src/test/java/hudson/cli/GetViewCommandTest.java test/src/test/java/hudson/cli/OnlineNodeCommandTest.java test/src/test/java/hudson/cli/ReloadJobCommandTest.java test/src/test/java/hudson/cli/SetBuildDisplayNameCommandTest.java test/src/test/java/hudson/cli/UpdateNodeCommandTest.java test/src/test/java/hudson/cli/UpdateViewCommandTest.java test/src/test/java/hudson/cli/ViewManipulationTest.java test/src/test/java/jenkins/security/Security218CliTest.java http://jenkins-ci.org/commit/jenkins/d5725e6d18c0bcd4a2640943eaea059f137786bc Log: JENKINS-32273 Unified an issue handling in CLI Re-factored all existed CLI code to follow the new proposed scheme for raising an exception if issue occurs, handling and reporting it. Unified CLIRegisterer as well. Fixed unit tests to follow the new scheme.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            core/src/main/java/hudson/cli/AddJobToViewCommand.java
            core/src/main/java/hudson/cli/BuildCommand.java
            core/src/main/java/hudson/cli/CLIAction.java
            core/src/main/java/hudson/cli/CLICommand.java
            core/src/main/java/hudson/cli/CliProtocol.java
            core/src/main/java/hudson/cli/CliProtocol2.java
            core/src/main/java/hudson/cli/ClientAuthenticationCache.java
            core/src/main/java/hudson/cli/CommandDuringBuild.java
            core/src/main/java/hudson/cli/ConsoleCommand.java
            core/src/main/java/hudson/cli/CopyJobCommand.java
            core/src/main/java/hudson/cli/CreateJobCommand.java
            core/src/main/java/hudson/cli/CreateNodeCommand.java
            core/src/main/java/hudson/cli/CreateViewCommand.java
            core/src/main/java/hudson/cli/DeleteJobCommand.java
            core/src/main/java/hudson/cli/DeleteNodeCommand.java
            core/src/main/java/hudson/cli/DeleteViewCommand.java
            core/src/main/java/hudson/cli/GroovyCommand.java
            core/src/main/java/hudson/cli/GroovyshCommand.java
            core/src/main/java/hudson/cli/HelpCommand.java
            core/src/main/java/hudson/cli/InstallPluginCommand.java
            core/src/main/java/hudson/cli/InstallToolCommand.java
            core/src/main/java/hudson/cli/ListJobsCommand.java
            core/src/main/java/hudson/cli/ListPluginsCommand.java
            core/src/main/java/hudson/cli/OnlineNodeCommand.java
            core/src/main/java/hudson/cli/ReloadJobCommand.java
            core/src/main/java/hudson/cli/RemoveJobFromViewCommand.java
            core/src/main/java/hudson/cli/SetBuildDisplayNameCommand.java
            core/src/main/java/hudson/cli/declarative/CLIRegisterer.java
            core/src/main/java/hudson/cli/handlers/GenericItemOptionHandler.java
            core/src/main/java/hudson/cli/handlers/NodeOptionHandler.java
            core/src/main/java/hudson/cli/handlers/ViewOptionHandler.java
            core/src/test/java/hudson/cli/ListJobsCommandTest.java
            core/src/test/java/hudson/cli/handlers/ViewOptionHandlerTest.java
            test/src/test/groovy/hudson/cli/BuildCommandTest.groovy
            test/src/test/java/hudson/cli/CLIRegistererTest.java
            test/src/test/java/hudson/cli/CopyJobCommandTest.java
            test/src/test/java/hudson/cli/CreateJobCommandTest.java
            test/src/test/java/hudson/cli/CreateNodeCommandTest.java
            test/src/test/java/hudson/cli/CreateViewCommandTest.java
            test/src/test/java/hudson/cli/DeleteJobCommandTest.java
            test/src/test/java/hudson/cli/DeleteNodeCommandTest.java
            test/src/test/java/hudson/cli/DeleteViewCommandTest.java
            test/src/test/java/hudson/cli/GetNodeCommandTest.java
            test/src/test/java/hudson/cli/GetViewCommandTest.java
            test/src/test/java/hudson/cli/OnlineNodeCommandTest.java
            test/src/test/java/hudson/cli/ReloadJobCommandTest.java
            test/src/test/java/hudson/cli/SetBuildDisplayNameCommandTest.java
            test/src/test/java/hudson/cli/UpdateNodeCommandTest.java
            test/src/test/java/hudson/cli/UpdateViewCommandTest.java
            test/src/test/java/hudson/cli/ViewManipulationTest.java
            test/src/test/java/jenkins/security/Security218CliTest.java
            http://jenkins-ci.org/commit/jenkins/fe41dc89ab9801c9d57713f84e650788e172e115
            Log:
            Merge pull request #1997 from pjanouse/JENKINS-32273

            JENKINS-32273 Unified an issue handling in CLI

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/cli/AddJobToViewCommand.java core/src/main/java/hudson/cli/BuildCommand.java core/src/main/java/hudson/cli/CLIAction.java core/src/main/java/hudson/cli/CLICommand.java core/src/main/java/hudson/cli/CliProtocol.java core/src/main/java/hudson/cli/CliProtocol2.java core/src/main/java/hudson/cli/ClientAuthenticationCache.java core/src/main/java/hudson/cli/CommandDuringBuild.java core/src/main/java/hudson/cli/ConsoleCommand.java core/src/main/java/hudson/cli/CopyJobCommand.java core/src/main/java/hudson/cli/CreateJobCommand.java core/src/main/java/hudson/cli/CreateNodeCommand.java core/src/main/java/hudson/cli/CreateViewCommand.java core/src/main/java/hudson/cli/DeleteJobCommand.java core/src/main/java/hudson/cli/DeleteNodeCommand.java core/src/main/java/hudson/cli/DeleteViewCommand.java core/src/main/java/hudson/cli/GroovyCommand.java core/src/main/java/hudson/cli/GroovyshCommand.java core/src/main/java/hudson/cli/HelpCommand.java core/src/main/java/hudson/cli/InstallPluginCommand.java core/src/main/java/hudson/cli/InstallToolCommand.java core/src/main/java/hudson/cli/ListJobsCommand.java core/src/main/java/hudson/cli/ListPluginsCommand.java core/src/main/java/hudson/cli/OnlineNodeCommand.java core/src/main/java/hudson/cli/ReloadJobCommand.java core/src/main/java/hudson/cli/RemoveJobFromViewCommand.java core/src/main/java/hudson/cli/SetBuildDisplayNameCommand.java core/src/main/java/hudson/cli/declarative/CLIRegisterer.java core/src/main/java/hudson/cli/handlers/GenericItemOptionHandler.java core/src/main/java/hudson/cli/handlers/NodeOptionHandler.java core/src/main/java/hudson/cli/handlers/ViewOptionHandler.java core/src/test/java/hudson/cli/ListJobsCommandTest.java core/src/test/java/hudson/cli/handlers/ViewOptionHandlerTest.java test/src/test/groovy/hudson/cli/BuildCommandTest.groovy test/src/test/java/hudson/cli/CLIRegistererTest.java test/src/test/java/hudson/cli/CopyJobCommandTest.java test/src/test/java/hudson/cli/CreateJobCommandTest.java test/src/test/java/hudson/cli/CreateNodeCommandTest.java test/src/test/java/hudson/cli/CreateViewCommandTest.java test/src/test/java/hudson/cli/DeleteJobCommandTest.java test/src/test/java/hudson/cli/DeleteNodeCommandTest.java test/src/test/java/hudson/cli/DeleteViewCommandTest.java test/src/test/java/hudson/cli/GetNodeCommandTest.java test/src/test/java/hudson/cli/GetViewCommandTest.java test/src/test/java/hudson/cli/OnlineNodeCommandTest.java test/src/test/java/hudson/cli/ReloadJobCommandTest.java test/src/test/java/hudson/cli/SetBuildDisplayNameCommandTest.java test/src/test/java/hudson/cli/UpdateNodeCommandTest.java test/src/test/java/hudson/cli/UpdateViewCommandTest.java test/src/test/java/hudson/cli/ViewManipulationTest.java test/src/test/java/jenkins/security/Security218CliTest.java http://jenkins-ci.org/commit/jenkins/fe41dc89ab9801c9d57713f84e650788e172e115 Log: Merge pull request #1997 from pjanouse/ JENKINS-32273 JENKINS-32273 Unified an issue handling in CLI
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4458
            JENKINS-32273 Refactored return error codes and messages (Revision 49d9f0e1b5872b7eea4d22c8b5edd634cc28e9f6)
            JENKINS-32273 Unified an issue handling in CLI (Revision d5725e6d18c0bcd4a2640943eaea059f137786bc)

            Result = SUCCESS
            pjanouse : 49d9f0e1b5872b7eea4d22c8b5edd634cc28e9f6
            Files :

            • core/src/main/java/hudson/cli/CLICommand.java

            pjanouse : d5725e6d18c0bcd4a2640943eaea059f137786bc
            Files :

            • test/src/test/java/hudson/cli/SetBuildDisplayNameCommandTest.java
            • core/src/main/java/hudson/cli/DeleteNodeCommand.java
            • core/src/main/java/hudson/cli/handlers/GenericItemOptionHandler.java
            • test/src/test/java/hudson/cli/UpdateViewCommandTest.java
            • core/src/test/java/hudson/cli/ListJobsCommandTest.java
            • core/src/main/java/hudson/cli/GroovyCommand.java
            • core/src/main/java/hudson/cli/handlers/ViewOptionHandler.java
            • test/src/test/java/hudson/cli/GetViewCommandTest.java
            • test/src/test/java/hudson/cli/CopyJobCommandTest.java
            • core/src/test/java/hudson/cli/handlers/ViewOptionHandlerTest.java
            • core/src/main/java/hudson/cli/InstallPluginCommand.java
            • core/src/main/java/hudson/cli/CommandDuringBuild.java
            • test/src/test/groovy/hudson/cli/BuildCommandTest.groovy
            • test/src/test/java/hudson/cli/ViewManipulationTest.java
            • test/src/test/java/hudson/cli/DeleteNodeCommandTest.java
            • test/src/test/java/hudson/cli/CreateNodeCommandTest.java
            • test/src/test/java/hudson/cli/GetNodeCommandTest.java
            • core/src/main/java/hudson/cli/RemoveJobFromViewCommand.java
            • core/src/main/java/hudson/cli/ListJobsCommand.java
            • core/src/main/java/hudson/cli/InstallToolCommand.java
            • core/src/main/java/hudson/cli/BuildCommand.java
            • test/src/test/java/hudson/cli/CreateViewCommandTest.java
            • core/src/main/java/hudson/cli/ConsoleCommand.java
            • test/src/test/java/hudson/cli/CreateJobCommandTest.java
            • core/src/main/java/hudson/cli/ClientAuthenticationCache.java
            • core/src/main/java/hudson/cli/SetBuildDisplayNameCommand.java
            • core/src/main/java/hudson/cli/GroovyshCommand.java
            • core/src/main/java/hudson/cli/CreateJobCommand.java
            • core/src/main/java/hudson/cli/DeleteViewCommand.java
            • test/src/test/java/hudson/cli/UpdateNodeCommandTest.java
            • core/src/main/java/hudson/cli/CliProtocol.java
            • core/src/main/java/hudson/cli/CLICommand.java
            • test/src/test/java/jenkins/security/Security218CliTest.java
            • core/src/main/java/hudson/cli/ListPluginsCommand.java
            • core/src/main/java/hudson/cli/CLIAction.java
            • core/src/main/java/hudson/cli/declarative/CLIRegisterer.java
            • core/src/main/java/hudson/cli/ReloadJobCommand.java
            • core/src/main/java/hudson/cli/HelpCommand.java
            • test/src/test/java/hudson/cli/CLIRegistererTest.java
            • test/src/test/java/hudson/cli/OnlineNodeCommandTest.java
            • core/src/main/java/hudson/cli/OnlineNodeCommand.java
            • core/src/main/java/hudson/cli/AddJobToViewCommand.java
            • core/src/main/java/hudson/cli/CliProtocol2.java
            • core/src/main/java/hudson/cli/CreateNodeCommand.java
            • test/src/test/java/hudson/cli/DeleteJobCommandTest.java
            • core/src/main/java/hudson/cli/CreateViewCommand.java
            • test/src/test/java/hudson/cli/DeleteViewCommandTest.java
            • core/src/main/java/hudson/cli/DeleteJobCommand.java
            • core/src/main/java/hudson/cli/handlers/NodeOptionHandler.java
            • test/src/test/java/hudson/cli/ReloadJobCommandTest.java
            • core/src/main/java/hudson/cli/CopyJobCommand.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4458 JENKINS-32273 Refactored return error codes and messages (Revision 49d9f0e1b5872b7eea4d22c8b5edd634cc28e9f6) JENKINS-32273 Unified an issue handling in CLI (Revision d5725e6d18c0bcd4a2640943eaea059f137786bc) Result = SUCCESS pjanouse : 49d9f0e1b5872b7eea4d22c8b5edd634cc28e9f6 Files : core/src/main/java/hudson/cli/CLICommand.java pjanouse : d5725e6d18c0bcd4a2640943eaea059f137786bc Files : test/src/test/java/hudson/cli/SetBuildDisplayNameCommandTest.java core/src/main/java/hudson/cli/DeleteNodeCommand.java core/src/main/java/hudson/cli/handlers/GenericItemOptionHandler.java test/src/test/java/hudson/cli/UpdateViewCommandTest.java core/src/test/java/hudson/cli/ListJobsCommandTest.java core/src/main/java/hudson/cli/GroovyCommand.java core/src/main/java/hudson/cli/handlers/ViewOptionHandler.java test/src/test/java/hudson/cli/GetViewCommandTest.java test/src/test/java/hudson/cli/CopyJobCommandTest.java core/src/test/java/hudson/cli/handlers/ViewOptionHandlerTest.java core/src/main/java/hudson/cli/InstallPluginCommand.java core/src/main/java/hudson/cli/CommandDuringBuild.java test/src/test/groovy/hudson/cli/BuildCommandTest.groovy test/src/test/java/hudson/cli/ViewManipulationTest.java test/src/test/java/hudson/cli/DeleteNodeCommandTest.java test/src/test/java/hudson/cli/CreateNodeCommandTest.java test/src/test/java/hudson/cli/GetNodeCommandTest.java core/src/main/java/hudson/cli/RemoveJobFromViewCommand.java core/src/main/java/hudson/cli/ListJobsCommand.java core/src/main/java/hudson/cli/InstallToolCommand.java core/src/main/java/hudson/cli/BuildCommand.java test/src/test/java/hudson/cli/CreateViewCommandTest.java core/src/main/java/hudson/cli/ConsoleCommand.java test/src/test/java/hudson/cli/CreateJobCommandTest.java core/src/main/java/hudson/cli/ClientAuthenticationCache.java core/src/main/java/hudson/cli/SetBuildDisplayNameCommand.java core/src/main/java/hudson/cli/GroovyshCommand.java core/src/main/java/hudson/cli/CreateJobCommand.java core/src/main/java/hudson/cli/DeleteViewCommand.java test/src/test/java/hudson/cli/UpdateNodeCommandTest.java core/src/main/java/hudson/cli/CliProtocol.java core/src/main/java/hudson/cli/CLICommand.java test/src/test/java/jenkins/security/Security218CliTest.java core/src/main/java/hudson/cli/ListPluginsCommand.java core/src/main/java/hudson/cli/CLIAction.java core/src/main/java/hudson/cli/declarative/CLIRegisterer.java core/src/main/java/hudson/cli/ReloadJobCommand.java core/src/main/java/hudson/cli/HelpCommand.java test/src/test/java/hudson/cli/CLIRegistererTest.java test/src/test/java/hudson/cli/OnlineNodeCommandTest.java core/src/main/java/hudson/cli/OnlineNodeCommand.java core/src/main/java/hudson/cli/AddJobToViewCommand.java core/src/main/java/hudson/cli/CliProtocol2.java core/src/main/java/hudson/cli/CreateNodeCommand.java test/src/test/java/hudson/cli/DeleteJobCommandTest.java core/src/main/java/hudson/cli/CreateViewCommand.java test/src/test/java/hudson/cli/DeleteViewCommandTest.java core/src/main/java/hudson/cli/DeleteJobCommand.java core/src/main/java/hudson/cli/handlers/NodeOptionHandler.java test/src/test/java/hudson/cli/ReloadJobCommandTest.java core/src/main/java/hudson/cli/CopyJobCommand.java
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            test/src/test/java/hudson/cli/GetNodeCommandTest.java
            test/src/test/java/hudson/cli/UpdateNodeCommandTest.java
            http://jenkins-ci.org/commit/jenkins/9f3f352ee989c861e5304dc0ac4e7b06f7fd1403
            Log:
            JENKINS-32273 CLI exit codes changed as of #1997 in 1.649.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: test/src/test/java/hudson/cli/GetNodeCommandTest.java test/src/test/java/hudson/cli/UpdateNodeCommandTest.java http://jenkins-ci.org/commit/jenkins/9f3f352ee989c861e5304dc0ac4e7b06f7fd1403 Log: JENKINS-32273 CLI exit codes changed as of #1997 in 1.649.

              People

              • Assignee:
                pajasoft Pavel Janoušek
                Reporter:
                pajasoft Pavel Janoušek
              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: