Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32331

Performance problems on scan on huge Jenkins instances

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: token-macro-plugin
    • Labels:
      None
    • Environment:
      Jenkins 1.584
      Build Failure Analyser 1.12.1
    • Similar Issues:

      Description

      Hi,

      On a Jenkins 1.584, using Build Failure Analyser 1.12.1, we host more than 2600 jobs, and we have 123 different BFA rules.

      Our log files can be fairly big (ranging from 5Mb to 100 Mb in some exceptional cases) and we have started to have serious performance issues, where the BFA scan on a failing build can take up to 15 minutes. This is of course a big issue.

      By looking at the code, I've seen that the scan of a log is performed once per rule being defined, and then line by line. This is of course very costly in our case.

      Do you have any suggestion about this kind of situation?

      Thanks,
      Damien.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Damien Coraboeuf
            Path:
            src/main/java/org/jenkinsci/plugins/tokenmacro/DataBoundTokenMacro.java
            http://jenkins-ci.org/commit/token-macro-plugin/f9054f3f3becc5744e0874a31634282285829e54
            Log:
            JENKINS-32331 Removed bottleneck synchronisation

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Damien Coraboeuf Path: src/main/java/org/jenkinsci/plugins/tokenmacro/DataBoundTokenMacro.java http://jenkins-ci.org/commit/token-macro-plugin/f9054f3f3becc5744e0874a31634282285829e54 Log: JENKINS-32331 Removed bottleneck synchronisation
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Damien Coraboeuf
            Path:
            src/main/java/org/jenkinsci/plugins/tokenmacro/DataBoundTokenMacro.java
            http://jenkins-ci.org/commit/token-macro-plugin/803399668417c58a14052b74fae9f21cb4f03601
            Log:
            JENKINS-32331 Using a concurrent map for the setters

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Damien Coraboeuf Path: src/main/java/org/jenkinsci/plugins/tokenmacro/DataBoundTokenMacro.java http://jenkins-ci.org/commit/token-macro-plugin/803399668417c58a14052b74fae9f21cb4f03601 Log: JENKINS-32331 Using a concurrent map for the setters
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Alex Earl
            Path:
            src/main/java/org/jenkinsci/plugins/tokenmacro/DataBoundTokenMacro.java
            http://jenkins-ci.org/commit/token-macro-plugin/68e4779779c09e7a12ba64c7c184cdc38166db7a
            Log:
            Merge pull request #21 from dcoraboeuf/jenkins-32331-bottleneck

            JENKINS-32331 Removed bottleneck synchronisation

            Compare: https://github.com/jenkinsci/token-macro-plugin/compare/c28636e1aa69...68e4779779c0

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/org/jenkinsci/plugins/tokenmacro/DataBoundTokenMacro.java http://jenkins-ci.org/commit/token-macro-plugin/68e4779779c09e7a12ba64c7c184cdc38166db7a Log: Merge pull request #21 from dcoraboeuf/jenkins-32331-bottleneck JENKINS-32331 Removed bottleneck synchronisation Compare: https://github.com/jenkinsci/token-macro-plugin/compare/c28636e1aa69...68e4779779c0
            Hide
            slide_o_mix Alex Earl added a comment -

            Will be fixed in 2.0

            Show
            slide_o_mix Alex Earl added a comment - Will be fixed in 2.0
            Hide
            jimilian Alexander A added a comment -
            Show
            jimilian Alexander A added a comment - Damien Coraboeuf , Tomas Westling , can you check my PR: https://github.com/jenkinsci/build-failure-analyzer-plugin/pull/57 ? Or at least join to discussion

              People

              • Assignee:
                slide_o_mix Alex Earl
                Reporter:
                damien_coraboeuf Damien Coraboeuf
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: