Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32481

git plugin does not retry when submodule update fails

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: git-plugin
    • Labels:
      None
    • Environment:
      Jenkins 1.643
      Git Plugin 2.5.0-beta3
    • Similar Issues:

      Description

      I have a proposed pull request to resolve this issue.

      The Git Plugin does not issue an IOException when git-submodule fails due to network failure or similar which would issue a retry when the normal git checkout fails. Instead it issues a GitException which causes the plugin to fail instead of retry like it is supposed to when RetryCount is set to something other than 0.

        Attachments

          Activity

          Hide
          jekeller Jacob Keller added a comment -
          Show
          jekeller Jacob Keller added a comment - This is fixed by https://github.com/jenkinsci/git-plugin/pull/374
          Hide
          scottj97 Scott Johnson added a comment -

          This seems to still be broken in git-plugin 2.5.0 (the latest release). The pull request linked in the previous comment is still open. This bug, combined with github flakiness today, is killing all my builds.

          Show
          scottj97 Scott Johnson added a comment - This seems to still be broken in git-plugin 2.5.0 (the latest release). The pull request linked in the previous comment is still open. This bug, combined with github flakiness today, is killing all my builds.
          Hide
          jekeller Jacob Keller added a comment -

          Yea this didn't get pulled into 2.5 I believe.

          Show
          jekeller Jacob Keller added a comment - Yea this didn't get pulled into 2.5 I believe.
          Hide
          markewaite Mark Waite added a comment -

          Will be fixed in git plugin 3.7.0

          Show
          markewaite Mark Waite added a comment - Will be fixed in git plugin 3.7.0
          Hide
          markewaite Mark Waite added a comment -

          Fixed in git plugin 3.7.0, released 21 Dec 2017.

          Show
          markewaite Mark Waite added a comment - Fixed in git plugin 3.7.0, released 21 Dec 2017.

            People

            • Assignee:
              Unassigned
              Reporter:
              jekeller Jacob Keller
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: