Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32695

Result from health checks are lost when more than 3 run at the same time

    Details

    • Similar Issues:

      Description

      Based on
      https://github.com/jenkinsci/metrics-plugin/blob/master/src/main/java/jenkins/metrics/api/Metrics.java#L118
      the checks are put in a thread pool size 4, with no queue, with the HealthChecker itself taking one spot. If more than 3 checks are put in the pool before one finishes a RejectedExecutionException is thrown, never logged anywhere, and nothing is returned from registry.runHealthChecks

        Attachments

          Activity

          Show
          csanchez Carlos Sanchez added a comment - https://github.com/jenkinsci/metrics-plugin/pull/18
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Carlos Sanchez
          Path:
          src/main/java/jenkins/metrics/api/Metrics.java
          src/main/java/jenkins/metrics/util/HealthChecksThreadPool.java
          src/test/java/jenkins/metrics/api/HealthCheckProviderForTesting.java
          src/test/java/jenkins/metrics/api/HealthCheckerTest.java
          http://jenkins-ci.org/commit/metrics-plugin/95538204c4cd17ff074ff51ad434321e61a6bf05
          Log:
          JENKINS-32695 Result from health checks are lost when more than 3 run at the same time

          If more than 3 checks are put in the pool before one finishes a RejectedExecutionException is thrown,
          never logged anywhere, and nothing is returned from registry.runHealthChecks

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Carlos Sanchez Path: src/main/java/jenkins/metrics/api/Metrics.java src/main/java/jenkins/metrics/util/HealthChecksThreadPool.java src/test/java/jenkins/metrics/api/HealthCheckProviderForTesting.java src/test/java/jenkins/metrics/api/HealthCheckerTest.java http://jenkins-ci.org/commit/metrics-plugin/95538204c4cd17ff074ff51ad434321e61a6bf05 Log: JENKINS-32695 Result from health checks are lost when more than 3 run at the same time If more than 3 checks are put in the pool before one finishes a RejectedExecutionException is thrown, never logged anywhere, and nothing is returned from registry.runHealthChecks
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/metrics/api/Metrics.java
          src/main/java/jenkins/metrics/util/HealthChecksThreadPool.java
          src/test/java/jenkins/metrics/api/HealthCheckProviderForTesting.java
          src/test/java/jenkins/metrics/api/HealthCheckerTest.java
          http://jenkins-ci.org/commit/metrics-plugin/ef2d2f9df376569d4fbb4ffd50fd354635eba918
          Log:
          Merge pull request #18 from carlossg/thread-pool

          JENKINS-32695 Result from health checks are lost when more than 3 run at the same time

          Compare: https://github.com/jenkinsci/metrics-plugin/compare/1de26f6740fd...ef2d2f9df376

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/metrics/api/Metrics.java src/main/java/jenkins/metrics/util/HealthChecksThreadPool.java src/test/java/jenkins/metrics/api/HealthCheckProviderForTesting.java src/test/java/jenkins/metrics/api/HealthCheckerTest.java http://jenkins-ci.org/commit/metrics-plugin/ef2d2f9df376569d4fbb4ffd50fd354635eba918 Log: Merge pull request #18 from carlossg/thread-pool JENKINS-32695 Result from health checks are lost when more than 3 run at the same time Compare: https://github.com/jenkinsci/metrics-plugin/compare/1de26f6740fd...ef2d2f9df376
          Hide
          csanchez Carlos Sanchez added a comment -

          PR merged

          Show
          csanchez Carlos Sanchez added a comment - PR merged

            People

            • Assignee:
              csanchez Carlos Sanchez
              Reporter:
              csanchez Carlos Sanchez
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: