Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32821

Regexp doesn't work for matrix-children if without rerunMatrixPart

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: naginator-plugin
    • Labels:
      None
    • Environment:
      naginator-plugin 1.16.1
    • Similar Issues:

      Description

      • "Regular expression to search for" is checked.
      • "Test regular expression for the matrix parent" is unchecked.
      • "Rerun build only for failed parts on the matrix" is unchecked.

      In this case, regexp is not tested at all.
      I think this is not functional issue, but this should be warned to users.

        Attachments

          Activity

          Hide
          ikedam ikedam added a comment -

          When rerunMatrixPart=false and regexpForMatrixParent=true, whole matrix should be triggered only when a log of its child matches the regexp, shouldn't it?

          Show
          ikedam ikedam added a comment - When rerunMatrixPart=false and regexpForMatrixParent=true, whole matrix should be triggered only when a log of its child matches the regexp, shouldn't it?
          Show
          ikedam ikedam added a comment - https://github.com/jenkinsci/naginator-plugin/pull/30
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisher.java
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherScheduleAction.java
          src/main/java/com/chikli/hudson/plugin/naginator/RegexpForMatrixStrategy.java
          src/main/resources/com/chikli/hudson/plugin/naginator/Messages.properties
          src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/config.jelly
          src/test/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherTest.java
          src/test/java/com/chikli/hudson/plugin/naginator/testutils/MyBuilder.java
          http://jenkins-ci.org/commit/naginator-plugin/7b9f2f2a55f5f8b7ec286a73c55ec78d8270eb8f
          Log:
          [FIXED JENKINS-32821] Introduced a new option "How to apply the regular expression to matrix" which replaces "Test regular expression for the matrix parent"

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisher.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherScheduleAction.java src/main/java/com/chikli/hudson/plugin/naginator/RegexpForMatrixStrategy.java src/main/resources/com/chikli/hudson/plugin/naginator/Messages.properties src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/config.jelly src/test/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherTest.java src/test/java/com/chikli/hudson/plugin/naginator/testutils/MyBuilder.java http://jenkins-ci.org/commit/naginator-plugin/7b9f2f2a55f5f8b7ec286a73c55ec78d8270eb8f Log: [FIXED JENKINS-32821] Introduced a new option "How to apply the regular expression to matrix" which replaces "Test regular expression for the matrix parent"
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorListener.java
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisher.java
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherScheduleAction.java
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorScheduleAction.java
          src/main/java/com/chikli/hudson/plugin/naginator/NoChildStrategy.java
          src/main/java/com/chikli/hudson/plugin/naginator/RegexpForMatrixStrategy.java
          src/main/resources/com/chikli/hudson/plugin/naginator/Messages.properties
          src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/config.jelly
          src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/help-noChildStrategy.html
          src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/help-rerunMatrixPart.html
          src/test/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherTest.java
          src/test/java/com/chikli/hudson/plugin/naginator/NaginatorScheduleActionTest.java
          src/test/java/com/chikli/hudson/plugin/naginator/testutils/MyBuilder.java
          http://jenkins-ci.org/commit/naginator-plugin/76c78c117b80c9a0ca803df49590a75f1dabf327
          Log:
          Merge pull request #29 from ikedam/feature/JENKINS-32823_NoTriggerForNoChild

          JENKINS-32823 [FIXED JENKINS-32821] Added "When no combinations to rerun" and "How to apply the regular expression to matrix"

          Compare: https://github.com/jenkinsci/naginator-plugin/compare/0f1e8f252788...76c78c117b80

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/com/chikli/hudson/plugin/naginator/NaginatorListener.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisher.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherScheduleAction.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorScheduleAction.java src/main/java/com/chikli/hudson/plugin/naginator/NoChildStrategy.java src/main/java/com/chikli/hudson/plugin/naginator/RegexpForMatrixStrategy.java src/main/resources/com/chikli/hudson/plugin/naginator/Messages.properties src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/config.jelly src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/help-noChildStrategy.html src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/help-rerunMatrixPart.html src/test/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherTest.java src/test/java/com/chikli/hudson/plugin/naginator/NaginatorScheduleActionTest.java src/test/java/com/chikli/hudson/plugin/naginator/testutils/MyBuilder.java http://jenkins-ci.org/commit/naginator-plugin/76c78c117b80c9a0ca803df49590a75f1dabf327 Log: Merge pull request #29 from ikedam/feature/ JENKINS-32823 _NoTriggerForNoChild JENKINS-32823 [FIXED JENKINS-32821] Added "When no combinations to rerun" and "How to apply the regular expression to matrix" Compare: https://github.com/jenkinsci/naginator-plugin/compare/0f1e8f252788...76c78c117b80
          Hide
          ikedam ikedam added a comment -

          Fixed in naginator-1.17.

          Show
          ikedam ikedam added a comment - Fixed in naginator-1.17.

            People

            • Assignee:
              ikedam ikedam
              Reporter:
              ikedam ikedam
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: