Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32987

Support configurable ID for developer profile

    Details

    • Similar Issues:

      Description

      I have raised raised an issue - JENKINS-32969 on job-dsl-plugin v1.43 release about a breaking change in XCode jobs. With the most recent release, the deprecated method JobManagement.getCredentialsId(String credential) has been removed and there is no way of referencing the developer profile. I have submitted a pull request to fix it from job-dsl-plugin. However Daniel Spilker feels that a more appropriate fix is to be able to generate a custom ID as reference. This has been supported by Credentials plugin since JENKINS-26099.

        Attachments

          Issue Links

            Activity

            Hide
            duemir Denys Digtiar added a comment - - edited

            Added a link to pull request which seems to be adding backend changes necessary to implement this feature.

            Show
            duemir Denys Digtiar added a comment - - edited Added a link to pull request which seems to be adding backend changes necessary to implement this feature.
            Hide
            aheritier Arnaud Héritier added a comment -

            I proposed a new PR to improve a bit the previous one Denys Digtiar. If lacostej can review it and is ok, I'll merge/release it

            Show
            aheritier Arnaud Héritier added a comment - I proposed a new PR to improve a bit the previous one Denys Digtiar . If lacostej can review it and is ok, I'll merge/release it
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Arnaud Heritier
            Path:
            pom.xml
            src/main/java/au/com/rayh/DeveloperProfile.java
            http://jenkins-ci.org/commit/xcode-plugin/3cf6865dcc9dad0b010b0bb2b549b2293880c4fe
            Log:
            This PR fixes JENKINS-32987, it completes PR #68 (#70)

            • Update `credentials` to 1.21 to support custom credential ID
            • JENKINS-32987 - id + description shouldn't be redefined and it is better to keep but deprecated the previous constructor
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Arnaud Heritier Path: pom.xml src/main/java/au/com/rayh/DeveloperProfile.java http://jenkins-ci.org/commit/xcode-plugin/3cf6865dcc9dad0b010b0bb2b549b2293880c4fe Log: This PR fixes JENKINS-32987 , it completes PR #68 (#70) Update `credentials` to 1.21 to support custom credential ID JENKINS-32987 - id + description shouldn't be redefined and it is better to keep but deprecated the previous constructor
            Hide
            aheritier Arnaud Héritier added a comment -

            Fixed in 1.4.10

            Show
            aheritier Arnaud Héritier added a comment - Fixed in 1.4.10
            Hide
            daspilker Daniel Spilker added a comment -

            It is still not possible to set the ID in the UI.

            Here is a PR to fix that:
            https://github.com/jenkinsci/xcode-plugin/pull/73

            Show
            daspilker Daniel Spilker added a comment - It is still not possible to set the ID in the UI. Here is a PR to fix that: https://github.com/jenkinsci/xcode-plugin/pull/73
            Hide
            aheritier Arnaud Héritier added a comment -

            RHAAA Daniel Spilker
            Don't you want the commit rights here ?
            I will merge and release a 1.4.11
            cc Brantone

            Show
            aheritier Arnaud Héritier added a comment - RHAAA Daniel Spilker Don't you want the commit rights here ? I will merge and release a 1.4.11 cc Brantone
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Spilker
            Path:
            src/main/resources/au/com/rayh/DeveloperProfile/config.groovy
            http://jenkins-ci.org/commit/xcode-plugin/1c5149cc7158d7235ad72d442434535eb14db0ba
            Log:
            allow to set the credentials ID in the UI (#73)

            JENKINS-32987

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: src/main/resources/au/com/rayh/DeveloperProfile/config.groovy http://jenkins-ci.org/commit/xcode-plugin/1c5149cc7158d7235ad72d442434535eb14db0ba Log: allow to set the credentials ID in the UI (#73) JENKINS-32987
            Hide
            aheritier Arnaud Héritier added a comment -

            Fixed in 1.4.11

            Show
            aheritier Arnaud Héritier added a comment - Fixed in 1.4.11

              People

              • Assignee:
                Unassigned
                Reporter:
                patcadelina Patrick Cadelina
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: