Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34019

ANSIColor plugin leaks format onto next line's timestamp

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      When used with timestamped console output, the formatting from one line sometimes (but not always) leaks over and colors the timestamp on the next line.

        Attachments

        1. consolelog.png
          consolelog.png
          323 kB
        2. with.png
          with.png
          8 kB
        3. without.png
          without.png
          6 kB

          Issue Links

            Activity

            Hide
            dankirkd Daniel Kirkdorffer added a comment -

            I've created a new bug: JENKINS-38573

            Show
            dankirkd Daniel Kirkdorffer added a comment - I've created a new bug: JENKINS-38573
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Steven Brown
            Path:
            src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory2/style.css
            http://jenkins-ci.org/commit/timestamper-plugin/6b763a9b72afa21d7f3fe3a8e850612029bac335
            Log:
            JENKINS-38390 JENKINS-34019 Revert timestamps style added by c31dc95

            The style matched the default Jenkins theme, but clashed with custom themes.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Steven Brown Path: src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory2/style.css http://jenkins-ci.org/commit/timestamper-plugin/6b763a9b72afa21d7f3fe3a8e850612029bac335 Log: JENKINS-38390 JENKINS-34019 Revert timestamps style added by c31dc95 The style matched the default Jenkins theme, but clashed with custom themes.
            Hide
            stevengbrown Steven G Brown added a comment -

            Changes were reverted for Timestamper 1.8.7. Overriding the style works fine for the default Jenkins theme, but clashes with custom themes.

            This can be fixed instead within the AnsiColor plugin by:

            1. Using a ConsoleAnnotatorFactory instead of inserting console notes into the log file.
            2. When a style continues to the next line, the ConsoleAnnotatorFactory can insert a closing tag at the end of the line and an opening tag at the beginning of the next line. This prevents the timestamps from being affected.
            Show
            stevengbrown Steven G Brown added a comment - Changes were reverted for Timestamper 1.8.7. Overriding the style works fine for the default Jenkins theme, but clashes with custom themes. This can be fixed instead within the AnsiColor plugin by: Using a ConsoleAnnotatorFactory instead of inserting console notes into the log file. When a style continues to the next line, the ConsoleAnnotatorFactory can insert a closing tag at the end of the line and an opening tag at the beginning of the next line. This prevents the timestamps from being affected.
            Hide
            simonwydooghe Simon Wydooghe added a comment -

            Would be nice to see this fixed if possible...

            Show
            simonwydooghe Simon Wydooghe added a comment - Would be nice to see this fixed if possible...
            Hide
            stevengbrown Steven G Brown added a comment -

            I have provided instructions to reproduce and fix. Pull requests welcome.

            Show
            stevengbrown Steven G Brown added a comment - I have provided instructions to reproduce and fix. Pull requests welcome.

              People

              • Assignee:
                Unassigned
                Reporter:
                evildeece Alastair D'Silva
              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated: