Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34467

jenkins-runner.sh doesn’t accept httpsKeyStore or httpsKeyStorePassword options

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: packaging
    • Labels:
    • Environment:
      10.11.4, any recent Jenkins version
    • Similar Issues:

      Description

      At https://wiki.jenkins-ci.org/display/JENKINS/Starting+and+Accessing+Jenkins, the following instructions are given for specifying the keystore and keystore password:

      $ sudo defaults write /Library/Preferences/org.jenkins-ci httpsKeyStore /path/to/your/keystore/file
      $ sudo defaults write /Library/Preferences/org.jenkins-ci httpsKeyStorePassword <keystore password>
      

      However, https://github.com/jenkinsci/packaging/blob/master/osx/Library/Application%20Support/Jenkins/jenkins-runner.sh doesn’t include these options in its list of arguments to process. This means that when launching Jenkins on Mac OS X using the LaunchDaemons infrastructure, these options do not get propagated to Java and are not seen by Jenkins.

      Fixing this is important to get Jenkins working, for example, in corporate networks where alternative keystores for CA certificate chains need to be given.

        Attachments

          Activity

          Hide
          anesbit2 Andrew Nesbit added a comment -

          A pull request has been submitted: https://github.com/jenkinsci/packaging/pull/53 .

          Show
          anesbit2 Andrew Nesbit added a comment - A pull request has been submitted: https://github.com/jenkinsci/packaging/pull/53 .
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Andrew Nesbit
          Path:
          osx/Library/Application Support/Jenkins/jenkins-runner.sh
          http://jenkins-ci.org/commit/packaging/887a11f0817ffe4ca0a3c048790153d42689c354
          Log:
          [FIXED JENKINS-34467] Add support for keystore and password

          When launching Jenkins on Mac OS X using the LaunchDaemons
          infrastructure, the httpsKeyStore and httpsKeyStorePassword options do
          not get propagated to Java, so they are not seen by Jenkins. This
          commit explicitly includes these options in the list of arguments to
          process, ensuring they get passed to Java.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Nesbit Path: osx/Library/Application Support/Jenkins/jenkins-runner.sh http://jenkins-ci.org/commit/packaging/887a11f0817ffe4ca0a3c048790153d42689c354 Log: [FIXED JENKINS-34467] Add support for keystore and password When launching Jenkins on Mac OS X using the LaunchDaemons infrastructure, the httpsKeyStore and httpsKeyStorePassword options do not get propagated to Java, so they are not seen by Jenkins. This commit explicitly includes these options in the list of arguments to process, ensuring they get passed to Java.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          osx/Library/Application Support/Jenkins/jenkins-runner.sh
          http://jenkins-ci.org/commit/packaging/8c1869f7a937e504e8b21a12b2d93b68105fb2ea
          Log:
          Merge pull request #53 from alnesbit/fix_keystore_options

          [FIXED JENKINS-34467] Add support for keystore and password

          Compare: https://github.com/jenkinsci/packaging/compare/8a59aa60d49a...8c1869f7a937

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: osx/Library/Application Support/Jenkins/jenkins-runner.sh http://jenkins-ci.org/commit/packaging/8c1869f7a937e504e8b21a12b2d93b68105fb2ea Log: Merge pull request #53 from alnesbit/fix_keystore_options [FIXED JENKINS-34467] Add support for keystore and password Compare: https://github.com/jenkinsci/packaging/compare/8a59aa60d49a...8c1869f7a937

            People

            • Assignee:
              kohsuke Kohsuke Kawaguchi
              Reporter:
              anesbit2 Andrew Nesbit
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: