Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34516

Remove "FlowDownStreamRunDeclarer"

    Details

    • Similar Issues:

      Description

      Remove FlowDownStreamRunDeclarer from here, we will move this class file to BuildGraph-View plugin.
      The reason behind to remove this from the Build-Flow-Plugin to eliminate Cyclic Dependency among the plugins.

        Attachments

          Activity

          Hide
          pskumar448 Suresh Kumar added a comment - - edited

          Damien Nozay
          I have almost implemented auto refresh functionality in buildgraph-view.
          When I observe log there is one exception message.
          I tried to observe the scenarios when this exception is coming.
          When Build-Flow-Plugin schedule a build, the FlowDownStreamRunDeclarer is giving sending null, because of this NullPointerException coming
          Caused by: java.lang.NullPointerException
          at org.jenkinsci.plugins.buildgraphview.BuildExecution.<init>(BuildExecution.java:52)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.getExecution(BuildGraph.java:94)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:80)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.getGraph(BuildGraph.java:69)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.getBuildSteps(BuildGraph.java:148)

          I forked out the build-flow-plugin and tried to eliminate the null build from the FlowDownStreamRunDeclarer and observed the same scenarios, there is no exception message and auto refresh functionality is working as excepted.

          Request you to remove the FlowDownStreamRunDeclarer from the Build-Flow-Plugin.
          I will include the same in BuildGraph-Plugin

          Show
          pskumar448 Suresh Kumar added a comment - - edited Damien Nozay I have almost implemented auto refresh functionality in buildgraph-view. When I observe log there is one exception message. I tried to observe the scenarios when this exception is coming. When Build-Flow-Plugin schedule a build, the FlowDownStreamRunDeclarer is giving sending null, because of this NullPointerException coming Caused by: java.lang.NullPointerException at org.jenkinsci.plugins.buildgraphview.BuildExecution.<init>(BuildExecution.java:52) at org.jenkinsci.plugins.buildgraphview.BuildGraph.getExecution(BuildGraph.java:94) at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:80) at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84) at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84) at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84) at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84) at org.jenkinsci.plugins.buildgraphview.BuildGraph.getGraph(BuildGraph.java:69) at org.jenkinsci.plugins.buildgraphview.BuildGraph.getBuildSteps(BuildGraph.java:148) I forked out the build-flow-plugin and tried to eliminate the null build from the FlowDownStreamRunDeclarer and observed the same scenarios, there is no exception message and auto refresh functionality is working as excepted. Request you to remove the FlowDownStreamRunDeclarer from the Build-Flow-Plugin. I will include the same in BuildGraph-Plugin
          Hide
          dnozay Damien Nozay added a comment -

          https://github.com/jenkinsci/build-flow-plugin/commits/master/src/main/java/com/cloudbees/plugins/flow/FlowDownStreamRunDeclarer.java

          No, I will not remove FlowDownStreamRunDeclarer.

          Caused by: java.lang.NullPointerException
          at org.jenkinsci.plugins.buildgraphview.BuildExecution.<init>(BuildExecution.java:52)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.getExecution(BuildGraph.java:94)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:80)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.getGraph(BuildGraph.java:69)
          at org.jenkinsci.plugins.buildgraphview.BuildGraph.getBuildSteps(BuildGraph.java:148)
          

          It also seems one of these functions in the stack trace could check for null, isn't that possible?

          Show
          dnozay Damien Nozay added a comment - https://github.com/jenkinsci/build-flow-plugin/commits/master/src/main/java/com/cloudbees/plugins/flow/FlowDownStreamRunDeclarer.java No, I will not remove FlowDownStreamRunDeclarer. Caused by: java.lang.NullPointerException at org.jenkinsci.plugins.buildgraphview.BuildExecution.<init>(BuildExecution.java:52) at org.jenkinsci.plugins.buildgraphview.BuildGraph.getExecution(BuildGraph.java:94) at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:80) at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84) at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84) at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84) at org.jenkinsci.plugins.buildgraphview.BuildGraph.computeGraphFrom(BuildGraph.java:84) at org.jenkinsci.plugins.buildgraphview.BuildGraph.getGraph(BuildGraph.java:69) at org.jenkinsci.plugins.buildgraphview.BuildGraph.getBuildSteps(BuildGraph.java:148) It also seems one of these functions in the stack trace could check for null, isn't that possible?
          Hide
          pskumar448 Suresh Kumar added a comment -

          Ok Thats fine.
          I tried in all possible ways to handle in buildgraph-view, but no luck and finally tried with the below PR fix, the above exception is not coming.
          Then could you please merge this PR
          https://github.com/jenkinsci/build-flow-plugin/pull/69

          It solves the problem in buildgraph-view.

          Show
          pskumar448 Suresh Kumar added a comment - Ok Thats fine. I tried in all possible ways to handle in buildgraph-view, but no luck and finally tried with the below PR fix, the above exception is not coming. Then could you please merge this PR https://github.com/jenkinsci/build-flow-plugin/pull/69 It solves the problem in buildgraph-view.
          Hide
          pskumar448 Suresh Kumar added a comment -

          With out the above PR, I am able to handle and now exception message is not coming. But if you could merge the PR, it will help other plugin which are referring this.

          Any how Thanks. Damien Nozay

          Show
          pskumar448 Suresh Kumar added a comment - With out the above PR, I am able to handle and now exception message is not coming. But if you could merge the PR, it will help other plugin which are referring this. Any how Thanks. Damien Nozay
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Suresh Kumar P
          Path:
          pom.xml
          src/main/java/com/cloudbees/plugins/flow/FlowDownStreamRunDeclarer.java
          http://jenkins-ci.org/commit/build-flow-plugin/7340c358629f8d3ea914fa501c61222908d36161
          Log:
          Move FlowDownStreamRunDeclarer.java from build-flow-plugin to buildgraph-view

          [FIXED JENKINS-34516] [FIXED JENKINS-32499]

          Compare: https://github.com/jenkinsci/build-flow-plugin/compare/c68e7b0594f2...7340c358629f

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Suresh Kumar P Path: pom.xml src/main/java/com/cloudbees/plugins/flow/FlowDownStreamRunDeclarer.java http://jenkins-ci.org/commit/build-flow-plugin/7340c358629f8d3ea914fa501c61222908d36161 Log: Move FlowDownStreamRunDeclarer.java from build-flow-plugin to buildgraph-view [FIXED JENKINS-34516] [FIXED JENKINS-32499] Compare: https://github.com/jenkinsci/build-flow-plugin/compare/c68e7b0594f2...7340c358629f
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Suresh Kumar P
          Path:
          pom.xml
          src/main/java/com/cloudbees/plugins/flow/FlowDownStreamRunDeclarer.java
          http://jenkins-ci.org/commit/build-flow-plugin/908af0e024e604651a6a7cf709e5ddda32d6034b
          Log:
          Move FlowDownStreamRunDeclarer.java from build-flow-plugin to buildgraph-view

          [FIXED JENKINS-34516] [FIXED JENKINS-32499]

          Compare: https://github.com/jenkinsci/build-flow-plugin/compare/7340c358629f...908af0e024e6

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Suresh Kumar P Path: pom.xml src/main/java/com/cloudbees/plugins/flow/FlowDownStreamRunDeclarer.java http://jenkins-ci.org/commit/build-flow-plugin/908af0e024e604651a6a7cf709e5ddda32d6034b Log: Move FlowDownStreamRunDeclarer.java from build-flow-plugin to buildgraph-view [FIXED JENKINS-34516] [FIXED JENKINS-32499] Compare: https://github.com/jenkinsci/build-flow-plugin/compare/7340c358629f...908af0e024e6
          Show
          rodrigc Craig Rodrigues added a comment - Fixed in http://jenkins-ci.org/commit/build-flow-plugin/908af0e024e604651a6a7cf709e5ddda32d6034b

            People

            • Assignee:
              rodrigc Craig Rodrigues
              Reporter:
              pskumar448 Suresh Kumar
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: