Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34705

Infinite loop in PluginSetupWizard.js::checkConnectivity() on a custom UpdateSite

    Details

    • Similar Issues:

      Description

      UpdateSite in Jenkins can return null from getConnectionCheckUrl() in order to indicate that the connection check should be skipped.

      In Jenkins 2.2 there is no special status for the "SKIPPED" connection check. UpdateCenter::doCheckConnection() returns

      {"internet": "UNCHECKED"}

      in such case.

      When PluginSetupWizard.js::checkConnectivity() receives such UNCHECKED result, it tries to query Jenkins again with 100ms timeout. Actually it leads to the infinite loop, because Jenkins UpdateCenter returns "UNCHECKED" forever.

        Attachments

          Activity

          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Working on it

          Show
          oleg_nenashev Oleg Nenashev added a comment - Working on it
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/model/UpdateCenter.java
          core/src/main/java/hudson/model/UpdateSite.java
          war/src/main/js/util/jenkins.js
          http://jenkins-ci.org/commit/jenkins/930f6308a5e0b29a45b88b626f51b246107e2830
          Log:
          JENKINS-34705 - Prevent hanging of InstallationWizard if internet check is skipped (#2328)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/UpdateCenter.java core/src/main/java/hudson/model/UpdateSite.java war/src/main/js/util/jenkins.js http://jenkins-ci.org/commit/jenkins/930f6308a5e0b29a45b88b626f51b246107e2830 Log: JENKINS-34705 - Prevent hanging of InstallationWizard if internet check is skipped (#2328)
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Released in jenkins-2.4

          Show
          oleg_nenashev Oleg Nenashev added a comment - Released in jenkins-2.4

            People

            • Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: