Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34791

Pipeline stage plugin shows "No data available..." if active builds are more then 10 AND provide system properties to override stage view hardcoded limits

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Plugin shows only last 10 active builds. I have not found in documentation where this amount could be increased. After this, if active build number is more then 10 (I created input to test this), then plugin shows "Data not available...". I attached screenshot too. Full stage view shows the same. As user I expect some pagination in "Full stage view" or at least some configuration where I can increase amount of builds to show.

      Added:
      For the hardcoded limits used in stage view, it would be helpful to provide documented system properties that override defaults where users wish to display more items, despite the performance impacts.

        Attachments

          Activity

          Hide
          svanoort Sam Van Oort added a comment -

          Ilja Gaitsenja In this circumstance have any of the runs reached the point where there is a stage step executed yet? It would be helpful if you could provide a sample workflow script for this.

          Providing a user-settable property to configure the hardcoded limits on builds is a separate RFE, but since it's trivial, let's lump it in with this (and add a property setting for the other hardcoded limits too).

          Show
          svanoort Sam Van Oort added a comment - Ilja Gaitsenja In this circumstance have any of the runs reached the point where there is a stage step executed yet? It would be helpful if you could provide a sample workflow script for this. Providing a user-settable property to configure the hardcoded limits on builds is a separate RFE, but since it's trivial, let's lump it in with this (and add a property setting for the other hardcoded limits too).
          Hide
          svanoort Sam Van Oort added a comment - - edited

          Cannot reproduce locally with this script & 15 or so concurrent builds:

          stage 'testing'
          echo 'beforesleep'
          sleep 60
          echo 'sleep done'
          

          Edit: downgrading the priority, since this doesn't appear to be occurring in the common case, and probably represents a less common edge case here.

          Show
          svanoort Sam Van Oort added a comment - - edited Cannot reproduce locally with this script & 15 or so concurrent builds: stage 'testing' echo 'beforesleep' sleep 60 echo 'sleep done' Edit: downgrading the priority, since this doesn't appear to be occurring in the common case, and probably represents a less common edge case here.
          Hide
          drobus Ilja Gaitsenja added a comment -

          Sam Van Oort The code is:

          node {
          stage 'testing'
          echo 'before input'
          stage 'testing 2'
          sleep 60
          }
          

          I'm newby with pipelines, maybe I do something wrong. Could you provide reference to documentation where I can read about "user-settable property to configure the hardcoded limits" and other useful properties.

          Show
          drobus Ilja Gaitsenja added a comment - Sam Van Oort The code is: node { stage 'testing' echo 'before input' stage 'testing 2' sleep 60 } I'm newby with pipelines, maybe I do something wrong. Could you provide reference to documentation where I can read about "user-settable property to configure the hardcoded limits" and other useful properties.
          Hide
          svanoort Sam Van Oort added a comment -

          Ilja Gaitsenja The problem you're experiencing is probably that the job is blocked waiting for an executor slot (which the node block is acquiring), and the stage isn't created until the executor is available (when the node block starts executing its contents).

          This should avoid the issue you see:

          stage 'testing'
          node {
          echo 'before input'
          sh "echo 'I am doing something that requires a node here' "
          sh 'mvn clean install'  // Example, something like that
          }
          // Best practice: don't hold the node longer than you need to, and echo/stage/sleep steps don't need a node to run, of course
          stage 'testing 2'
          sleep 60
          

          user-settable property to configure the hardcoded limits

          That was a small, related request-for-enhancement I wanted to tie together with similar code changes here.

          Show
          svanoort Sam Van Oort added a comment - Ilja Gaitsenja The problem you're experiencing is probably that the job is blocked waiting for an executor slot (which the node block is acquiring), and the stage isn't created until the executor is available (when the node block starts executing its contents). This should avoid the issue you see: stage 'testing' node { echo 'before input' sh "echo 'I am doing something that requires a node here' " sh 'mvn clean install' // Example, something like that } // Best practice: don 't hold the node longer than you need to, and echo/stage/sleep steps don' t need a node to run, of course stage 'testing 2' sleep 60 user-settable property to configure the hardcoded limits That was a small, related request-for-enhancement I wanted to tie together with similar code changes here.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          rest-api/src/main/java/com/cloudbees/workflow/rest/external/FlowNodeLogExt.java
          rest-api/src/main/java/com/cloudbees/workflow/rest/external/JobExt.java
          rest-api/src/main/java/com/cloudbees/workflow/rest/external/RunExt.java
          rest-api/src/main/java/com/cloudbees/workflow/rest/external/StageNodeExt.java
          ui/src/main/js/model/runs-stage-grouped.js
          http://jenkins-ci.org/commit/pipeline-stage-view-plugin/c5ca0a9190773ec211f1899cbd0c5eb4b3cec31d
          Log:
          Properties to configure hardcoded limits on APIs - JENKINS-34791

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: rest-api/src/main/java/com/cloudbees/workflow/rest/external/FlowNodeLogExt.java rest-api/src/main/java/com/cloudbees/workflow/rest/external/JobExt.java rest-api/src/main/java/com/cloudbees/workflow/rest/external/RunExt.java rest-api/src/main/java/com/cloudbees/workflow/rest/external/StageNodeExt.java ui/src/main/js/model/runs-stage-grouped.js http://jenkins-ci.org/commit/pipeline-stage-view-plugin/c5ca0a9190773ec211f1899cbd0c5eb4b3cec31d Log: Properties to configure hardcoded limits on APIs - JENKINS-34791
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          rest-api/src/main/java/com/cloudbees/workflow/rest/external/FlowNodeLogExt.java
          rest-api/src/main/java/com/cloudbees/workflow/rest/external/JobExt.java
          rest-api/src/main/java/com/cloudbees/workflow/rest/external/RunExt.java
          rest-api/src/main/java/com/cloudbees/workflow/rest/external/StageNodeExt.java
          ui/src/main/js/model/runs-stage-grouped.js
          http://jenkins-ci.org/commit/pipeline-stage-view-plugin/058e4a62cdef99fa3e3030894139c1d6ce176ad9
          Log:
          Merge pull request #14 from jenkinsci/properties-to-configure-hardcoded-limits

          Properties to configure hardcoded limits on APIs - JENKINS-34791

          Compare: https://github.com/jenkinsci/pipeline-stage-view-plugin/compare/53c9f5764f96...058e4a62cdef

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: rest-api/src/main/java/com/cloudbees/workflow/rest/external/FlowNodeLogExt.java rest-api/src/main/java/com/cloudbees/workflow/rest/external/JobExt.java rest-api/src/main/java/com/cloudbees/workflow/rest/external/RunExt.java rest-api/src/main/java/com/cloudbees/workflow/rest/external/StageNodeExt.java ui/src/main/js/model/runs-stage-grouped.js http://jenkins-ci.org/commit/pipeline-stage-view-plugin/058e4a62cdef99fa3e3030894139c1d6ce176ad9 Log: Merge pull request #14 from jenkinsci/properties-to-configure-hardcoded-limits Properties to configure hardcoded limits on APIs - JENKINS-34791 Compare: https://github.com/jenkinsci/pipeline-stage-view-plugin/compare/53c9f5764f96...058e4a62cdef
          Hide
          svanoort Sam Van Oort added a comment -

          Released with v1.5, updating wiki to show new config options

          Show
          svanoort Sam Van Oort added a comment - Released with v1.5, updating wiki to show new config options

            People

            • Assignee:
              svanoort Sam Van Oort
              Reporter:
              drobus Ilja Gaitsenja
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: