Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34888

Too much string concatenation in unmarshalling code

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      In the RobustReflectionConverter, there is a bit of code concatenating strings based on field and class and checking for them in a set (critical fields). The number of critical fields is very low, but the number of fields to check is very high, so we end up doing a LOT of string concatentation for no purpose at all.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Matt Mitchell
          Path:
          core/src/main/java/hudson/util/RobustReflectionConverter.java
          http://jenkins-ci.org/commit/jenkins/d08eec18dcb2291da2d576e62dc128d00829858b
          Log:
          JENKINS-34888 - Scalability: Fix performance issues in the XML unmarshalling code (#2340)

          • [x] - Avoid String concatenation
          • [x] - Switch to R/W lock instead of the specialized container with a significant overhead
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Matt Mitchell Path: core/src/main/java/hudson/util/RobustReflectionConverter.java http://jenkins-ci.org/commit/jenkins/d08eec18dcb2291da2d576e62dc128d00829858b Log: JENKINS-34888 - Scalability: Fix performance issues in the XML unmarshalling code (#2340) [x] - Avoid String concatenation [x] - Switch to R/W lock instead of the specialized container with a significant overhead
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Released as Jenkins-2.6

          Show
          oleg_nenashev Oleg Nenashev added a comment - Released as Jenkins-2.6

            People

            • Assignee:
              mmitche Matthew Mitchell
              Reporter:
              mmitche Matthew Mitchell
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: