Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35153

Events.JobChannel#job_crud_deleted publishing blocked by AccessControl

    Details

    • Epic Link:
    • Sprint:
      1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, pannonian, iapetus
    • Similar Issues:

      Description

      This is actually an issue in the pubsub-light-module. The GuavaPubsubBus does an AccessControlled check before allowing publishing of any message. The first part of that is to check for the existence of the model object associated with the event. But of course In the case of this delete event (or any other delete event), the model object no longer exists, causing the security check to fail and for the event to not be published.

      Need to come up with some event specific way of indicating that it's OK to forward the event if the model object does not exist.

        Attachments

          Activity

          Hide
          jamesdumay James Dumay added a comment -

          Tom FENNELLY this one has been hanging around for quite a few sprints. Is it still valid?

          Show
          jamesdumay James Dumay added a comment - Tom FENNELLY this one has been hanging around for quite a few sprints. Is it still valid?
          Hide
          tfennelly Tom FENNELLY added a comment -

          This is no longer an issue. I'm guessing we made some other changes at some point that made this go away. We are caching a ref to the deleted object, allowing the permission check to happen. Not entirely sure other than those events are going through fine now.

          Show
          tfennelly Tom FENNELLY added a comment - This is no longer an issue. I'm guessing we made some other changes at some point that made this go away. We are caching a ref to the deleted object, allowing the permission check to happen. Not entirely sure other than those events are going through fine now.

            People

            • Assignee:
              tfennelly Tom FENNELLY
              Reporter:
              tfennelly Tom FENNELLY
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: