Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35198

DelegatingComputerLauncher allowing to use other DelegatingComputerLauncher as delegate

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      The utility base class DelegatingComputerLauncher comes with a descriptor implementation that advertises (primarily for the UI) which other launchers are accepted as delegated launchers.

      Specific code has been implemented for filtering out other DelegatingComputerLauncher instances from the possible delegate list in order to avoid multiple level ComputerLauncher recursions.

      The reported issue is that this filtering is not working, and the descriptor's "getApplicableDescriptors()" method returns also the descriptors of DelegatingComputerLauncher instances.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: peppelan
          Path:
          core/src/main/java/hudson/slaves/DelegatingComputerLauncher.java
          core/src/test/java/hudson/slaves/DelegatingComputerLauncherTest.java
          http://jenkins-ci.org/commit/jenkins/15ce24ae4dac23a732f193f29b6423bc03be7a49
          Log:
          JENKINS-35198 - DelegatingComputerLauncher should accept child classes in its hooks (#2384)

          • JENKINS-35198 Add failing test for clear identification of the issue and future regression test
          • JENKINS-35198 Fix DelegatingComputerLauncher logic for filtering out subclasses as possible delegates

          this logic is by default, and subclasses can still allow the selection of other DelegatingComputerLauncher instances as delegates.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: peppelan Path: core/src/main/java/hudson/slaves/DelegatingComputerLauncher.java core/src/test/java/hudson/slaves/DelegatingComputerLauncherTest.java http://jenkins-ci.org/commit/jenkins/15ce24ae4dac23a732f193f29b6423bc03be7a49 Log: JENKINS-35198 - DelegatingComputerLauncher should accept child classes in its hooks (#2384) JENKINS-35198 Add failing test for clear identification of the issue and future regression test JENKINS-35198 Fix DelegatingComputerLauncher logic for filtering out subclasses as possible delegates this logic is by default, and subclasses can still allow the selection of other DelegatingComputerLauncher instances as delegates.
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Released as Jenkins-2.8

          Show
          oleg_nenashev Oleg Nenashev added a comment - Released as Jenkins-2.8

            People

            • Assignee:
              peppe Giuseppe Landolfi
              Reporter:
              peppe Giuseppe Landolfi
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: