Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35247

Move git/svn steps out of workflow-scm-steps

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Arnaud Héritier pointed out that when installing recommended plugins in Jenkins 2, sometimes the git step does not work in Pipeline builds until after a restart. This is because when workflow-scm-step is loaded, git might not yet be installed, so GitStep.DescriptorImpl would be skipped. If later in the same session git is installed, this extension is not revisited.

      Simpler to keep the SCM-specific steps in the corresponding plugins.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java
            src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java
            http://jenkins-ci.org/commit/workflow-scm-step-plugin/58237d3ca4f72fa102234910018286d9898cfcc4
            Log:
            Merge pull request #3 from jglick/SCMStep-JENKINS-35247-reflection

            JENKINS-35247 Delegate to Git and Subversion plugins via reflection

            Compare: https://github.com/jenkinsci/workflow-scm-step-plugin/compare/edc5c6262d9f...58237d3ca4f7

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java http://jenkins-ci.org/commit/workflow-scm-step-plugin/58237d3ca4f72fa102234910018286d9898cfcc4 Log: Merge pull request #3 from jglick/SCMStep- JENKINS-35247 -reflection JENKINS-35247 Delegate to Git and Subversion plugins via reflection Compare: https://github.com/jenkinsci/workflow-scm-step-plugin/compare/edc5c6262d9f...58237d3ca4f7
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/hudson/plugins/git/GitSCM.java
            src/main/java/jenkins/plugins/git/GitStep.java
            src/main/resources/jenkins/plugins/git/GitStep/config.jelly
            src/main/resources/jenkins/plugins/git/GitStep/help.html
            src/main/resources/jenkins/plugins/git/Messages.properties
            src/test/java/jenkins/plugins/git/GitSampleRepoRule.java
            src/test/java/jenkins/plugins/git/GitStepTest.java
            http://jenkins-ci.org/commit/git-plugin/470a4ca0837e1af444423a156e20115f58ae9124
            Log:
            JENKINS-35247 Moved GitStep to git-plugin.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/hudson/plugins/git/GitSCM.java src/main/java/jenkins/plugins/git/GitStep.java src/main/resources/jenkins/plugins/git/GitStep/config.jelly src/main/resources/jenkins/plugins/git/GitStep/help.html src/main/resources/jenkins/plugins/git/Messages.properties src/test/java/jenkins/plugins/git/GitSampleRepoRule.java src/test/java/jenkins/plugins/git/GitStepTest.java http://jenkins-ci.org/commit/git-plugin/470a4ca0837e1af444423a156e20115f58ae9124 Log: JENKINS-35247 Moved GitStep to git-plugin.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Mark Waite
            Path:
            pom.xml
            src/main/java/hudson/plugins/git/GitSCM.java
            src/main/java/jenkins/plugins/git/GitStep.java
            src/main/resources/jenkins/plugins/git/GitStep/config.jelly
            src/main/resources/jenkins/plugins/git/GitStep/help.html
            src/main/resources/jenkins/plugins/git/Messages.properties
            src/test/java/jenkins/plugins/git/GitSampleRepoRule.java
            src/test/java/jenkins/plugins/git/GitStepTest.java
            http://jenkins-ci.org/commit/git-plugin/7e9edc7e448ed29e287171046ba2c859b41a1cd8
            Log:
            Merge pull request #406 from jglick/SCMStep-JENKINS-35247

            JENKINS-35247 Moved GitStep to git-plugin

            Compare: https://github.com/jenkinsci/git-plugin/compare/7a31858e61d2...7e9edc7e448e

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: pom.xml src/main/java/hudson/plugins/git/GitSCM.java src/main/java/jenkins/plugins/git/GitStep.java src/main/resources/jenkins/plugins/git/GitStep/config.jelly src/main/resources/jenkins/plugins/git/GitStep/help.html src/main/resources/jenkins/plugins/git/Messages.properties src/test/java/jenkins/plugins/git/GitSampleRepoRule.java src/test/java/jenkins/plugins/git/GitStepTest.java http://jenkins-ci.org/commit/git-plugin/7e9edc7e448ed29e287171046ba2c859b41a1cd8 Log: Merge pull request #406 from jglick/SCMStep- JENKINS-35247 JENKINS-35247 Moved GitStep to git-plugin Compare: https://github.com/jenkinsci/git-plugin/compare/7a31858e61d2...7e9edc7e448e
            Hide
            markewaite Mark Waite added a comment -

            Included in git plugin 2.5.0 released 19 Jun 2016

            Show
            markewaite Mark Waite added a comment - Included in git plugin 2.5.0 released 19 Jun 2016
            Hide
            aheritier Arnaud Héritier added a comment -

            cool. Thanks guys

            Show
            aheritier Arnaud Héritier added a comment - cool. Thanks guys

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: