Details

    • Epic Link:
    • Sprint:
      1.0-japan-m9
    • Similar Issues:

      Description

      Quoting [~mneale] here:

      Pull requests are often these days a WIP. I wonder if elevating them somehow makes sense (I know we have them first class) but could indicate when looking at pipelines that "hey, there is outstanding work here... you may want to take a look" could be a nice value add. It isn't really personalisation, and really, it is githubs job, it just doesn't do a good job of telling you there are outstanding things to look at (that have been built).

      Perhaps these should only be used if we are indicating something interesting/actionable? For example, I don't think these should be used on the Branches tab for a branch count as they are arguably not actionable but on the Pull Requests tab they indicate "outstanding work" to be actioned.

      In Scope

      • Visual design
      • Usage patterns on JDL confluence page
      • Should have light and dark variants
      • Update the test pipeline result tab test counts
      • Add one to the Pipeline Summary Activity tab screen for the Branch tab

        Attachments

          Activity

          Hide
          gusreiber gus reiber added a comment -

          How many digits to you figure you will need to accommodate?

          Show
          gusreiber gus reiber added a comment - How many digits to you figure you will need to accommodate?
          Hide
          gusreiber gus reiber added a comment -

          Also, do you envision needing to show 2 sets of counts ever, something like "3/4". regardless, I will have some images here in just a sec.

          Show
          gusreiber gus reiber added a comment - Also, do you envision needing to show 2 sets of counts ever, something like "3/4". regardless, I will have some images here in just a sec.
          Hide
          gusreiber gus reiber added a comment -

          I think it makes sense to set a background color that is a 50% opacity white if the background is a color and a 50% opacity blue if the background color is white. This does 3 things, lessens the contrast of the pill, which is what you want, because it is adjunct information and you don't want the page to look like it is covered with zits if you have a few of these, allows the number to be the same color as the text, and allows you to use the same style rule, regardless of the background color (other than white).

          The outside of the pill should be the same size as the font size. Its bottom most tangent point should site 1 or 2 pixels below the baseline of the text. The inner number font should be ~2/3 the size of the outer base font and be centered in the circle. If the number is more than one digit, the circle needs to stretch through the middle.

          The pill should be ~10px to the right of the associated text, and if included in a button, the right padding after the button should be ~2/3 the padding on the left.

          ....or so I suggest.

          Show
          gusreiber gus reiber added a comment - I think it makes sense to set a background color that is a 50% opacity white if the background is a color and a 50% opacity blue if the background color is white. This does 3 things, lessens the contrast of the pill, which is what you want, because it is adjunct information and you don't want the page to look like it is covered with zits if you have a few of these, allows the number to be the same color as the text, and allows you to use the same style rule, regardless of the background color (other than white). The outside of the pill should be the same size as the font size. Its bottom most tangent point should site 1 or 2 pixels below the baseline of the text. The inner number font should be ~2/3 the size of the outer base font and be centered in the circle. If the number is more than one digit, the circle needs to stretch through the middle. The pill should be ~10px to the right of the associated text, and if included in a button, the right padding after the button should be ~2/3 the padding on the left. ....or so I suggest.
          Hide
          jamesdumay James Dumay added a comment -

          I like that a lot [~greiber]. What does it look like without the transparency?

          Show
          jamesdumay James Dumay added a comment - I like that a lot [~greiber] . What does it look like without the transparency?

            People

            • Assignee:
              Unassigned
              Reporter:
              jamesdumay James Dumay
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: