Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36720

Investigate/cleanup medium-severity FindBugs issues in the Jenkins core

    Details

    • Similar Issues:

      Description

      Currently FindBugs settings ignore all medium-priority issues. It's bad, because this level contains NPE checks and other serious issues.

      TODOs:

      • Remove filtering of medium-priority issues by settingĀ <findbugs.threshold>Medium</findbugs.threshold>
      • Investigate error codes, add low-important once to the ignore list
      • Fix important issues in small pull requests

      This task can be handled by multiple contributors!

        Attachments

          Activity

          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Summary:

          • 2 issues in CLI
          • 477 issues in the core

          The output is too long to be published as text, I'll attach it

          Show
          oleg_nenashev Oleg Nenashev added a comment - Summary: 2 issues in CLI 477 issues in the core The output is too long to be published as text, I'll attach it
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/jenkins/6ca0d754c5cba97613bc8b1e7b33327119fbf79c
          Log:
          JENKINS-36720 - FindBugs. Reduse threshold to Medium

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/6ca0d754c5cba97613bc8b1e7b33327119fbf79c Log: JENKINS-36720 - FindBugs. Reduse threshold to Medium
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          It's actually newbie-friendly. Anyone can pick the core, run FindBugs and then cleanup something from the report. This issue is rather a milestone for such kind of activities

          Show
          oleg_nenashev Oleg Nenashev added a comment - It's actually newbie-friendly. Anyone can pick the core, run FindBugs and then cleanup something from the report. This issue is rather a milestone for such kind of activities
          Hide
          danielbeck Daniel Beck added a comment -

          Is this done completely in 2.191, or just partially?

          Show
          danielbeck Daniel Beck added a comment - Is this done completely in 2.191, or just partially?
          Hide
          stefan_spieker Stefan Spieker added a comment -

          There are several PRs done for this and there are more to come. This is a quite huge task. I think we would be down to 400 spotbugs issues if all PRs would be merged. So I guess this will be in progress for a longer while

          Show
          stefan_spieker Stefan Spieker added a comment - There are several PRs done for this and there are more to come. This is a quite huge task. I think we would be down to 400 spotbugs issues if all PRs would be merged. So I guess this will be in progress for a longer while
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          I am thinking about Highlighting this story for Hacktoberfest. WDYT Stefan Spieker?

          Show
          oleg_nenashev Oleg Nenashev added a comment - I am thinking about Highlighting this story for Hacktoberfest. WDYT Stefan Spieker ?
          Hide
          stefan_spieker Stefan Spieker added a comment -

          Oleg Nenashev: Yes. That is a good idea. We have a lot issues still to solve. Maybe you should mention then that changing in the main pom the line 109 with this : <findbugs.threshold>Medium</findbugs.threshold> is enough to get all spotbugs issues.

          Show
          stefan_spieker Stefan Spieker added a comment - Oleg Nenashev : Yes. That is a good idea. We have a lot issues still to solve. Maybe you should mention then that changing in the main pom the line 109 with this : <findbugs.threshold>Medium</findbugs.threshold> is enough to get all spotbugs issues.

            People

            • Assignee:
              stefan_spieker Stefan Spieker
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: