Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36996

The JNLP launchers should not be available when the JNLP port is disabled

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      We are only confusing users if we leave it as an option when we know it won't work

        Attachments

          Issue Links

            Activity

            Hide
            stephenconnolly Stephen Connolly added a comment -

            towards 2.16

            Show
            stephenconnolly Stephen Connolly added a comment - towards 2.16
            Hide
            ronald_petty Ronald Petty added a comment -

            I just found this out the hard way. JNLP is disabled, but can still download. This lead to me dancing here https://issues.jenkins-ci.org/browse/JENKINS-38318.

            laptop:temp ronaldpetty$ curl -vO http://localhost:8080/jnlpJars/jenkins-cli.jar
              % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                             Dload  Upload   Total   Spent    Left  Speed
              0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying ::1...
            * Connected to localhost (::1) port 8080 (#0)
            > GET /jnlpJars/jenkins-cli.jar HTTP/1.1
            > Host: localhost:8080
            > User-Agent: curl/7.43.0
            > Accept: */*
            > 
            < HTTP/1.1 200 OK
            < Date: Mon, 19 Sep 2016 00:09:38 GMT
            < X-Content-Type-Options: nosniff
            < Content-Disposition: attachment; filename=jenkins-cli.jar
            < Last-Modified: Wed, 14 Sep 2016 21:43:58 GMT
            < Expires: Wed, 14 Sep 2016 21:43:58 GMT
            < Accept-Ranges: bytes
            < Content-Type: application/java-archive
            < Content-Length: 837045
            < Server: Jetty(9.2.z-SNAPSHOT)
            < 
            { [16033 bytes data]
            100  817k  100  817k    0     0  83.6M      0 --:--:-- --:--:-- --:--:-- 88.6M
            * Connection #0 to host localhost left intact
            
            Show
            ronald_petty Ronald Petty added a comment - I just found this out the hard way. JNLP is disabled, but can still download. This lead to me dancing here https://issues.jenkins-ci.org/browse/JENKINS-38318 . laptop:temp ronaldpetty$ curl -vO http: //localhost:8080/jnlpJars/jenkins-cli.jar % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0* Trying ::1... * Connected to localhost (::1) port 8080 (#0) > GET /jnlpJars/jenkins-cli.jar HTTP/1.1 > Host: localhost:8080 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 200 OK < Date: Mon, 19 Sep 2016 00:09:38 GMT < X-Content-Type-Options: nosniff < Content-Disposition: attachment; filename=jenkins-cli.jar < Last-Modified: Wed, 14 Sep 2016 21:43:58 GMT < Expires: Wed, 14 Sep 2016 21:43:58 GMT < Accept-Ranges: bytes < Content-Type: application/java-archive < Content-Length: 837045 < Server: Jetty(9.2.z-SNAPSHOT) < { [16033 bytes data] 100 817k 100 817k 0 0 83.6M 0 --:--:-- --:--:-- --:--:-- 88.6M * Connection #0 to host localhost left intact
            Hide
            ronald_petty Ronald Petty added a comment -

            I am using 2.7.4, so maybe I am old, but now I know. Will try weekly at some point.

            Show
            ronald_petty Ronald Petty added a comment - I am using 2.7.4, so maybe I am old, but now I know. Will try weekly at some point.

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                stephenconnolly Stephen Connolly
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: