Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37340

Need another pubsub event to indicate that a job run has actually started doing some work

    Details

    • Epic Link:
    • Sprint:
      1.0-pre-beta-1, 1.0-beta-1, pacific, atlantic, 1.0-b05/b-06
    • Similar Issues:

      Description

      From Cliff Meyers
      The server side events for Pipeline jobs fire immediately. If the user presses the "Build Now" from Classic UI eight times, the Blue Ocean UI will receive events showing status of "QUEUED", "ALLOCATED" and "RUNNING" for all eight jobs immediately. Meanwhile the classic UI shows six of the jobs as queued, while two are running (what the user would expect with only two executors active.

      Some implementation ideas, from Cliff Meyers
      Introduce custom logic in "pubsub-light" SyncRunListener to not fire start events for Pipeline jobs. Create some kind of new listener - "PipelineSyncRunListener, possibly in a new module like pipeline-pubsub-light" - when receives notification of Pipeline's step/stage start and then produces the proper start event as in SyncRunListener.

      and impl ideas from Tom FENNELLY
      Keep the existing "started" event but add a new event called "running" which the Blue Ocean UI would use to transition the job from "queued" to "running"

        Attachments

          Activity

          Hide
          tfennelly Tom FENNELLY added a comment -

          The run_started event fires at the right time i.e. when the run moves out of the queue. The problem with pipeline runs is that this happens immediately as the run creates a "lightweight" run task that's not really doing anything yet. We need another pubsub event to let listeners know when the run has actually started "running" some of the pipeline steps.

          Please remember that the pubsub stuff should remain generic i.e. not specific to the UI needs, so when we hit things like this we need to address them in a general way Vs just having the UI goggles on.

          Show
          tfennelly Tom FENNELLY added a comment - The run_started event fires at the right time i.e. when the run moves out of the queue. The problem with pipeline runs is that this happens immediately as the run creates a "lightweight" run task that's not really doing anything yet. We need another pubsub event to let listeners know when the run has actually started "running" some of the pipeline steps. Please remember that the pubsub stuff should remain generic i.e. not specific to the UI needs, so when we hit things like this we need to address them in a general way Vs just having the UI goggles on.
          Hide
          michaelneale Michael Neale added a comment -

          Cliff Meyers is this blocking favourite realtime stuff?

          Show
          michaelneale Michael Neale added a comment - Cliff Meyers is this blocking favourite realtime stuff?
          Hide
          michaelneale Michael Neale added a comment -

          Should really see what cliff cooks up on JENKINS-37379 - before tackling this. May not be needed.

          Show
          michaelneale Michael Neale added a comment - Should really see what cliff cooks up on JENKINS-37379 - before tackling this. May not be needed.
          Hide
          cliffmeyers Cliff Meyers added a comment -

          Tom FENNELLY: yep, let me see if I can unblock it myself, rather than having to make the pub/sub stuff more involved. Will let you know once I get to JENKINS-37379, should be later this week.

          Show
          cliffmeyers Cliff Meyers added a comment - Tom FENNELLY : yep, let me see if I can unblock it myself, rather than having to make the pub/sub stuff more involved. Will let you know once I get to JENKINS-37379 , should be later this week.
          Hide
          michaelneale Michael Neale added a comment -

          Cliff Meyers is this something you still want tom to take a look at ?

          Show
          michaelneale Michael Neale added a comment - Cliff Meyers is this something you still want tom to take a look at ?
          Hide
          cliffmeyers Cliff Meyers added a comment - - edited

          No, I believe that once JENKINS-38540 and JENKINS-37379 are implemented that this issue will be unnecessary.

          Show
          cliffmeyers Cliff Meyers added a comment - - edited No, I believe that once JENKINS-38540 and JENKINS-37379 are implemented that this issue will be unnecessary.
          Hide
          tfennelly Tom FENNELLY added a comment -

          I can't see how these fix the underlying issue, but if it saves me doing something then

          Show
          tfennelly Tom FENNELLY added a comment - I can't see how these fix the underlying issue, but if it saves me doing something then
          Hide
          michaelneale Michael Neale added a comment -

          lets close this until we know it is needed.

          Show
          michaelneale Michael Neale added a comment - lets close this until we know it is needed.

            People

            • Assignee:
              tfennelly Tom FENNELLY
              Reporter:
              cliffmeyers Cliff Meyers
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: