Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37464

Add ability to specify multiple deployment policy groups

    Details

    • Similar Issues:

      Description

      Current configuration options does not cover every possible deployment policy scenarios. For example:

      • Deploy when there is "SCM change" if build is started by build timer
      • Deploy regardless of "SCM change" if build is started by user

      In order to achive this, plugin should group "Deployment policy" and "SCM change" options together and allow user to specify as much group as possible.

      Another option is to extend deployment policy list for all possible scenarios. This should be easier to implement and understand. For example:

      • Started by user
      • Started by user (There is SCM change)
      • Started by build timer
      • Started by build timer (There is SCM change)
      • ...

      I will submit a PR with second approach soon. Which approach has better chance of acceptance?

        Attachments

          Activity

          Hide
          raphc Raphael CHAUMIER added a comment -

          Hi,

          Nice improvement.The second one seems a good compromise.

          Regards

          Show
          raphc Raphael CHAUMIER added a comment - Hi, Nice improvement.The second one seems a good compromise. Regards
          Hide
          mustafau Mustafa Ulu added a comment -

          Attaching my progress so far. I implemented an improved version of the second approach (similar to GitSCM plugin's extension approach)

          This will be backwards compatible and easily extendable.

          Show
          mustafau Mustafa Ulu added a comment - Attaching my progress so far. I implemented an improved version of the second approach (similar to GitSCM plugin's extension approach) This will be backwards compatible and easily extendable.
          Hide
          mustafau Mustafa Ulu added a comment -

          Hi,

          Thanks for the comment.

          I didn't bother to support deprecated Causes in this implementation. Do people still use LegacyCodeCause and UserCause? If so I will add them.

          Regards.

          Show
          mustafau Mustafa Ulu added a comment - Hi, Thanks for the comment. I didn't bother to support deprecated Causes in this implementation. Do people still use LegacyCodeCause and UserCause? If so I will add them. Regards.
          Hide
          raphc Raphael CHAUMIER added a comment - - edited

          Thanks for your work,

          You can forget LegacyCodeCause and UserCause. I will add a notice in the release note of the future release. Can you check a job formerly configured with the follwoing causes is correctly loaded with the new version ?

          Regards,

          Show
          raphc Raphael CHAUMIER added a comment - - edited Thanks for your work, You can forget LegacyCodeCause and UserCause. I will add a notice in the release note of the future release. Can you check a job formerly configured with the follwoing causes is correctly loaded with the new version ? Regards,
          Hide
          mustafau Mustafa Ulu added a comment -

          I have submitted the PR. Tested with a job which is configured with all 8 causes. After the update, job is loaded successfully with 6 causes.

          Show
          mustafau Mustafa Ulu added a comment - I have submitted the PR. Tested with a job which is configured with all 8 causes. After the update, job is loaded successfully with 6 causes.

            People

            • Assignee:
              raphc Raphael CHAUMIER
              Reporter:
              mustafau Mustafa Ulu
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: