Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37495

[REGRESSION] Git Submodules having a name different to their path in working tree, failing to checkout

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: git-plugin
    • Labels:
    • Environment:
      Jenkins 2.17, Git Plugin 3.0.0, Git Client Plugin 2.0.0
    • Similar Issues:

      Description

      I tried to use somehow simplified names for some submodules having more complex path in worktree, ending up in a broken build, as git plugin tries to update-init them using their name instead of their path. leading to a unknown submodule error.

        Attachments

          Issue Links

            Activity

            Hide
            courtarro Ethan Trewhitt added a comment - - edited

            I've created a pull request that should address this issue:
            https://github.com/jenkinsci/git-client-plugin/pull/225

            Show
            courtarro Ethan Trewhitt added a comment - - edited I've created a pull request that should address this issue: https://github.com/jenkinsci/git-client-plugin/pull/225
            Hide
            lucasocio Leandro Lucarella added a comment -

            Thanks Ethan, this is a nasty regression that prevent a lot of users from upgrading. It would be nice if it can get some attention!

            Show
            lucasocio Leandro Lucarella added a comment - Thanks Ethan, this is a nasty regression that prevent a lot of users from upgrading. It would be nice if it can get some attention!
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ethan Trewhitt
            Path:
            .gitmodules
            modules/sshkeys
            http://jenkins-ci.org/commit/git-client-plugin/27a8d74a99d450801cfb0e54d51be5ea87a15218
            Log:
            Added puppetlabs-sshkeys repository as a submodule named 'sshkeys' to test that submodule updates work with a submodule whose name is != their path. JENKINS-37495

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ethan Trewhitt Path: .gitmodules modules/sshkeys http://jenkins-ci.org/commit/git-client-plugin/27a8d74a99d450801cfb0e54d51be5ea87a15218 Log: Added puppetlabs-sshkeys repository as a submodule named 'sshkeys' to test that submodule updates work with a submodule whose name is != their path. JENKINS-37495
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ethan Trewhitt
            Path:
            src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
            http://jenkins-ci.org/commit/git-client-plugin/a035c00bc2553ad8c4b1b621d31f2ce2856eaa23
            Log:
            Explicitly look up the submodule path in .gitmodules rather than assuming that the path is the same as the module name. JENKINS-37495

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ethan Trewhitt Path: src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java http://jenkins-ci.org/commit/git-client-plugin/a035c00bc2553ad8c4b1b621d31f2ce2856eaa23 Log: Explicitly look up the submodule path in .gitmodules rather than assuming that the path is the same as the module name. JENKINS-37495
            Hide
            markewaite Mark Waite added a comment -

            Fixed in git client plugin 2.2.0, released 2 Jan 2017

            Show
            markewaite Mark Waite added a comment - Fixed in git client plugin 2.2.0, released 2 Jan 2017

              People

              • Assignee:
                markewaite Mark Waite
                Reporter:
                manschwetus Florian Manschwetus
              • Votes:
                11 Vote for this issue
                Watchers:
                17 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: