Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37611

Add "@Symbol" annotation to xunit and parameters

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Snippet generator for xUnit produces some pretty ugly code. Similar to a number of other plugins, xUnit should be updated to use the "@Symbol" annotation to make the output more human readable. See JENKINS-37388 for one example.

        Attachments

          Issue Links

            Activity

            Show
            allan_burdajewicz Allan BURDAJEWICZ added a comment - Created a PR: https://github.com/jenkinsci/xunit-plugin/pull/53
            Hide
            allan_burdajewicz Allan BURDAJEWICZ added a comment - - edited

            Actually this will be most likely be fixed JENKINS-27395 (https://github.com/jenkinsci/xunit-plugin/pull/49)

            Show
            allan_burdajewicz Allan BURDAJEWICZ added a comment - - edited Actually this will be most likely be fixed JENKINS-27395 ( https://github.com/jenkinsci/xunit-plugin/pull/49 )
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nikolas Falco
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/xunit/XUnitBuilder.java
            src/main/java/org/jenkinsci/plugins/xunit/XUnitPublisher.java
            src/main/java/org/jenkinsci/plugins/xunit/threshold/FailedThresholdDescriptor.java
            src/main/java/org/jenkinsci/plugins/xunit/threshold/SkippedThresholdDescriptor.java
            src/main/java/org/jenkinsci/plugins/xunit/types/AUnitJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/BoostTestJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/CTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/CUnitJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/CheckType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/CppTestJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/CppUnitJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/CustomType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/EmbUnitType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/FPCUnitJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/GTesterJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/GoogleTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/JUnitType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/MSTestJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/MbUnitType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/NUnit3TestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/NUnitJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/PHPUnitJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/QTestLibInputMetric.java
            src/main/java/org/jenkinsci/plugins/xunit/types/QTestLibType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/UnitTestJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/ValgrindJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/XUnitDotNetTestType.java
            src/test/java/org/jenkinsci/plugins/xunit/XUnitWorkflowTest.java
            http://jenkins-ci.org/commit/xunit-plugin/f8af22b430b869497c792d8edaafd31ae9a84950
            Log:
            JENKINS-37611 Add "@Symbol" annotation to xunit and parameters

            Add @Symbol annotation to publisher, thresholds and test type to make pipeline readable. Add pipeline unit test that works with Jenkins 1.x
            Update parent pom to latest 3.9

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: pom.xml src/main/java/org/jenkinsci/plugins/xunit/XUnitBuilder.java src/main/java/org/jenkinsci/plugins/xunit/XUnitPublisher.java src/main/java/org/jenkinsci/plugins/xunit/threshold/FailedThresholdDescriptor.java src/main/java/org/jenkinsci/plugins/xunit/threshold/SkippedThresholdDescriptor.java src/main/java/org/jenkinsci/plugins/xunit/types/AUnitJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/BoostTestJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/CTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/CUnitJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/CheckType.java src/main/java/org/jenkinsci/plugins/xunit/types/CppTestJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/CppUnitJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/CustomType.java src/main/java/org/jenkinsci/plugins/xunit/types/EmbUnitType.java src/main/java/org/jenkinsci/plugins/xunit/types/FPCUnitJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/GTesterJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/GoogleTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/JUnitType.java src/main/java/org/jenkinsci/plugins/xunit/types/MSTestJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/MbUnitType.java src/main/java/org/jenkinsci/plugins/xunit/types/NUnit3TestType.java src/main/java/org/jenkinsci/plugins/xunit/types/NUnitJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/PHPUnitJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/QTestLibInputMetric.java src/main/java/org/jenkinsci/plugins/xunit/types/QTestLibType.java src/main/java/org/jenkinsci/plugins/xunit/types/UnitTestJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/ValgrindJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/XUnitDotNetTestType.java src/test/java/org/jenkinsci/plugins/xunit/XUnitWorkflowTest.java http://jenkins-ci.org/commit/xunit-plugin/f8af22b430b869497c792d8edaafd31ae9a84950 Log: JENKINS-37611 Add "@Symbol" annotation to xunit and parameters Add @Symbol annotation to publisher, thresholds and test type to make pipeline readable. Add pipeline unit test that works with Jenkins 1.x Update parent pom to latest 3.9
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nikolas Falco
            Path:
            src/main/java/org/jenkinsci/plugins/xunit/AliasInitializer.java
            src/main/java/org/jenkinsci/plugins/xunit/XUnitBuilder.java
            src/main/java/org/jenkinsci/plugins/xunit/XUnitPublisher.java
            src/main/java/org/jenkinsci/plugins/xunit/XUnitUtil.java
            src/main/java/org/jenkinsci/plugins/xunit/threshold/FailedThreshold.java
            src/main/java/org/jenkinsci/plugins/xunit/threshold/SkippedThreshold.java
            src/main/java/org/jenkinsci/plugins/xunit/threshold/XUnitThreshold.java
            src/main/java/org/jenkinsci/plugins/xunit/threshold/XUnitThresholdDescriptor.java
            src/main/resources/org/jenkinsci/plugins/xunit/XUnitBuilder/config.jelly
            src/main/resources/org/jenkinsci/plugins/xunit/XUnitPublisher/config.jelly
            src/main/resources/org/jenkinsci/plugins/xunit/threshold/Messages.properties
            src/main/resources/util/hetero-list-readonly.jelly
            src/main/resources/util/threshold.jelly
            src/test/java/org/jenkinsci/plugins/xunit/XUnitSerialisationTest.java
            src/test/java/org/jenkinsci/plugins/xunit/XUnitWorkflowTest.java
            src/test/resources/org/jenkinsci/plugins/xunit/XUnitSerialisationTest/builder_1_103/jobs/foo/config.xml
            src/test/resources/org/jenkinsci/plugins/xunit/XUnitSerialisationTest/publisher_1_103/jobs/foo/config.xml
            src/test/resources/org/jenkinsci/plugins/xunit/config.xml
            http://jenkins-ci.org/commit/xunit-plugin/46caa54a002cb93c218c4bb843b8d9ef1e7516a9
            Log:
            JENKINS-37611 Add "@Symbol" annotation to xunit and parameters

            Move threshold parameters from required to optional. Remove also unreachable checks of % character in case of percent threshold mode. Add form validation for all threshold values.
            Add unit test to guarantee serialisation works properly with plugin version before 1.103.
            Manage negative value of time margin and fix NPE when a build step or recorder has no tools defined.

            Compare: https://github.com/jenkinsci/xunit-plugin/compare/7ea630590a18...46caa54a002c
            *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

            Functionality will be removed from GitHub.com on January 31st, 2019.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/org/jenkinsci/plugins/xunit/AliasInitializer.java src/main/java/org/jenkinsci/plugins/xunit/XUnitBuilder.java src/main/java/org/jenkinsci/plugins/xunit/XUnitPublisher.java src/main/java/org/jenkinsci/plugins/xunit/XUnitUtil.java src/main/java/org/jenkinsci/plugins/xunit/threshold/FailedThreshold.java src/main/java/org/jenkinsci/plugins/xunit/threshold/SkippedThreshold.java src/main/java/org/jenkinsci/plugins/xunit/threshold/XUnitThreshold.java src/main/java/org/jenkinsci/plugins/xunit/threshold/XUnitThresholdDescriptor.java src/main/resources/org/jenkinsci/plugins/xunit/XUnitBuilder/config.jelly src/main/resources/org/jenkinsci/plugins/xunit/XUnitPublisher/config.jelly src/main/resources/org/jenkinsci/plugins/xunit/threshold/Messages.properties src/main/resources/util/hetero-list-readonly.jelly src/main/resources/util/threshold.jelly src/test/java/org/jenkinsci/plugins/xunit/XUnitSerialisationTest.java src/test/java/org/jenkinsci/plugins/xunit/XUnitWorkflowTest.java src/test/resources/org/jenkinsci/plugins/xunit/XUnitSerialisationTest/builder_1_103/jobs/foo/config.xml src/test/resources/org/jenkinsci/plugins/xunit/XUnitSerialisationTest/publisher_1_103/jobs/foo/config.xml src/test/resources/org/jenkinsci/plugins/xunit/config.xml http://jenkins-ci.org/commit/xunit-plugin/46caa54a002cb93c218c4bb843b8d9ef1e7516a9 Log: JENKINS-37611 Add "@Symbol" annotation to xunit and parameters Move threshold parameters from required to optional. Remove also unreachable checks of % character in case of percent threshold mode. Add form validation for all threshold values. Add unit test to guarantee serialisation works properly with plugin version before 1.103. Manage negative value of time margin and fix NPE when a build step or recorder has no tools defined. Compare: https://github.com/jenkinsci/xunit-plugin/compare/7ea630590a18...46caa54a002c * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nikolas Falco
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/xunit/XUnitBuilder.java
            src/main/java/org/jenkinsci/plugins/xunit/XUnitPublisher.java
            src/main/java/org/jenkinsci/plugins/xunit/threshold/FailedThresholdDescriptor.java
            src/main/java/org/jenkinsci/plugins/xunit/threshold/SkippedThresholdDescriptor.java
            src/main/java/org/jenkinsci/plugins/xunit/types/AUnitJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/BoostTestJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/CTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/CUnitJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/CheckType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/CppTestJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/CppUnitJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/CustomType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/EmbUnitType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/FPCUnitJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/GTesterJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/GoogleTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/JUnitType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/MSTestJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/MbUnitType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/NUnit3TestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/NUnitJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/PHPUnitJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/QTestLibInputMetric.java
            src/main/java/org/jenkinsci/plugins/xunit/types/QTestLibType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/UnitTestJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/ValgrindJunitHudsonTestType.java
            src/main/java/org/jenkinsci/plugins/xunit/types/XUnitDotNetTestType.java
            src/test/java/org/jenkinsci/plugins/xunit/XUnitWorkflowTest.java
            http://jenkins-ci.org/commit/xunit-plugin/e52107f6e3b88373f02c23b9c98ba1c263f5d85f
            Log:
            JENKINS-37611 Add "@Symbol" annotation to xunit and parameters

            Add @Symbol annotation to publisher, thresholds and test type to make pipeline readable. Add pipeline unit test that works with Jenkins 1.x
            Update parent pom to latest 3.9

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: pom.xml src/main/java/org/jenkinsci/plugins/xunit/XUnitBuilder.java src/main/java/org/jenkinsci/plugins/xunit/XUnitPublisher.java src/main/java/org/jenkinsci/plugins/xunit/threshold/FailedThresholdDescriptor.java src/main/java/org/jenkinsci/plugins/xunit/threshold/SkippedThresholdDescriptor.java src/main/java/org/jenkinsci/plugins/xunit/types/AUnitJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/BoostTestJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/CTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/CUnitJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/CheckType.java src/main/java/org/jenkinsci/plugins/xunit/types/CppTestJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/CppUnitJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/CustomType.java src/main/java/org/jenkinsci/plugins/xunit/types/EmbUnitType.java src/main/java/org/jenkinsci/plugins/xunit/types/FPCUnitJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/GTesterJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/GoogleTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/JUnitType.java src/main/java/org/jenkinsci/plugins/xunit/types/MSTestJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/MbUnitType.java src/main/java/org/jenkinsci/plugins/xunit/types/NUnit3TestType.java src/main/java/org/jenkinsci/plugins/xunit/types/NUnitJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/PHPUnitJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/QTestLibInputMetric.java src/main/java/org/jenkinsci/plugins/xunit/types/QTestLibType.java src/main/java/org/jenkinsci/plugins/xunit/types/UnitTestJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/ValgrindJunitHudsonTestType.java src/main/java/org/jenkinsci/plugins/xunit/types/XUnitDotNetTestType.java src/test/java/org/jenkinsci/plugins/xunit/XUnitWorkflowTest.java http://jenkins-ci.org/commit/xunit-plugin/e52107f6e3b88373f02c23b9c98ba1c263f5d85f Log: JENKINS-37611 Add "@Symbol" annotation to xunit and parameters Add @Symbol annotation to publisher, thresholds and test type to make pipeline readable. Add pipeline unit test that works with Jenkins 1.x Update parent pom to latest 3.9
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nikolas Falco
            Path:
            src/main/java/org/jenkinsci/plugins/xunit/AliasInitializer.java
            src/main/java/org/jenkinsci/plugins/xunit/XUnitBuilder.java
            src/main/java/org/jenkinsci/plugins/xunit/XUnitPublisher.java
            src/main/java/org/jenkinsci/plugins/xunit/XUnitUtil.java
            src/main/java/org/jenkinsci/plugins/xunit/threshold/FailedThreshold.java
            src/main/java/org/jenkinsci/plugins/xunit/threshold/SkippedThreshold.java
            src/main/java/org/jenkinsci/plugins/xunit/threshold/XUnitThreshold.java
            src/main/java/org/jenkinsci/plugins/xunit/threshold/XUnitThresholdDescriptor.java
            src/main/resources/org/jenkinsci/plugins/xunit/XUnitBuilder/config.jelly
            src/main/resources/org/jenkinsci/plugins/xunit/XUnitPublisher/config.jelly
            src/main/resources/org/jenkinsci/plugins/xunit/threshold/Messages.properties
            src/main/resources/util/hetero-list-readonly.jelly
            src/main/resources/util/threshold.jelly
            src/test/java/org/jenkinsci/plugins/xunit/XUnitSerialisationTest.java
            src/test/java/org/jenkinsci/plugins/xunit/XUnitWorkflowTest.java
            src/test/resources/org/jenkinsci/plugins/xunit/XUnitSerialisationTest/builder_1_103/jobs/foo/config.xml
            src/test/resources/org/jenkinsci/plugins/xunit/XUnitSerialisationTest/publisher_1_103/jobs/foo/config.xml
            src/test/resources/org/jenkinsci/plugins/xunit/config.xml
            http://jenkins-ci.org/commit/xunit-plugin/845615f222e19c949bcf7ab7f09126e4f33c7c3e
            Log:
            JENKINS-37611 Add "@Symbol" annotation to xunit and parameters

            Move threshold parameters from required to optional. Remove also unreachable checks of % character in case of percent threshold mode. Add form validation for all threshold values.
            Add unit test to guarantee serialisation works properly with plugin version before 1.103.
            Manage negative value of time margin and fix NPE when a build step or recorder has no tools defined.

            Compare: https://github.com/jenkinsci/xunit-plugin/compare/fadb7994c960...845615f222e1
            *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

            Functionality will be removed from GitHub.com on January 31st, 2019.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/org/jenkinsci/plugins/xunit/AliasInitializer.java src/main/java/org/jenkinsci/plugins/xunit/XUnitBuilder.java src/main/java/org/jenkinsci/plugins/xunit/XUnitPublisher.java src/main/java/org/jenkinsci/plugins/xunit/XUnitUtil.java src/main/java/org/jenkinsci/plugins/xunit/threshold/FailedThreshold.java src/main/java/org/jenkinsci/plugins/xunit/threshold/SkippedThreshold.java src/main/java/org/jenkinsci/plugins/xunit/threshold/XUnitThreshold.java src/main/java/org/jenkinsci/plugins/xunit/threshold/XUnitThresholdDescriptor.java src/main/resources/org/jenkinsci/plugins/xunit/XUnitBuilder/config.jelly src/main/resources/org/jenkinsci/plugins/xunit/XUnitPublisher/config.jelly src/main/resources/org/jenkinsci/plugins/xunit/threshold/Messages.properties src/main/resources/util/hetero-list-readonly.jelly src/main/resources/util/threshold.jelly src/test/java/org/jenkinsci/plugins/xunit/XUnitSerialisationTest.java src/test/java/org/jenkinsci/plugins/xunit/XUnitWorkflowTest.java src/test/resources/org/jenkinsci/plugins/xunit/XUnitSerialisationTest/builder_1_103/jobs/foo/config.xml src/test/resources/org/jenkinsci/plugins/xunit/XUnitSerialisationTest/publisher_1_103/jobs/foo/config.xml src/test/resources/org/jenkinsci/plugins/xunit/config.xml http://jenkins-ci.org/commit/xunit-plugin/845615f222e19c949bcf7ab7f09126e4f33c7c3e Log: JENKINS-37611 Add "@Symbol" annotation to xunit and parameters Move threshold parameters from required to optional. Remove also unreachable checks of % character in case of percent threshold mode. Add form validation for all threshold values. Add unit test to guarantee serialisation works properly with plugin version before 1.103. Manage negative value of time margin and fix NPE when a build step or recorder has no tools defined. Compare: https://github.com/jenkinsci/xunit-plugin/compare/fadb7994c960...845615f222e1 * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

              People

              • Assignee:
                nfalco Nikolas Falco
                Reporter:
                bitwiseman Liam Newman
              • Votes:
                5 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: