Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38496

Aborted state should not look like failure

    Details

    • Sprint:
      tethys, pannonian, iapetus
    • Similar Issues:

      Description

      The aborted state currently looks like a failure (with a subtle icon) but it is not classed as a failure.
      See the attached design from Brody for how it should look.

      In Scope:

      • Header color should be as shown
      • Steps should reflect the aborted state

        Attachments

          Issue Links

            Activity

            Hide
            svanoort Sam Van Oort added a comment - - edited

            In answer to your questions:

            > Is "aborted" a failed state? should it be red?

            It's a special case of failure (like paused or waiting for input is a special case of "in progress") - an ErrorAction and also build result is attached to the step and its enclosing blocks.

            > What is a more appropriate icon?

            In classic Jenkins this merits a gray rather than red ball color. Personally, I'm all for it if you guys throw that out and do some sort of failure icon with additional decoration to show abort.

            > a bunch of questions about specific cases

            Yes, steps can be aborted, and yes they should carry the same indicator. Their enclosing block will too.

            I'd point you guys at the classic Jenkins Result object: http://javadoc.jenkins-ci.org/hudson/model/Result.html

            And the Bismuth (pipeline graph analysis) component here - https://github.com/jenkinsci/pipeline-graph-analysis-plugin/blob/master/src/main/java/org/jenkinsci/plugins/workflow/pipelinegraphanalysis/GenericStatus.java

            Show
            svanoort Sam Van Oort added a comment - - edited In answer to your questions: > Is "aborted" a failed state? should it be red? It's a special case of failure (like paused or waiting for input is a special case of "in progress") - an ErrorAction and also build result is attached to the step and its enclosing blocks. > What is a more appropriate icon? In classic Jenkins this merits a gray rather than red ball color. Personally, I'm all for it if you guys throw that out and do some sort of failure icon with additional decoration to show abort. > a bunch of questions about specific cases Yes, steps can be aborted, and yes they should carry the same indicator. Their enclosing block will too. I'd point you guys at the classic Jenkins Result object: http://javadoc.jenkins-ci.org/hudson/model/Result.html And the Bismuth (pipeline graph analysis) component here - https://github.com/jenkinsci/pipeline-graph-analysis-plugin/blob/master/src/main/java/org/jenkinsci/plugins/workflow/pipelinegraphanalysis/GenericStatus.java
            Hide
            michaelneale Michael Neale added a comment -

            Thanks Sam. I like Abort being disctinct from failure, quite clearly (ie grey isn't terribly) IMO

            Show
            michaelneale Michael Neale added a comment - Thanks Sam. I like Abort being disctinct from failure, quite clearly (ie grey isn't terribly) IMO
            Hide
            jamesdumay James Dumay added a comment -

            Sam Van Oort nice - thanks for the context!

            Michael Neale will need to get Vivek Pandey to consider this when he implements the bismuth api

            Show
            jamesdumay James Dumay added a comment - Sam Van Oort nice - thanks for the context! Michael Neale will need to get Vivek Pandey to consider this when he implements the bismuth api
            Hide
            brody Brody Maclean added a comment - - edited
            Show
            brody Brody Maclean added a comment - - edited Zeplin link https://zpl.io/H3odi Icon = Remove – https://design.google.com/icons/#ic_remove Mockup
            Hide
            jamesdumay James Dumay added a comment -

            Might want to ask Josh how best to fit this in as headers v2 are landing soon

            Show
            jamesdumay James Dumay added a comment - Might want to ask Josh how best to fit this in as headers v2 are landing soon

              People

              • Assignee:
                imeredith Ivan Meredith
                Reporter:
                jamesdumay James Dumay
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: