Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38617

SystemExit check when running system groovy scripts

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      When using system groovy scripts detects whether they are using system.exit()

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Victor Martinez
          Path:
          pom.xml
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java
          http://jenkins-ci.org/commit/jenkinslint-plugin/c63106a592f71ba4810d876082a12c1960818411
          Log:
          JENKINS-38617 System exit when running system groovy. WIP

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Victor Martinez Path: pom.xml src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java http://jenkins-ci.org/commit/jenkinslint-plugin/c63106a592f71ba4810d876082a12c1960818411 Log: JENKINS-38617 System exit when running system groovy. WIP
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Victor Martinez
          Path:
          pom.xml
          src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java
          http://jenkins-ci.org/commit/jenkinslint-plugin/147c0f78896b9c0b1645a2143520b11843ac66eb
          Log:
          JENKINS-38617 Added missing mvn dependnecies to run those tests accordingly. Added the right descfiption and using the right function to discover those system groovy scripts defects

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Victor Martinez Path: pom.xml src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java http://jenkins-ci.org/commit/jenkinslint-plugin/147c0f78896b9c0b1645a2143520b11843ac66eb Log: JENKINS-38617 Added missing mvn dependnecies to run those tests accordingly. Added the right descfiption and using the right function to discover those system groovy scripts defects
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Victor Martinez
          Path:
          pom.xml
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java
          http://jenkins-ci.org/commit/jenkinslint-plugin/0a852b69d3269df95f84f82a35a4dcc2b331ae89
          Log:
          JENKINS-38617 Refactored a bit to remove Optional plugin dependency by using Reflection

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Victor Martinez Path: pom.xml src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java http://jenkins-ci.org/commit/jenkinslint-plugin/0a852b69d3269df95f84f82a35a4dcc2b331ae89 Log: JENKINS-38617 Refactored a bit to remove Optional plugin dependency by using Reflection
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Victor Martinez
          Path:
          pom.xml
          src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java
          http://jenkins-ci.org/commit/jenkinslint-plugin/2f95712cd9f736442019ce1cc21644beeb3bca92
          Log:
          Merge pull request #3 from jenkinsci/groovy_system_exit

          JENKINS-38617 System exit when running system groovy.

          Compare: https://github.com/jenkinsci/jenkinslint-plugin/compare/2d83215ddbf0...2f95712cd9f7

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Victor Martinez Path: pom.xml src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java http://jenkins-ci.org/commit/jenkinslint-plugin/2f95712cd9f736442019ce1cc21644beeb3bca92 Log: Merge pull request #3 from jenkinsci/groovy_system_exit JENKINS-38617 System exit when running system groovy. Compare: https://github.com/jenkinsci/jenkinslint-plugin/compare/2d83215ddbf0...2f95712cd9f7
          Hide
          v2v Victor Martinez added a comment -

          Next release: 0.6.0

          Show
          v2v Victor Martinez added a comment - Next release: 0.6.0
          Hide
          mushuweasel Benjamin Abbott-Scott added a comment -

          I'm seeing the same impact in JenkinsDSL plugin.  Perhaps this needs treatment at the plugin handler level?

          Show
          mushuweasel Benjamin Abbott-Scott added a comment - I'm seeing the same impact in JenkinsDSL plugin.  Perhaps this needs treatment at the plugin handler level?

            People

            • Assignee:
              v2v Victor Martinez
              Reporter:
              v2v Victor Martinez
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: