Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39217

Credentials plugin 2.1.7 breaks gerrit integration

    Details

    • Similar Issues:

      Description

      Jenkins unable to start after upgrading credentials plugin from 2.1.6 to 2.1.7 and restarting the jenkins service.

      /var/log/jenkins/jenkins.log shows a continuing stream of:

      com.sonyericsson.hudson.plugins.gerrit.trigger.GerritProjectListUpdater tryLoadProjectList
      INFO: Not connected to gerrit, waiting for 64 second(s)
      

      Workaround available: Downgrade to credentials 2.1.6 plugin and restart.

        Attachments

          Activity

          Hide
          stephenconnolly Stephen Connolly added a comment -

          I find it exceedingly difficult to see how a client side Javascript change: https://github.com/jenkinsci/credentials-plugin/commit/d5172d3256dee5cf6c0d67025808e3132e748c9e that is only in affect when displaying the configuration screens could possibly be the culprit here.

          I suspect this may be actually a bug in the gerrit plugin. Specifically: https://github.com/jenkinsci/gerrit-trigger-plugin/blob/master/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/PluginImpl.java#L470-L490

          Searching the extension lists for other plugin classes before InitMilestone.EXTENSIONS_AUGMENTED will cause the world to blow up...

          Doing things like starting a connection to the Gerrit server (which will need credentials...) is not what should happen in the confusingly named Plugin#start() method.

          Moving this bug over to gerrit who actually own the issue.

          As to why reverting "worked"... well I think you just changed the order that plugins get loaded into the Guice container because of the version number change which had an ever so subtle effect on the plugin dependency graph

          Show
          stephenconnolly Stephen Connolly added a comment - I find it exceedingly difficult to see how a client side Javascript change: https://github.com/jenkinsci/credentials-plugin/commit/d5172d3256dee5cf6c0d67025808e3132e748c9e that is only in affect when displaying the configuration screens could possibly be the culprit here. I suspect this may be actually a bug in the gerrit plugin. Specifically: https://github.com/jenkinsci/gerrit-trigger-plugin/blob/master/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/PluginImpl.java#L470-L490 Searching the extension lists for other plugin classes before InitMilestone.EXTENSIONS_AUGMENTED will cause the world to blow up... Doing things like starting a connection to the Gerrit server (which will need credentials...) is not what should happen in the confusingly named Plugin#start() method. Moving this bug over to gerrit who actually own the issue. As to why reverting "worked"... well I think you just changed the order that plugins get loaded into the Guice container because of the version number change which had an ever so subtle effect on the plugin dependency graph

            People

            • Assignee:
              rsandell rsandell
              Reporter:
              alt_jmellor John Mellor
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: