Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39809

404s pages are inconsistent - blank page, ugly 404 and flashy 404

    XMLWordPrintable

    Details

    • Sprint:
      arctic, tasman
    • Similar Issues:

      Description

      In scope

      • If the run result is opened and no run or job exists it should go to the 404 page.

      Context
      https://ci.jenkins.io/blue/organizations/jenkins/Infra%2Fpatron/detail/PR-16/1/pipeline/

      [2016-11-17 04:48:18]  <@michaelneale>	@danielbeck: that pull request isn't in the UI any more
      [2016-11-17 04:48:40]  <@michaelneale>	@danielbeck: which may be why is blank (but should be 404)
      [2016-11-17 04:48:44]  <@danielbeck>	michaelneale merged?
      [2016-11-17 04:48:51]  <@danielbeck>	I merged it earlier
      [2016-11-17 04:48:56]  <@danielbeck>	but wtf this must be nicer
      [2016-11-17 04:49:05]  <@michaelneale>	Yes. Can you open ticket?
      [2016-11-17 04:49:07]  <@michaelneale>	That's bad.
      [2016-11-17 04:49:21]  <@i386>	so it looks like we are not handling 404s on that route anymore
      [2016-11-17 04:49:25]  <@i386>	so thats super broken
      [2016-11-17 04:51:44]  <@michaelneale>	Ok yes.
      [2016-11-17 04:52:04]  <@michaelneale>	Need to add acceptance test for that. I shall.

        Attachments

          Activity

          Hide
          tscherler Thorsten Scherler added a comment - - edited

          The only mentioning of the shiny one is in the pipelinePage.

                 if (pipeline && pipeline.$failed) {
                      return <NotFound />;
                  }
          

          Meaning I need to refactor the whole concept of the 404 pages.

          Show
          tscherler Thorsten Scherler added a comment - - edited The only mentioning of the shiny one is in the pipelinePage. if (pipeline && pipeline.$failed) { return <NotFound />; } Meaning I need to refactor the whole concept of the 404 pages.
          Hide
          tscherler Thorsten Scherler added a comment -

          The PR https://github.com/jenkinsci/blueocean-plugin/pull/622 will cover all but some MOBX related 404, which will be picked up by Ivan Meredith in another ticket.

          Show
          tscherler Thorsten Scherler added a comment - The PR https://github.com/jenkinsci/blueocean-plugin/pull/622 will cover all but some MOBX related 404, which will be picked up by Ivan Meredith in another ticket.
          Hide
          michaelneale Michael Neale added a comment -

          Can you make a follow on ticket? the case I saw that didn't work was pipeline results screen (is that what you mean?)

          Show
          michaelneale Michael Neale added a comment - Can you make a follow on ticket? the case I saw that didn't work was pipeline results screen (is that what you mean?)
          Hide
          tscherler Thorsten Scherler added a comment -

          Exactly Michael Neale the idea is that the mbox component will return always a valid object and not throw an exception when a 404 or 500 on the backend happens. This way each view can return the NotFound component they want, when they want.

          Show
          tscherler Thorsten Scherler added a comment - Exactly Michael Neale the idea is that the mbox component will return always a valid object and not throw an exception when a 404 or 500 on the backend happens. This way each view can return the NotFound component they want, when they want.
          Hide
          tscherler Thorsten Scherler added a comment -

          JENKINS-40032 please review if I have covered all bases Michael Neale

          Show
          tscherler Thorsten Scherler added a comment - JENKINS-40032 please review if I have covered all bases Michael Neale

            People

            • Assignee:
              tscherler Thorsten Scherler
              Reporter:
              danielbeck Daniel Beck
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: