Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39852

REGRESSION: Loading worm never finishes on dashboard

    XMLWordPrintable

    Details

    • Epic Link:
    • Sprint:
      arctic, tasman
    • Similar Issues:

      Description

      In a recent beta a regression was introduced that means the dashboard in most cases never finishes showing the loading worm.

      You can see this as the little white strip at the top. The app works, and you can navigate, but it looks very very bad and may be symtomatic of other problems.

      I know as of commit 7b7d2858e58caccd3b8e3d9f787bfb4f0c9ba103 this was not a problem.

      It seems to be introduce in this commit:

      1ba6c8edb0f3f5e1912bd6a0b1f842dd8e7690b0
      ie:
      https://github.com/jenkinsci/blueocean-plugin/commit/1ba6c8edb0f3f5e1912bd6a0b1f842dd8e7690b0

      Some explanation by Tom FENNELLY:

      "The <PageLoading> does not seem to be clicking into action on the pipelines page, with the result that the loading indicator just stays in a loading state forever, which looks a bit weird. I had a quick look at it but can't make any sense of it. Maybe someone else can.
      Seems like PageLoading is not activated on the page at all and so the LoadingIndicator show and hide functions are never called. That's just from a quick scan though, so not really sure."

        Attachments

          Issue Links

            Activity

            Hide
            michaelneale Michael Neale added a comment -

            Thorsten Scherler giving this to you as you may know what introduced it (hopfully not a major fix).

            Show
            michaelneale Michael Neale added a comment - Thorsten Scherler giving this to you as you may know what introduced it (hopfully not a major fix).
            Hide
            tfennelly Tom FENNELLY added a comment -

            Michael Neale I think this a duplicate of JENKINS-39671.

            Show
            tfennelly Tom FENNELLY added a comment - Michael Neale I think this a duplicate of JENKINS-39671 .
            Hide
            michaelneale Michael Neale added a comment -

            Yes Tom FENNELLY didn't see that - I will close that one and put the content here (less clicking) - I assume you would like Thor to take it on?

            Show
            michaelneale Michael Neale added a comment - Yes Tom FENNELLY didn't see that - I will close that one and put the content here (less clicking) - I assume you would like Thor to take it on?
            Hide
            tfennelly Tom FENNELLY added a comment -

            Michael Neale I assume you would like Thor to take it on?

            I was guessing that Keith Zantow would need to take it. I had a look at it and was a bit bamboozled as to how it was working, to the extent that fixing it was going to seem like a bit of trial and error guess-work, or else I was going to have to rewrite it in a way that made sense to me, and I don't like doing that. If Keith can't take it then I could have another look (and be a bit more patient).

            Show
            tfennelly Tom FENNELLY added a comment - Michael Neale I assume you would like Thor to take it on? I was guessing that Keith Zantow would need to take it. I had a look at it and was a bit bamboozled as to how it was working, to the extent that fixing it was going to seem like a bit of trial and error guess-work, or else I was going to have to rewrite it in a way that made sense to me, and I don't like doing that. If Keith can't take it then I could have another look (and be a bit more patient).
            Hide
            kzantow Keith Zantow added a comment -

            Not sure, maybe the introduction of cloning children affected the lifecycle somehow. I'll take a look at it in more detail.

            Show
            kzantow Keith Zantow added a comment - Not sure, maybe the introduction of cloning children affected the lifecycle somehow. I'll take a look at it in more detail.
            Hide
            michaelneale Michael Neale added a comment -

            ARIGATO

            Show
            michaelneale Michael Neale added a comment - ARIGATO

              People

              • Assignee:
                kzantow Keith Zantow
                Reporter:
                michaelneale Michael Neale
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: