Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41134

failures in the windows build are ignored

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      the Jenkisfile to build core ignores unit test failures on windows.

      https://ci.jenkins.io/job/Core/job/jenkins/job/master/209/console

      02:49:52.718 [Windows] Tests run: 9198, Failures: 53, Errors: 11, Skipped: 34, Flakes: 3
      02:49:52.718 [Windows] 
      02:49:52.718 [Windows] [ERROR] There are test failures.
      02:49:52.718 [Windows] 
      

      yet https://ci.jenkins.io/job/Core/job/jenkins/job/master/209 is PASSED

        Attachments

          Issue Links

            Activity

            Hide
            slide_o_mix Alex Earl added a comment -

            This is the change I made to TestResult.java

                void merge(TestResult other) {
                    for (SuiteResult suite : other.suites) {
                        suite.setParent(null); // otherwise freeze ignores it
                        add(suite);
                    }
                    tally();
                }
            

            The call to tally() at the end is the addition.

            Show
            slide_o_mix Alex Earl added a comment - This is the change I made to TestResult.java void merge(TestResult other) { for (SuiteResult suite : other.suites) { suite.setParent( null ); // otherwise freeze ignores it add(suite); } tally(); } The call to tally() at the end is the addition.
            Hide
            danielbeck Daniel Beck added a comment -

            That's where I'd have put it.

            Should be straightforward to write a test for.

            Show
            danielbeck Daniel Beck added a comment - That's where I'd have put it. Should be straightforward to write a test for.
            Show
            slide_o_mix Alex Earl added a comment - See https://github.com/jenkinsci/junit-plugin/pull/63
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Alex Earl
            Path:
            src/test/java/hudson/tasks/junit/TestResultTest.java
            src/test/resources/hudson/tasks/junit/JENKINS-41134/TestSuite_first.xml
            src/test/resources/hudson/tasks/junit/JENKINS-41134/TestSuite_second.xml
            http://jenkins-ci.org/commit/junit-plugin/c0f470f994693d50d78491bde7deb938903ccd7e
            Log:
            Add test for JENKINS-41134

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/test/java/hudson/tasks/junit/TestResultTest.java src/test/resources/hudson/tasks/junit/ JENKINS-41134 /TestSuite_first.xml src/test/resources/hudson/tasks/junit/ JENKINS-41134 /TestSuite_second.xml http://jenkins-ci.org/commit/junit-plugin/c0f470f994693d50d78491bde7deb938903ccd7e Log: Add test for JENKINS-41134
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Alex Earl
            Path:
            src/main/java/hudson/tasks/junit/TestResult.java
            src/test/java/hudson/tasks/junit/TestResultTest.java
            src/test/resources/hudson/tasks/junit/JENKINS-41134/TestSuite_first.xml
            src/test/resources/hudson/tasks/junit/JENKINS-41134/TestSuite_second.xml
            src/test/resources/hudson/tasks/junit/JENKINS-41134/TestSuite_second_dup_first.xml
            http://jenkins-ci.org/commit/junit-plugin/631c41350f6eb24520af19083a9f2fe27163f572
            Log:
            Merge pull request #63 from slide/master

            Fix JENKINS-41134

            Compare: https://github.com/jenkinsci/junit-plugin/compare/90e7ddbda961...631c41350f6e

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/hudson/tasks/junit/TestResult.java src/test/java/hudson/tasks/junit/TestResultTest.java src/test/resources/hudson/tasks/junit/ JENKINS-41134 /TestSuite_first.xml src/test/resources/hudson/tasks/junit/ JENKINS-41134 /TestSuite_second.xml src/test/resources/hudson/tasks/junit/ JENKINS-41134 /TestSuite_second_dup_first.xml http://jenkins-ci.org/commit/junit-plugin/631c41350f6eb24520af19083a9f2fe27163f572 Log: Merge pull request #63 from slide/master Fix JENKINS-41134 Compare: https://github.com/jenkinsci/junit-plugin/compare/90e7ddbda961...631c41350f6e

              People

              • Assignee:
                slide_o_mix Alex Earl
                Reporter:
                teilo James Nord
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: