Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41820

Builds are not triggered on hook notifications

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I did a fresh installation of Jenkins and configured a multibranch workflow project with github-branch-source. When push to the repository happens, I see the following in logs:

      Feb 07, 2017 4:15:34 PM org.jenkinsci.plugins.github.webhook.subscriber.DefaultPushGHEventSubscriber onEvent
      INFO: Received PushEvent for https://github.com/tarantool/cloud_doc
      Feb 07, 2017 4:15:34 PM org.jenkinsci.plugins.github_branch_source.PushGHEventSubscriber onEvent
      INFO: Received PUSH for https://github.com/tarantool/cloud_doc
      

      But no builds are triggered. I looked through other bug reports and tried to play with organization name capitalization, but it has no effect.

        Attachments

          Issue Links

            Activity

            Hide
            morgan_goose Morgan Goose added a comment -

            Stephen Connolly I can confirm Konstantin Nazarov's experience. After making my Github Org Folder's name lowercase, I'm getting builds tiriggered again.

            Show
            morgan_goose Morgan Goose added a comment - Stephen Connolly I can confirm Konstantin Nazarov 's experience. After making my Github Org Folder's name lowercase, I'm getting builds tiriggered again.
            Hide
            stephenconnolly Stephen Connolly added a comment -

            Morgan Goose Thanks for the confirmation of the case issue. I have already got a PR for the fix to that issue in review.

            I am now looking to understand some side comments you made earlier. It would be a great help if you could answer the following questions I asked earlier:

            So an Org Folder is supposed to ensure that the webhook is applied after a save. https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java#L522-L533 and it is supposed to register three events: https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubOrgWebHook.java#L49
            The Multibranch project is supposed to ensure that webhooks are registered after a save: https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L1187-L1192
            If you are not seeing the hooks being correctly applied after a save, please file a separate issue for that.

            Show
            stephenconnolly Stephen Connolly added a comment - Morgan Goose Thanks for the confirmation of the case issue. I have already got a PR for the fix to that issue in review. I am now looking to understand some side comments you made earlier. It would be a great help if you could answer the following questions I asked earlier: So an Org Folder is supposed to ensure that the webhook is applied after a save. https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java#L522-L533 and it is supposed to register three events: https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubOrgWebHook.java#L49 The Multibranch project is supposed to ensure that webhooks are registered after a save: https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L1187-L1192 If you are not seeing the hooks being correctly applied after a save, please file a separate issue for that.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestGHEventSubscriber.java
            src/main/java/org/jenkinsci/plugins/github_branch_source/PushGHEventSubscriber.java
            http://jenkins-ci.org/commit/github-branch-source-plugin/5cc878c3dabf5d6008d5b9e9aafbf4ce5a523714
            Log:
            [FIXED JENKINS-41820] Missed some comparisons that were case sensitive

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestGHEventSubscriber.java src/main/java/org/jenkinsci/plugins/github_branch_source/PushGHEventSubscriber.java http://jenkins-ci.org/commit/github-branch-source-plugin/5cc878c3dabf5d6008d5b9e9aafbf4ce5a523714 Log: [FIXED JENKINS-41820] Missed some comparisons that were case sensitive
            Hide
            morgan_goose Morgan Goose added a comment -

            Stephen Connolly I'm seeing the hooks work as you would expect.

            I was misunderstanding where the event for push was being sent from. I thought it would be on the repo itself, not the org. Now knowing this, everything is configured, and works as expected. That is aside from the case sensitivity, but you said you're working on that, and there is a user configurable workaround.

            thanks again for your work here

            Show
            morgan_goose Morgan Goose added a comment - Stephen Connolly I'm seeing the hooks work as you would expect. I was misunderstanding where the event for push was being sent from. I thought it would be on the repo itself, not the org. Now knowing this, everything is configured, and works as expected. That is aside from the case sensitivity, but you said you're working on that, and there is a user configurable workaround. thanks again for your work here
            Hide
            stephenconnolly Stephen Connolly added a comment -

            This was resolved last week

            Show
            stephenconnolly Stephen Connolly added a comment - This was resolved last week

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                racktear Konstantin Nazarov
              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: