Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41911

JSON aspects of Declarative don't work with jackson2-api plugin installed

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Fun with Jackson version conflicts! The jackson2-api plugin has newer Jackson jars that barf against the json-schema-validator version we're using. Sigh.

        Attachments

          Issue Links

            Activity

            Hide
            abayer Andrew Bayer added a comment -

            And I just remembered why we're on the 2.0.4 release of json-schema-validator (which uses old 2.2.x jackson): because the newer train of json-schema-validator (2.2.x, which uses 2.7.x jackson) also needs Guava 16. Ffffffff. Right. Time to remember how to shade.

            Show
            abayer Andrew Bayer added a comment - And I just remembered why we're on the 2.0.4 release of json-schema-validator (which uses old 2.2.x jackson): because the newer train of json-schema-validator (2.2.x, which uses 2.7.x jackson) also needs Guava 16. Ffffffff. Right. Time to remember how to shade.
            Hide
            abayer Andrew Bayer added a comment -
            Show
            abayer Andrew Bayer added a comment - PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/111 , shading away Jackson.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pipeline-model-api/pom.xml
            pipeline-model-definition/pom.xml
            pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/Converter.groovy
            pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/JSONParser.groovy
            pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/endpoints/ModelConverterAction.java
            pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BaseParserLoaderTest.java
            pipeline-model-json-shaded/pom.xml
            pom.xml
            http://jenkins-ci.org/commit/pipeline-model-definition-plugin/7a06eb4fce798ddfe12d220106d76b7744c6096a
            Log:
            [FIXED JENKINS-41911] Shade away Jackson

            This took some hoop-jumping, but now we should be guaranteed to use
            our own copy of Jackson at all times. Phew.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pipeline-model-api/pom.xml pipeline-model-definition/pom.xml pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/Converter.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/JSONParser.groovy pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/endpoints/ModelConverterAction.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BaseParserLoaderTest.java pipeline-model-json-shaded/pom.xml pom.xml http://jenkins-ci.org/commit/pipeline-model-definition-plugin/7a06eb4fce798ddfe12d220106d76b7744c6096a Log: [FIXED JENKINS-41911] Shade away Jackson This took some hoop-jumping, but now we should be guaranteed to use our own copy of Jackson at all times. Phew.
            Hide
            abayer Andrew Bayer added a comment -

            Merged, releasing shortly as 1.0.1.

            Show
            abayer Andrew Bayer added a comment - Merged, releasing shortly as 1.0.1.

              People

              • Assignee:
                abayer Andrew Bayer
                Reporter:
                abayer Andrew Bayer
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: