Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41980

"Suppress automatic SCM triggering" property must be respected when events trigger the build

    Details

    • Similar Issues:

      Description

      Steps to reproduce:

      1. Create multibranch pipeline project.
      2. Under project configuration, add GitHub source.
      3. Select "All branches get the same properties" under Property Strategy.
      4. Add "Suppress automatic SCM triggering" property.
      5. Save configuration.
      6. Make sure that GitHub repo configured at step 2 sends push notifications to your Jenkins instance via /github-webhook endpoint.
      7. Push something to the repo.

      Expected result

      Build triggering was suppressed.

      Actual result

      Build is triggered.

      This got broken after recent 1.x -> 2.x updates to SCM API and Co.

        Attachments

          Issue Links

            Activity

            Show
            anenviousguest Vladislav Ponomarev added a comment - How about https://github.com/jenkinsci/branch-api-plugin/pull/83 ?
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Vladislav Ponomarev
            Path:
            src/main/java/jenkins/branch/NoTriggerBranchProperty.java
            src/main/java/jenkins/branch/NoTriggerOrganizationFolderProperty.java
            http://jenkins-ci.org/commit/branch-api-plugin/d7334e5a0399895ac0abfad8a9bab5b3fa8c2b39
            Log:
            JENKINS-41980 SCM triggering should also be suppressed for GitHub webhooks.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vladislav Ponomarev Path: src/main/java/jenkins/branch/NoTriggerBranchProperty.java src/main/java/jenkins/branch/NoTriggerOrganizationFolderProperty.java http://jenkins-ci.org/commit/branch-api-plugin/d7334e5a0399895ac0abfad8a9bab5b3fa8c2b39 Log: JENKINS-41980 SCM triggering should also be suppressed for GitHub webhooks.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/branch/NoTriggerBranchProperty.java
            src/main/java/jenkins/branch/NoTriggerOrganizationFolderProperty.java
            http://jenkins-ci.org/commit/branch-api-plugin/a8ae07cbc48c205a0c8a4c507ff20fbb7075411d
            Log:
            Merge pull request #83 from anenviousguest/master

            JENKINS-41980 SCM triggering should also be suppressed for branch events

            Compare: https://github.com/jenkinsci/branch-api-plugin/compare/717536bff4fb...a8ae07cbc48c

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/NoTriggerBranchProperty.java src/main/java/jenkins/branch/NoTriggerOrganizationFolderProperty.java http://jenkins-ci.org/commit/branch-api-plugin/a8ae07cbc48c205a0c8a4c507ff20fbb7075411d Log: Merge pull request #83 from anenviousguest/master JENKINS-41980 SCM triggering should also be suppressed for branch events Compare: https://github.com/jenkinsci/branch-api-plugin/compare/717536bff4fb...a8ae07cbc48c
            Hide
            schneidexe Thomas Schneider added a comment -

            I think this introduced a bug, as the original idea of this property was to supress only build from indexing. Now all git hooks are suppressed as well.... see JENKINS-45814

            Show
            schneidexe Thomas Schneider added a comment - I think this introduced a bug, as the original idea of this property was to supress only build from indexing. Now all git hooks are suppressed as well.... see JENKINS-45814
            Hide
            stephenconnolly Stephen Connolly added a comment -

            Nope this fixed a bug, Suppressing SCM Triggers should suppress all builds triggered by a detected change in the SCM irrespective of how the change was detected

            Show
            stephenconnolly Stephen Connolly added a comment - Nope this fixed a bug, Suppressing SCM Triggers should suppress all builds triggered by a detected change in the SCM irrespective of how the change was detected

              People

              • Assignee:
                anenviousguest Vladislav Ponomarev
                Reporter:
                anenviousguest Vladislav Ponomarev
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: