Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42291

REGRESSION: Clicking on the cog icon in blue ocean takes you to an invalid page.

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Fixed
    • Component/s: blueocean-plugin
    • Labels:
      None
    • Environment:
      Clients: OSX Sierra Safari, Windows 10 IE,
      Server: Ubuntu 16, Apache Reverse Proxy 2.4, Java 8
    • Similar Issues:
    • Epic Link:
    • Sprint:
      1.0

      Description

      Clicking on the cog item adds an additional '/jenkins/' to the path when clicking on the cog item causing a 404 error.

      Incorrect url = https://jenkins.***.***/jenkins/job/********/configure
      Correct url = https://jenkins.***.***/job/********/configure

      Administration and Logout/login buttons go to the correct path without the additional '/jenkins/'

      Edit: this is particularly nasty. regression introduced in this commit: https://github.com/jenkinsci/blueocean-plugin/commit/d4a615534c8f8a5e94affc1a612038be90b109f9 with a refactoring.
      This would never have worked when running on root - it would always fall back to pre-prepending /jenkins, as it didn't detect that the root was set, correctly.

      Tom FENNELLY proposed fix: https://github.com/jenkinsci/blueocean-plugin/pull/859 - are you able to look at that, do a beta publish dance and adjust that PR to make it testable? it worked locally when I tried it (changes suggested by josh, but there may be a better way). Basically empty string is "falsey" in javascript, so that would never have worked, ever.

        Attachments

          Issue Links

            Activity

            a1dutch Andrew Holland created issue -
            Hide
            vensder Dmitry Makarov added a comment -

            Yes, it's happened after updating blue ocean plugins up to 1.0.0-b24 version.
            After downgrade all this plugins down to 1.0.0-b23 links become correct again.

            Show
            vensder Dmitry Makarov added a comment - Yes, it's happened after updating blue ocean plugins up to 1.0.0-b24 version. After downgrade all this plugins down to 1.0.0-b23 links become correct again.
            jamesdumay James Dumay made changes -
            Field Original Value New Value
            Assignee Tom FENNELLY [ tfennelly ]
            jamesdumay James Dumay made changes -
            Sprint 1.0 [ 221 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            jamesdumay James Dumay made changes -
            Epic Link JENKINS-35749 [ 171790 ]
            jamesdumay James Dumay made changes -
            Rank Ranked lower
            Hide
            michaelneale Michael Neale added a comment -

            Ugh that is really annoying, this used to work fine. Not sure what changed. I can reproduce this.

            Show
            michaelneale Michael Neale added a comment - Ugh that is really annoying, this used to work fine. Not sure what changed. I can reproduce this.
            michaelneale Michael Neale made changes -
            Summary Clicking on the cog icon in blue ocean takes you to an invalid page. REGRESSION: Clicking on the cog icon in blue ocean takes you to an invalid page.
            michaelneale Michael Neale made changes -
            Priority Major [ 3 ] Blocker [ 1 ]
            michaelneale Michael Neale made changes -
            Description Clicking on the cog item adds an additional '/jenkins/' to the path when clicking on the cog item causing a 404 error.

            Incorrect url = https://jenkins.***.***/jenkins/job/********/configure
            Correct url = https://jenkins.***.***/job/********/configure


            Administration and Logout/login buttons go to the correct path without the additional '/jenkins/'
            Clicking on the cog item adds an additional '/jenkins/' to the path when clicking on the cog item causing a 404 error.

            Incorrect url = https://jenkins.***.***/jenkins/job/********/configure
            Correct url = https://jenkins.***.***/job/********/configure


            Administration and Logout/login buttons go to the correct path without the additional '/jenkins/'

            Edit: this is particularly nasty. regression introduced in this commit: https://github.com/jenkinsci/blueocean-plugin/commit/d4a615534c8f8a5e94affc1a612038be90b109f9 with a refactoring.
            This would never have worked when running on root - it would always fall back to pre-prepending /jenkins, as it didn't detect that the root was set, correctly.

            [~tfennelly] proposed fix: https://github.com/jenkinsci/blueocean-plugin/pull/859 - are you able to look at that, do a beta publish dance and adjust that PR to make it testable? it worked locally when I tried it (changes suggested by josh, but there may be a better way). Basically empty string is "falsey" in javascript, so that would never have worked, ever.

            michaelneale Michael Neale made changes -
            Rank Ranked higher
            Hide
            michaelneale Michael Neale added a comment -

            Proposed fix in the description (There may be better options, but need to be tested, as this is tricky to test in all cases)

            Show
            michaelneale Michael Neale added a comment - Proposed fix in the description (There may be better options, but need to be tested, as this is tricky to test in all cases)
            michaelneale Michael Neale made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            tfennelly Tom FENNELLY made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            tfennelly Tom FENNELLY made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            michaelneale Michael Neale made changes -
            Link This issue is duplicated by JENKINS-42408 [ JENKINS-42408 ]
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-42425 [ JENKINS-42425 ]
            batmat Baptiste Mathus made changes -
            Link This issue is duplicated by JENKINS-42485 [ JENKINS-42485 ]
            jbriden Jenn Briden made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                tfennelly Tom FENNELLY
                Reporter:
                a1dutch Andrew Holland
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: