Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42764

connection through credentials does not work

    Details

    • Similar Issues:

      Description

      When specifying credentials to connect to MQTT, the plugin does not use these credentials.

      When trying the "test connection" button in the job configuration page, however, the credentials are correctly used.

        Attachments

          Activity

          Show
          mhuin Matthieu Huin added a comment - proposed PR: https://github.com/jenkinsci/mqtt-notification-plugin/pull/7
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: mhuin
          Path:
          src/main/java/jenkins/plugins/mqttnotification/MqttNotifier.java
          src/test/java/jenkins/plugins/mqttnotification/MqttNotifierTest.java
          http://jenkins-ci.org/commit/mqtt-notification-plugin/b6b5954228a9f4e6a8eb50e832b28c92115ed811
          Log:
          Fix JENKINS-42764

          Let notifier use credentials if defined

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: mhuin Path: src/main/java/jenkins/plugins/mqttnotification/MqttNotifier.java src/test/java/jenkins/plugins/mqttnotification/MqttNotifierTest.java http://jenkins-ci.org/commit/mqtt-notification-plugin/b6b5954228a9f4e6a8eb50e832b28c92115ed811 Log: Fix JENKINS-42764 Let notifier use credentials if defined
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Gareth Western
          Path:
          src/main/java/jenkins/plugins/mqttnotification/MqttNotifier.java
          src/test/java/jenkins/plugins/mqttnotification/MqttNotifierTest.java
          http://jenkins-ci.org/commit/mqtt-notification-plugin/6529c2416da766155823282551567b886303ba2e
          Log:
          Merge pull request #7 from mhuin/JENKINS_42764

          Fix JENKINS-42764

          Compare: https://github.com/jenkinsci/mqtt-notification-plugin/compare/a10e6560bbfd...6529c2416da7

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gareth Western Path: src/main/java/jenkins/plugins/mqttnotification/MqttNotifier.java src/test/java/jenkins/plugins/mqttnotification/MqttNotifierTest.java http://jenkins-ci.org/commit/mqtt-notification-plugin/6529c2416da766155823282551567b886303ba2e Log: Merge pull request #7 from mhuin/JENKINS_42764 Fix JENKINS-42764 Compare: https://github.com/jenkinsci/mqtt-notification-plugin/compare/a10e6560bbfd...6529c2416da7
          Hide
          gareth_western Gareth Western added a comment -

          Oh I may have introduced this bug while attempting to add the unit test, sorry. Thanks for the PR!

          Show
          gareth_western Gareth Western added a comment - Oh I may have introduced this bug while attempting to add the unit test, sorry. Thanks for the PR!
          Hide
          mhuin Matthieu Huin added a comment -

          No problem, although since I am not a Java expert at all, I'd advise you to test the code as well to make sure the fix is correct.

          Show
          mhuin Matthieu Huin added a comment - No problem, although since I am not a Java expert at all, I'd advise you to test the code as well to make sure the fix is correct.

            People

            • Assignee:
              mhuin Matthieu Huin
              Reporter:
              mhuin Matthieu Huin
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: