Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42784

Unable to create new pipeline for empty repo in brand new github org

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      Blue Ocean 1.0-rc3

      Description

      Found a new "edge case" - basically if an org folder is being created and then an empty repo added, it wont offer to create a Jenkinsfile in github. if the org folder already exists, then everything works as expected. 

      To reproduce: 

      • Create an empty github repo - no commits
      • Ensure your jenkins has no github org folder for what you are about to add
      • Add a new github pipeline via blue ocean - and pick your empty repo

       

      Note that it will "time out" and not offer to create a pipeline, only an empty org folder will exist. 

      If you then repeat the above, it should result in an offer to create a Jenkinsfile (ie the second time, it seems to work). Somehow the creation of the org folder the first time prevents somethign from happening that prompts the editor. 

       

      I am not sure if this is in the creation flow code or the editor though... hard to tell. It is probably not an uncommon case to come across. 

        Attachments

          Activity

          Hide
          cliffmeyers Cliff Meyers added a comment -

          Sounds as though all of these PR's will be abandoned in favor of some changes that Keith Zantow is going to implement, per discussion in Gitter room. Possible changes include:

          1. possible improvement to API to support "add repo" use case. Rather than requiring a PUT request that includes the full repo list each time, allow a simpler request to that adds a single repo to anything existing.
          2. ensure single repo optimization happens for "update" calls in addition to create
          3. Change impl not to use regex (unclear to me what this would entail)
          Show
          cliffmeyers Cliff Meyers added a comment - Sounds as though all of these PR's will be abandoned in favor of some changes that Keith Zantow is going to implement, per discussion in Gitter room. Possible changes include: possible improvement to API to support "add repo" use case. Rather than requiring a PUT request that includes the full repo list each time, allow a simpler request to that adds a single repo to anything existing. ensure single repo optimization happens for "update" calls in addition to create Change impl not to use regex (unclear to me what this would entail)
          Hide
          cliffmeyers Cliff Meyers added a comment -

          Assigning to Keith as it sounds like there are some significant changes coming in backend. I'm happy to implement the frontend changes once those are in place - just reassign the ticket when ready and CC me on the PR. Thanks!

          Show
          cliffmeyers Cliff Meyers added a comment - Assigning to Keith as it sounds like there are some significant changes coming in backend. I'm happy to implement the frontend changes once those are in place - just reassign the ticket when ready and CC me on the PR. Thanks!
          Hide
          cliffmeyers Cliff Meyers added a comment -

          Adding details of an issue discovered by Isa Vilacides during exploratory testing. I am confident the underlying issue here is the same but want to preserve it for traceability:

          Problem: The copy of "Just one repository" github pipeline creation is confusing. It says that it's recommended if you do not have a jenkinsfile, but if you do not have a jenkinsfile, then no pipeline is created and it says that the pipeline is pending to be created when it will never be

          Steps to reproduce

          1. Click on create a pipeline and chose "Github"→ some organization → Just one repository
          2. Chose any repo with no jenkinsfile and click on "Create pipeline"

          Current result

          • It spins creating pipeline until it times out
          • The pipeline is not created but the message is "Saving was successful and pipeline creation is in progress. Go to the dashboard..." so my expectation is that there is a background process that will keep trying or so on. The message should be: there is no jenkinsfile and no pipeline has been created
          Show
          cliffmeyers Cliff Meyers added a comment - Adding details of an issue discovered by Isa Vilacides during exploratory testing. I am confident the underlying issue here is the same but want to preserve it for traceability: Problem: The copy of "Just one repository" github pipeline creation is confusing. It says that it's recommended if you do not have a jenkinsfile, but if you do not have a jenkinsfile, then no pipeline is created and it says that the pipeline is pending to be created when it will never be Steps to reproduce Click on create a pipeline and chose "Github"→ some organization → Just one repository Chose any repo with no jenkinsfile and click on "Create pipeline" Current result It spins creating pipeline until it times out The pipeline is not created but the message is "Saving was successful and pipeline creation is in progress. Go to the dashboard..." so my expectation is that there is a background process that will keep trying or so on. The message should be: there is no jenkinsfile and no pipeline has been created
          Hide
          vilacides Isa Vilacides added a comment -

          To add to that:

          • The copy seems confusing since it says "It says that it's recommended if you do not have a jenkinsfile" and you can actually use it with a jenkinsfile.
          • If you import a huge organisation, the user is not advised that it might take a loooong time if there are many repos. They just see pipelines popping up but there is no sense of progress and this causes customers to retry to import it because they think that it just didn't work (it happened to 3 our of 4 team members in my team). I believe we should have a disclaimer letting the customer know that it might take long and that they can check progress in the classic view on the scan job or something like that.
          Show
          vilacides Isa Vilacides added a comment - To add to that: The copy seems confusing since it says "It says that it's recommended if you do not have a jenkinsfile" and you can actually use it with a jenkinsfile. If you import a huge organisation, the user is not advised that it might take a loooong time if there are many repos. They just see pipelines popping up but there is no sense of progress and this causes customers to retry to import it because they think that it just didn't work (it happened to 3 our of 4 team members in my team). I believe we should have a disclaimer letting the customer know that it might take long and that they can check progress in the classic view on the scan job or something like that.
          Hide
          kzantow Keith Zantow added a comment -

          Isa Vilacides this isn't the right issue for text changes, please comment on this issue: JENKINS-42135

          Show
          kzantow Keith Zantow added a comment - Isa Vilacides this isn't the right issue for text changes, please comment on this issue:  JENKINS-42135

            People

            • Assignee:
              kzantow Keith Zantow
              Reporter:
              michaelneale Michael Neale
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: