Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42850

Pagination DIV being rendered even when paging is disabled

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • None
    • OS: Windows Server 2012
      Jenkins: 2.7.2
      Browser: Chrome 36.0.1985.125

      Even when the option "Enable paging" is disabled, there's a pagination DIV being rendered with a height of 22px.

      Tracking down the code, it seems to be related with the refreshPipelines function in pipe.js:

      this.refreshPipelines = function(data, divNames, errorDiv, view, showAvatars...) {
          [...]
          if (!showAvatars) {
              html.push("<div class='pagination'>");
              html.push(component.pagingData);
              html.push("</div>");
          }
          [...]
      }
      

      It would seem that if I enabled the option to show avatars, the pagination DIV would not be rendered. But it is rendered still.

      It appears to be a problem when calling the refreshPipelines function.

      It is passing the value of the "fullscreen" variable to the "showAvatars" parameter:

      this.updatePipelines = function(divNames, errorDiv, view, fullscreen...) {
          Q.ajax({
              success: function (data) {
                  self.refreshPipelines(data, divNames, errorDiv, view, fullscreen...);
                  [...]
              },
              [...]
          });
      }
      

      I confirmed it by accessing the pipeline page adding "?fullscreen=1" to the url, then the DIV was not rendered.

            pskumar448 Suresh Kumar
            mtschneiders Mateus Scheniders
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: