Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43022

Not correct exclude path to domains

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I am using the Credential plugin for Jenkins, and I think I have detected a bug.

      I am going to explain the steps I have followed .(sorry for my English

      1. First, I create the domain and exclude the path XXXX
         
      2. Second, I created the credentials for my user inside this domain
         
      3. Then, I configure the job, pasting the url repo.
      4. And the credentials show me jsanchra and None values. I guess the Credentials only should show None value, is that correct? Maybe I have a configuration mistake?

        Attachments

        1. credential-exclusion-a-01.PNG
          credential-exclusion-a-01.PNG
          35 kB
        2. credential-exclusion-b-01.PNG
          credential-exclusion-b-01.PNG
          35 kB
        3. credentials-exclusion-a-02.png
          credentials-exclusion-a-02.png
          27 kB
        4. credentials-exclusion-a-03.png
          credentials-exclusion-a-03.png
          19 kB
        5. credentials-exclusion-b-02.png
          credentials-exclusion-b-02.png
          24 kB
        6. credentials-exclusion-b-03.png
          credentials-exclusion-b-03.png
          17 kB
        7. image1.png
          image1.png
          37 kB
        8. image2.png
          image2.png
          19 kB
        9. image3.png
          image3.png
          28 kB
        10. image5.png
          image5.png
          10 kB
        11. image6.png
          image6.png
          20 kB

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: juan francisco sanchez
            Path:
            src/main/java/org/jenkinsci/plugins/gitclient/GitURIRequirementsBuilder.java
            src/test/java/org/jenkinsci/plugins/gitclient/GitURIRequirementsBuilderTest.java
            http://jenkins-ci.org/commit/git-client-plugin/a865e011e91050bc074b319f656436c3b7d88c13
            Log:
            JENKINS-43022 - Honor git credential path exclusion and inclusion

            Tests scp URL form in GitURIRequirementsBuilderTest

            Adds assertions for path.getPath(), including incorrect relative scp path.

            Credentials PathRequirement incorrectly converts relative path to
            absolute path. Adapt the test to that error, since PathRequirement
            is likely used in many other cases where the prefixing of a '/' to the
            relative path is the expected and desired behavior.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: juan francisco sanchez Path: src/main/java/org/jenkinsci/plugins/gitclient/GitURIRequirementsBuilder.java src/test/java/org/jenkinsci/plugins/gitclient/GitURIRequirementsBuilderTest.java http://jenkins-ci.org/commit/git-client-plugin/a865e011e91050bc074b319f656436c3b7d88c13 Log: JENKINS-43022 - Honor git credential path exclusion and inclusion Tests scp URL form in GitURIRequirementsBuilderTest Adds assertions for path.getPath(), including incorrect relative scp path. Credentials PathRequirement incorrectly converts relative path to absolute path. Adapt the test to that error, since PathRequirement is likely used in many other cases where the prefixing of a '/' to the relative path is the expected and desired behavior.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Mark Waite
            Path:
            src/main/java/org/jenkinsci/plugins/gitclient/GitURIRequirementsBuilder.java
            src/test/java/org/jenkinsci/plugins/gitclient/GitURIRequirementsBuilderTest.java
            http://jenkins-ci.org/commit/git-client-plugin/3ba074ccee0e9677e1f0431349c3e069206675dc
            Log:
            Merge pull request #249 from MarkEWaite/master-PR242-credentials-exclude-path

            JENKINS-43022 - Honor git credential path exclusion and inclusion

            Compare: https://github.com/jenkinsci/git-client-plugin/compare/eef4e1d17fef...3ba074ccee0e

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: src/main/java/org/jenkinsci/plugins/gitclient/GitURIRequirementsBuilder.java src/test/java/org/jenkinsci/plugins/gitclient/GitURIRequirementsBuilderTest.java http://jenkins-ci.org/commit/git-client-plugin/3ba074ccee0e9677e1f0431349c3e069206675dc Log: Merge pull request #249 from MarkEWaite/master-PR242-credentials-exclude-path JENKINS-43022 - Honor git credential path exclusion and inclusion Compare: https://github.com/jenkinsci/git-client-plugin/compare/eef4e1d17fef...3ba074ccee0e
            Hide
            markewaite Mark Waite added a comment - - edited

            Will be included in the next release of the git client plugin. A pre-release build is available from the last stable build of the git client plugin

            Show
            markewaite Mark Waite added a comment - - edited Will be included in the next release of the git client plugin. A pre-release build is available from the last stable build of the git client plugin
            Hide
            jsanchra juan francisco sanchez ramos added a comment -

            Thanks Mark Waite , sorry to solvent your detected issue. I've been overworked lately

            Thanks man!!

            Show
            jsanchra juan francisco sanchez ramos added a comment - Thanks Mark Waite , sorry to solvent your detected issue. I've been overworked lately Thanks man!!
            Hide
            markewaite Mark Waite added a comment -

            Git client plugin 2.5.0 released 27 Jul 2017 includes this fix

            Show
            markewaite Mark Waite added a comment - Git client plugin 2.5.0 released 27 Jul 2017 includes this fix

              People

              • Assignee:
                markewaite Mark Waite
                Reporter:
                jsanchra juan francisco sanchez ramos
              • Votes:
                15 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: